From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059359; b=Kf3u3Zc8j2yMmzjJ1FJTBVuqiCGARugByNZw/CVoVOr2QS7yLSltCFWmmAuMQDR6hl6O y36fSrfecGbxyDE+265wPLi67+yPdxRbiz5pb1xZZWZT+UfOQisrJvB42tJfWRzYM6vg2 UoDWl24SEWDimo7Kkh6KBrFwUebSnPO4emY2NgIAPxL/RJafRVqyoPHTX7wXn7wOn8zcl IIxG120DjzTglzyKXRtUmzmjOqyZ9WVDbXZjdWW0FEu91KYqIe4Wx40l4QkMHd90Rpw9a To53dcrvLt6DGgjLKYEErp5/LYZ/jJMnHeAqHgfHbyLPS7OG/PS2axe2QwiHdv27qZQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059359; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=uecagVoyV1jf1qqLuV5/ewbrTtUUfa1sq/TPZkuH0qs=; b=hoGFvEfMFrOUWHiuBE0bCy7irzKZfQA9Tya5X+vELeHvB2bneTnh/a6EQ8klPuCqQrH/ wgoT7q2Kq/dvEALzj/t+vbcxFdDwuKu8PymwI/+ZSEXSjXcXt0LGxjU8QjZxheLJ3kb8v D+6jKmxKrHUPzFOQXny2RsCszA95h7/cII6K9Q0cMbexhLJZvnNN4yRc1izpZ1AOtGeCS an3kAbwaxhlH4MdsIWw65BU03W09dmAMi87hyYcR3XorfuDYyiD/svtm81vDY9aVs3BEB YdyNvcgiuRuqKAwrgbOhaOKMW9UxjGYua/d4SD12rJNMNahvGo3HUKyzqCHrWDc986Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=H0TjmXth; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26598606A31C; Thu, 19 Nov 2026 03:35:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=H0TjmXth Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804C91F000C4; Thu, 19 Nov 2026 03:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059359; bh=uecagVoyV1jf1qqLuV5/ewbrTtUUfa1sq/TPZkuH0qs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=H0TjmXth9KbpFaJAJKYsks/YzhyuMgPoCDNuWrxuWrpwU2VoUxCFhiTey1ZIWJqBy Glk9dMPLjADXwKXoJVgS/AVn75dIa7x6MaTf+f2oypCfSt4xbAe90hbZwloiL5Lzpx FGgd8MS9LawanRPRjBJj8oCNi4Qve9W52SbKXwiQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sean Christopherson , Paolo Bonzini , Sasha Levin Subject: [PATCH 5.10 0814/1848] KVM: x86/mmu: Bug the VM if a vCPU ends up in long mode without PAE enabled Date: Wed, 18 Nov 2026 15:47:32 +0100 Message-ID: <20261118145950.446367403@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sean Christopherson [ Upstream commit 72e2fb24a0b0528bcc16a8f6ad2cf336ac361525 ] Promote the ASSERT(), which is quite dead code in KVM, into a KVM_BUG_ON() for KVM's sanity check that CR4.PAE=1 if the vCPU is in long mode when performing a walk of guest page tables. The sanity is quite cheap since neither EFER nor CR4.PAE requires a VMREAD, especially relative to the cost of walking the guest page tables. More importantly, the sanity check would have prevented the true badness fixed by commit 112e66017bff ("KVM: nVMX: add missing consistency checks for CR0 and CR4"). The missed consistency check resulted in some versions of KVM corrupting the on-stack guest_walker structure due to KVM thinking there are 4/5 levels of page tables, but wiring up the MMU hooks to point at the paging32 implementation, which only allocates space for two levels of page tables in "struct guest_walker32". Queue a page fault for injection if the assertion fails, as both callers, FNAME(gva_to_gpa) and FNAME(walk_addr_generic), assume that walker.fault contains sane info on a walk failure. E.g. not populating the fault info could result in KVM consuming and/or exposing uninitialized stack data before the vCPU is kicked out to userspace, which doesn't happen until KVM checks for KVM_REQ_VM_DEAD on the next enter. Move the check below the initialization of "pte_access" so that the aforementioned to-be-injected page fault doesn't consume uninitialized stack data. The information _shouldn't_ reach the guest or userspace, but there's zero downside to being paranoid in this case. Link: https://lore.kernel.org/r/20230729004722.1056172-9-seanjc@google.com Signed-off-by: Sean Christopherson Signed-off-by: Paolo Bonzini Stable-dep-of: 115f9405a2ed ("KVM: x86/mmu: Bug the VM if KVM attempts to walk more levels than the MMU has") Signed-off-by: Sasha Levin --- arch/x86/kvm/mmu/paging_tmpl.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h index 3778070381a8b..0db6414300d2d 100644 --- a/arch/x86/kvm/mmu/paging_tmpl.h +++ b/arch/x86/kvm/mmu/paging_tmpl.h @@ -351,7 +351,6 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker, } #endif walker->max_level = walker->level; - ASSERT(!(is_long_mode(vcpu) && !is_pae(vcpu))); /* * FIXME: on Intel processors, loads of the PDPTE registers for PAE paging @@ -361,6 +360,17 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker, nested_access = (have_ad ? PFERR_WRITE_MASK : 0) | PFERR_USER_MASK; pte_access = ~0; + + /* + * Queue a page fault for injection if this assertion fails, as callers + * assume that walker.fault contains sane info on a walk failure. I.e. + * avoid making the situation worse by inducing even worse badness + * between when the assertion fails and when KVM kicks the vCPU out to + * userspace (because the VM is bugged). + */ + if (KVM_BUG_ON(is_long_mode(vcpu) && !is_pae(vcpu), vcpu->kvm)) + goto error; + ++walker->level; do { -- 2.53.0