From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795028547; b=FXm2xzAHihlR6dbnrZrvQYcbpSPIzfbT8nxHBS41uZYKiuCeDRCANQvpiJRkabagPPmI /rSJTUnAFV/QoGspqa9wVbVFLnLXV0lrBRCIotwZCpFaFT8mHfsxBzfdoWr7QB67cCnDu NZacunUA+aGcssHMe4xDSs1kVgvqRPFr34x1c7wM6ezaVqRTUP45HuLS7uXnyuQr3LSHS 2pXYhR4cNT3nQSHDn9xZYz3vLqU/H4SxK9LmXZ/f/2cbUnOYVJkEAp+u6A+rX1eDtDibM nUUkOMuLjdESzoDvPTUGWUMgz9VA11RRSi/JRHZer9KnBcVFZYnAgxWRP2xU0wDCDAQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795028547; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=JnqHH+Ojjy1PUVjOCeVRYU+a1yXcIJOK7cJHmGgKPG8=; b=GVZ9fikTuwp1vm5F2Kxd/fEEaO8Yzu6i2sHMlhlZA2eKvcbsihf78dfe5UOfVvlQriBt or6fpvZhLv3UDBE8u+Iextf6FqC0lVMO9YMKqNZiWMCk04GmChrb32ZDKod0MJrnWxwQV i09kV9B3BMOuEJmAVtMEUagtQ11P6n1NNeDAXXSB4rbnavlYqk1y8fYKIyteMIpQGRWiE wif2I0DCLqzZGzGk+aedTyJ5Noauc8j+CeF76OAe+kKv0UURWz7B+mzjDaIijzkTudB+M HY6KSoaRCHtRZyN8VRU4oWJ9LrAoc7BmvhtBpknGZOnnUlpbcF5pvuSC7UEZBeXaNEQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=A+iV3wWI; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC318606A31C; Wed, 18 Nov 2026 19:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=A+iV3wWI Received: by smtp.kernel.org (Postfix) with ESMTPSA id 508C41F000C4; Wed, 18 Nov 2026 19:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795028546; bh=JnqHH+Ojjy1PUVjOCeVRYU+a1yXcIJOK7cJHmGgKPG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=A+iV3wWIyORjm5rNsXx4tgEuoijO802jHe1j5dP7L0vE8V1Ed/0RWXKDk+xqq7zqc oAF7cZa6Y2Z5nGQfBv23bOOLxo+ntLbufWEqzUmKNTgK1LxylfPwxjZly6lgegMJ9U mZMtfFKfYaQg6Voom/TFj8ALlAecAy5BQqaKsJ0o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chengfeng Ye , Andrew Morton , Xu Xin , "David Hildenbrand (Arm)" , Hugh Dickins , Sasha Levin Subject: [PATCH 6.12 0035/1756] mm/ksm: mark migration stores with WRITE_ONCE() Date: Wed, 18 Nov 2026 15:36:02 +0100 Message-ID: <20261118150009.251535402@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chengfeng Ye [ Upstream commit d3863210464f69c18615cbe400d48a6e53e770d4 ] ksm_get_folio() deliberately samples stable_node->kpfn and folio->mapping without taking the folio lock because the KSM folio may be migrated concurrently. folio_migrate_ksm() updates the same state using plain assignments. The reader can load the old kpfn, then the migrator can store the new kpfn, execute smp_wmb(), and clear the old folio's mapping before the reader checks that mapping. Thus the initial kpfn load can overlap its update and the subsequent mapping load can overlap the clear, with no common lock. This leaves marked READ_ONCE() accesses racing with plain stores. The kernel reported: BUG: KCSAN: data-race in folio_migrate_ksm / ksm_get_folio read (marked) to 0xffff8ce401421330 of 8 bytes by task 48 on cpu 3: ksm_get_folio+0x7f/0x2a0 ksm_scan_thread+0x1635/0x3330 kthread+0x1af/0x1f0 write to 0xffff8ce401421330 of 8 bytes by task 102 on cpu 1: folio_migrate_ksm+0x6a/0xd0 folio_migrate_flags+0x193/0x420 __migrate_folio.isra.0+0x162/0x1a0 migrate_folio+0x4c/0x70 move_to_new_folio+0xd6/0x170 Use WRITE_ONCE() for both stores to pair them with the existing lockless reads. This preserves the existing smp_wmb()/smp_rmb() migration protocol and control flow while preventing compiler transformations of the shared accesses. Link: https://lore.kernel.org/20260824112433.191301-1-nicoyip.dev@gmail.com Fixes: c8d6553b9580 ("ksm: make KSM page migration possible") Signed-off-by: Chengfeng Ye Signed-off-by: Andrew Morton Acked-by: Xu Xin Acked-by: David Hildenbrand (Arm) Cc: Hugh Dickins Cc: [ sashal: Replaced FOLIO_MAPPING_KSM with the equivalent PAGE_MAPPING_KSM flag. ] Signed-off-by: Sasha Levin --- mm/ksm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index e64a0dbcad5dd..9a98aa97317a4 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -1067,7 +1067,8 @@ static inline void folio_set_stable_node(struct folio *folio, struct ksm_stable_node *stable_node) { VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio); - folio->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); + WRITE_ONCE(folio->mapping, + (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM)); } #ifdef CONFIG_SYSFS @@ -3258,7 +3259,7 @@ void folio_migrate_ksm(struct folio *newfolio, struct folio *folio) stable_node = folio_stable_node(folio); if (stable_node) { VM_BUG_ON_FOLIO(stable_node->kpfn != folio_pfn(folio), folio); - stable_node->kpfn = folio_pfn(newfolio); + WRITE_ONCE(stable_node->kpfn, folio_pfn(newfolio)); /* * newfolio->mapping was set in advance; now we need smp_wmb() * to make sure that the new stable_node->kpfn is visible -- 2.53.0