From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795028996; b=zsL8WzSvi0wBttlETY5TWWWnJBdkTIw4YZPlkgXQg4cgd+rsNW5FBq2FuINatJ+1Ff+Y P1cAfLAh3Oxu84N/0PhdoVTYddh+8s8zTNS57hP7ZbSmqYF9gk90u4utWylmumE6eK1pY PkvJJCdUoA2pt59FVEkL535eo/oS7kdqt6IK86fvXGP3jUUNwDQS5OZp2rjmClEpPouEw E6Mndummg7Db4lcxDbrZc65Pfua7kACMGmGf9w9ak9Xm3VC6GxyPyT0xPEbxAVrNo12tb 79pObLjmVzzbvLpBL6jogTEi94mKv1ghqdkvgvVynKAWtBegzzOlKf2HD/ssxJR2w4g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795028996; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=GK1BMC5I9YxCZEZsNoZfv5+R4d/Sm88wH7sIfgKF0+8=; b=Sf/WhBgQNZTgNMvBjj3zYGhqTrib+ndPTsJCVKV6Wh9l5mrqWHXW2+uq1mHHBu5jDUDs Z0GtgmCvypRetV0OrIKYMzv0QITrtyl+bpbfdutJXBI5Dr45NBnMDauSSAJFtVdjS1KFd QoysA9560mAMUmJOAbdWImlC2S6dnlBkjY+vau7XF70lmzqTDWtMzM/TXntRm5RRR8Mia wklKtkgvvCsPSfZW74MDIMH6qP8wJM2uJmMdKikceFgLUs7i+JEYtxlBa5Rmzi3MA0czh 7WQ58yp+8m6suju1bPpOOCEiqrc9jZ/Bchn6h1tOYsQzSwkRpJ0BU8nY79Q3/ep21bg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yrG0EOlJ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67CA6606A31C; Wed, 18 Nov 2026 19:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yrG0EOlJ Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE7FC1F000C4; Wed, 18 Nov 2026 19:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795028996; bh=GK1BMC5I9YxCZEZsNoZfv5+R4d/Sm88wH7sIfgKF0+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yrG0EOlJ2ZGrMKdBlViFbeBPZXS/uCcFKu64irfIPKRi1GCQvFqnocLvlIO38Ito/ cB10iV1fhXIWii5ggYJ9kZ8F2akmQerWe8WClg/v4jXOiH17a4g8ZkOxneYfLYaXjC Ax8vOChXes3cTQDed7yv72JnptE9P7Qoy6u77H+k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Orgad Shaneh , Dan Carpenter , Sasha Levin Subject: [PATCH 6.12 0192/1756] staging: octeon: schedule the TX cleanup tasklet every 1024th packet Date: Wed, 18 Nov 2026 15:38:39 +0100 Message-ID: <20261118150016.045978421@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Orgad Shaneh [ Upstream commit db57f6517bf65523968ae29cd34a790bfa7d32af ] cvm_oct_xmit() means to schedule the cleanup tasklet once every 1024 packets, as its comment says, to cover the pathological case of heavy traffic on one port delaying the cleanup of another port blocked waiting for it. The test is inverted: total_to_clean & 0x3ff is true for 1023 of every 1024 values, and false only on the multiples of 1024. So the tasklet is scheduled on nearly every packet, and skipped on exactly the packet the comment wants. That costs one TASKLET softirq per transmitted packet, each walking every port and doing an FAU fetch-and-add per non-empty queue, and it buys nothing for this port, which already frees its completed skbs inline from the skb_to_free value it reads out of the FAU. Test the mask against zero. On a CN50XX board (2 cores at 300MHz) carrying ~6.9k transmitted packets/s, TASKLET softirqs drop from 7133/s to 597/s with no throughput change; the freeing work is conserved, so this removes softirq entries, not work. Fixes: 4898c560103f ("Staging: Octeon: Free transmit SKBs in a timely manner") Signed-off-by: Orgad Shaneh Reviewed-by: Dan Carpenter Link: https://patch.msgid.link/20260820113239.8169-1-orgads@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/octeon/ethernet-tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c index e54b4a413dc40..4c66d43b66ee1 100644 --- a/drivers/staging/octeon/ethernet-tx.c +++ b/drivers/staging/octeon/ethernet-tx.c @@ -483,7 +483,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev) cvmx_fau_fetch_and_add32(FAU_TOTAL_TX_TO_CLEAN, 1); } - if (total_to_clean & 0x3ff) { + if ((total_to_clean & 0x3ff) == 0) { /* * Schedule the cleanup tasklet every 1024 packets for * the pathological case of high traffic on one port -- 2.53.0