From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029187; b=AHGj2gYNsVq/c2QPYqjBpy8Ny/2pxoKnUzT4ivtMFitKw5O2D88OTbKFUiSTgFCmwfYm xR86qMZk5uyXswZuGANf4bqKmusIMXUhGgqb/1hycFTMSH+Rks4XZ3wQAvGg570MwhFei +cwbnp9QEZ6eYBovbQrMD5wWtzeleTbJJ/Khl9CzN9fglRaaCVtjwS4bhhP+FxESz+K5h P07GIPHm0D5QRbaCXybQhgYpHGRkGLMUwCjqbUugJXRYi4hgD1WpqbOq4MV6W2qdpwMVt W/kMCFzxJzgJj+1o9o0qJNZW/6RZrjsXYs1/FZLXsQBQ2xmVLQuoo3yxMNmO1e38txA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029187; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=n2XN2Pqh/2GVQopQG5mm0wqPJF1lcrnbqF4wNQieXdI=; b=MYFJ7YJiZ7UySbGCh9kj8cVE8jarlrOWgRuMy8OEE7g+6nnF5SHiOMF7UVkUJVZAR8h1 8TqVeTzTgY55UO30OpWd5vgkhgFk8GKcAbOGtmm8TZO6piHdd90XnRCwllUuwATsKD/kH mMURtS/9ygITSa+lra3FJyDoS6TBYgQIz7WUIm/Wasep/jKOMjjSBjmz2xtIpnJ07Xfue bNejDWYOf1m4Q0DJ48O3axzgzUqPWQX4bLWmzCGsSWt9Kp5GsUK+LnHxnMQrknSsgvfZ1 DEFrSN3XukX0wrF8MgE9gJtGczsERNiZbsXtsGfGq9mQY604M6Bz62QAyBXzk90wf8g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=PUucX1UT; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A572606A31C; Wed, 18 Nov 2026 19:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=PUucX1UT Received: by smtp.kernel.org (Postfix) with ESMTPSA id C07121F000C5; Wed, 18 Nov 2026 19:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795029187; bh=n2XN2Pqh/2GVQopQG5mm0wqPJF1lcrnbqF4wNQieXdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PUucX1UTevZGHkPODQskSATmCbnEcTrMtWkBQwcoX2igDesIDmXjK/hRv6DBMNtUy H7GtNx5PgSLds8m11lEBpVOUD8Pf9g8/2bPMUnog2FLxkKU6qNLH4w+xKIwiV++Dig B9tqYURZNKD+TMI7KVUW/DyPFMeP72/PNe4VMQLc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, bui duc phuc , Mark Brown , Sasha Levin Subject: [PATCH 6.12 0259/1756] ASoC: mediatek: mt8186: Fix clock handling in mux disable path Date: Wed, 18 Nov 2026 15:39:46 +0100 Message-ID: <20261118150018.675305681@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: bui duc phuc [ Upstream commit d70109f5510b423e72894dadfbab27087a7b26b0 ] In the disable path of the appl*_mux_setting() functions, clk_disable_unprepare() is called after clk_set_parent(). If clk_set_parent() fails, clk_disable_unprepare() is skipped, potentially leaving one of the clocks enabled. Remove the goto exit paths so that all teardown steps are attempted and any errors are only reported. Fixes: 55b423d5623c ("ASoC: mediatek: mt8186: support audio clock control in platform driver") Signed-off-by: bui duc phuc Link: https://patch.msgid.link/20260903051150.178057-3-phucduc.bui@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/mediatek/mt8186/mt8186-afe-clk.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-afe-clk.c b/sound/soc/mediatek/mt8186/mt8186-afe-clk.c index dddb3ec55248e..effc4193e63ea 100644 --- a/sound/soc/mediatek/mt8186/mt8186-afe-clk.c +++ b/sound/soc/mediatek/mt8186/mt8186-afe-clk.c @@ -131,7 +131,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_ENG1], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG1]); @@ -141,7 +140,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_1], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_1]); } @@ -158,7 +156,6 @@ static int apll1_mux_setting(struct mtk_base_afe *afe, bool enable) afe_priv->clk[CLK_CLK26M]); clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_1]); ERR_ENABLE_CLK_TOP_MUX_AUD_1: -EXIT: return ret; } @@ -205,7 +202,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_ENG2], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_ENG2]); @@ -215,7 +211,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, bool enable) dev_err(afe->dev, "%s clk_set_parent %s-%s fail %d\n", __func__, aud_clks[CLK_TOP_MUX_AUD_2], aud_clks[CLK_CLK26M], ret); - goto EXIT; } clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_2]); } @@ -232,7 +227,6 @@ static int apll2_mux_setting(struct mtk_base_afe *afe, bool enable) afe_priv->clk[CLK_CLK26M]); clk_disable_unprepare(afe_priv->clk[CLK_TOP_MUX_AUD_2]); ERR_ENABLE_CLK_TOP_MUX_AUD_2: -EXIT: return ret; } -- 2.53.0