From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029289; b=QIVZQQliCmcoUil0Ub55wZVNzNcKNFR3JlVciLfLfBrXNGDOv4IBNF3Lzas9wYpytSPy HhNl5QcMspB83TXLwxuZYLhTX8m9Ci7A3zQ0Zm6E6q87WY8z6Wqng4r1m7Z2T/KfsjeAf +1jGRy2rejnnkkrlIuxjJR2q1bEQyYrXtJVP38YmnYqJ3rxDjcfxf/GQVUVFWIe7+JoPv UtTuJVNIxGg7viWLea5Nu9haNZkHhAet3w/XL3J2+FwqXlj/5wyob4Tq9wsCDHM0NuGUr ZX+Z538WWf/23wouVkU4PVgYQHqpfgAzrNJcEORL4GriQ9TEV0LIiOpGVnkqTs7SOxw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029289; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=iGqSvWeK69ctylzIgs0+WErd9+mNdy/TFhvmYXgOfjk=; b=ofpeHU9dGU9LmrUkreJkR8QVm4k9tksx/4zfRM0MFx6RQDhlnz+MGmd4jTJnZYMYPir5 i5vyxIo4H2cJCmJEZ5RHmiYoM8mu8v7nVgwOl2BYNEFouq0sZbjitpLH4XHcwlCRrGJAT UFKZdH612+lVd7NEM36bzIYBk0WrhPY38fKGK7qJc/61N2FhZoVnQy5sEUI563PvXggvC PzuFuzNd4AEVJSAqGha1oXT9MGVDzQIdkruKl9xYw2VmHyoFyVBCb+f6kChHr602/Qna/ wvcetq4NUxXmPkTFT0TRJJKg+Oh4nmNfGB6ta3jsQs2KCK6NxcGMM6Jx5Mrn2zPa1sg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="bOle/GRX"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E90C6606A31C; Wed, 18 Nov 2026 19:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bOle/GRX Received: by smtp.kernel.org (Postfix) with ESMTPSA id 459EA1F000C4; Wed, 18 Nov 2026 19:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795029288; bh=iGqSvWeK69ctylzIgs0+WErd9+mNdy/TFhvmYXgOfjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bOle/GRX+HBt+bRX/ZTrpF+nBI0N0nUhgi9JOGmFHD2rlnmpekRxwBhfLk9wlHqW4 lg6VAg/nkUlLNC2hBujxbmIsZx25dsRdtrPlc/j7qxetO3QJOk74taTEylq12viTv2 9B2+qctUaqTRxW1YM0iZqtIhf0N/cTo9tlRqjFlM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ryan Brue , Sebastian Reichel , Sasha Levin Subject: [PATCH 6.12 0296/1756] power: supply: bq24190_charger: use the wake irq API Date: Wed, 18 Nov 2026 15:40:23 +0100 Message-ID: <20261118150020.146503725@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ryan Brue [ Upstream commit ece9baab2a6e79224d3f591893be23b540b1625f ] bq24190_probe() calls enable_irq_wake() on the charger interrupt and never calls disable_irq_wake(). That is wrong in three ways. It is unbalanced. free_irq() does not touch desc->wake_depth -- only irq_set_irq_wake() does -- so after the driver is unbound the descriptor is still one wake reference deep and the irqchip is still configured for wake, forever, for an interrupt nobody owns any more. It ignores the device's wakeup policy. The chip is made a system wake source whether or not anyone asked for it, and because device_init_wakeup() is never called there is no power/wakeup attribute for userspace to say otherwise. A board that would rather not be woken by its charger has no way to express that. And it arms the interrupt for wake permanently, from probe onwards, rather than for the sleep it is meant to cover. Use the wake irq API instead: devm_device_init_wakeup() to make the device wakeup-capable and enabled -- preserving today's behaviour -- and devm_pm_set_wake_irq() to hand the interrupt to the PM core, which arms it in dpm_suspend_noirq() (only if device_may_wakeup(), immediately before suspend_device_irqs()) and disarms it on resume. Both are unwound by devm, so the reference is balanced on unbind, and userspace gets the power/wakeup control it should have had. No intended change in behaviour: charger events still wake the system by default. The same conversion was made to another charger driver for the same reason, in commit 6c5393771c50 ("power: supply: qcom_pmi8998_charger: fix wakeirq"). Fixes: f385e6e2a153 ("power: bq24190_charger: Use PM runtime autosuspend") Assisted-by: LLM Signed-off-by: Ryan Brue Link: https://patch.msgid.link/20260908-rbrue-suez-upstreaming-bq24190_charger-use-wake-irq-api-v1-1-c3f10ae2a34a@gmail.com Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/bq24190_charger.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index c47f32f152e60..35611eca057e1 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -2151,7 +2152,13 @@ static int bq24190_probe(struct i2c_client *client) if (ret < 0) goto out_charger; - enable_irq_wake(client->irq); + ret = devm_device_init_wakeup(dev); + if (ret < 0) + goto out_charger; + + ret = devm_pm_set_wake_irq(dev, client->irq); + if (ret < 0) + goto out_charger; pm_runtime_mark_last_busy(dev); pm_runtime_put_autosuspend(dev); -- 2.53.0