From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795051688; b=VotcN2J981cz1ww8l+CuyQpNzxRuPN8ibTqOnH1UzUh4tZf027M27SGCItYLJmMUOo30 Q8gkmzaSMchhp/+NJSaFVyKuZ6x9sGiGEWuXMfU9/IoXbib26ld0KZSzNuhwkhcUn1BMz i0/GDdHVd38/c7gzgqgOi2dDeSrF5po+1Tz00uCra7eYgX/SiJiYEcOVbt7RIO9ljvUTJ zF3usR2H7ZEQbCYYXf49qsF9YCNKQPldMaFzRj+PKIEHV1mYX7pRNcF1315JgxmmYI6ta DHaUUnF1vy4XM/7/bf9Ml+4mwGhMlPP9392gpM2coETS0ksQFf0AWPeWrRdBInAp71w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795051688; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=IpELwHwgYkYL0M1WmLBLxrRHEXhNI5ynLmQmAePmS24=; b=Ma3XGq9V1Ir/1yjbXOfO02nrffN/lnUB9gSmRUZma+c5dxKz02YL4dcfjAOs5iBDKyvV iIlcrQC1xl6uKRwhDnKw0PC6FgYXdL4xygSD80/N0XQYPCKxBDieIJfTSLxYBHmyd4x9I V0q0QVVP1yphVhQFw86NWWOhJVB5MIKfghFuAi9AetcNdKXpCAnY1PWFia8szv5Csy2T2 w+mE5jkKXqRY6Li7KFBkJtgdhYFxuZzWbVfab0X0ZF8PmUik/9dYFjisqcOv+4r4YHKuc LB2wFNG9girY5Dc+EyVcRnahXqSIAMvzctb6NJCtRvV/Qhde+YXGZnhBuIwTdEsOy7Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rODjc59T; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E318606A320; Thu, 19 Nov 2026 01:28:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rODjc59T Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEEB81F000C4; Thu, 19 Nov 2026 01:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795051688; bh=IpELwHwgYkYL0M1WmLBLxrRHEXhNI5ynLmQmAePmS24=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rODjc59TFkvJ/+dV1usvJZDPZIYj3oHux5Ro9HikV9EdUdRVv/bgt0aKojzlW4V3O 47E8SQq24MieIn4mQQk93hFAYHdRWotFh/vsp20od57aB6sL38qHGZGsejx6iyv9mF YKMBjCSrA9L2W4Hfu4tCtxazpYNk8Ig3DMxs3+60= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pei Xiao , Hans Verkuil Subject: [PATCH 5.15 0296/2214] media: cx23885: Fix use-after-free in cx23885_finidev due to race condition Date: Wed, 18 Nov 2026 15:32:52 +0100 Message-ID: <20261118150022.025004117@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pei Xiao commit 75016a992d9b03f5cc6df1414d1da35840d4feeb upstream. In cx23885_v4l2_dev_notify_init, &dev->cx25840_work is bound with cx23885_av_work_handler, and &dev->ir_rx_work and &dev->ir_tx_work are bound with cx23885_ir_rx_work_handler and cx23885_ir_tx_work_handler. cx23885_irq can schedule these works on system_wq when an AV_CORE interrupt is received, and the IR subdevice can also schedule the IR works from its interrupt service routine via the v4l2_device notify callback. If we remove the device, cx23885_finidev makes cleanup and the memory allocated for dev is released by kfree(dev), while the works mentioned above may still be pending or running. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | cx23885_irq | schedule_work(&dev->cx25840_work) cx23885_finidev | cx23885_input_fini(dev) | cx23885_ir_fini(dev) | cx23885_shutdown(dev) | free_irq(pci_dev->irq, dev) | pci_disable_device(pci_dev) | cx23885_dev_unregister(dev) | v4l2_device_unregister(v4l2_dev) | kfree(dev) | // dev is freed | | cx23885_av_work_handler | // use dev (use-after-free) Fix it by canceling the works after the IRQ handler that can schedule them has been stopped, and before proceeding with the remaining cleanup in cx23885_finidev. Note that the flush_work() calls in cx23885_input_ir_stop() do not close this race: they only wait for works that are already queued or running at that moment, they do not prevent the IRQ handler, which is still registered at that point, from scheduling the works again afterwards, and they are skipped entirely when dev->sd_ir is NULL. The cancel_work_sync() calls are therefore placed after free_irq(), the only point at which no new work can be scheduled. Fixes: e5514f104d87 ("V4L/DVB: cx23885: Move AV Core irq handling to a work handler") Cc: stable@vger.kernel.org Assisted-by: Codex:deepseek-v4-flash Signed-off-by: Pei Xiao Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/pci/cx23885/cx23885-core.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/media/pci/cx23885/cx23885-core.c +++ b/drivers/media/pci/cx23885/cx23885-core.c @@ -2230,6 +2230,10 @@ static void cx23885_finidev(struct pci_d /* unregister stuff */ free_irq(pci_dev->irq, dev); + cancel_work_sync(&dev->cx25840_work); + cancel_work_sync(&dev->ir_rx_work); + cancel_work_sync(&dev->ir_tx_work); + pci_disable_device(pci_dev); cx23885_dev_unregister(dev);