From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795052194; b=ZZdh3Cc2GSHWYUrwSCeYT28OqX2qo4mZ+owe6tuelWTaLna5i6sSn/wtHiC6oWsd6e+E eqyMQYTWkTFThu8a5V6mo/P5hw4iLgL1CGGgZPzEBuOGe8vxcvCf8aAa2+8ZfHYdjjX7y ihOFGqsIgsffyatUbs55gjovwwDetJuwE7MQgU4si1vwzihOjUKoa14ud6Zu6JwWvupFQ 4s6cZXOpKeuW9/e6ySj4DGkMP34DQWGNx8C1qBA74R9ueJxMzHGTbRkBynotUtgAOxA6t HUvIbpR2BhDY61Tfp08p3pifgrzl81mOepjJqsWKN6IHQ2C/Ue2GAeN8L4f6UNG8MdQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795052194; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=C8/F5y7AwJKPH15rYVML8MkEcyUbvetx+CaS+OKKyjk=; b=psCse9InGqWfNdkuY6H6ufGvDBiMT01oPiv9NTz6SQw9w3T3UHf4T6Q/ii+VlJb/XKnW xAL/oiRCofMlaH0En4ZUVITamd8OnkdIIgQgddjoONobgZx4jEZQ9d2d55fQjEmDlEsEJ gz5OUMeYB9VQji749oUi+sy44NY2LNF3dJtABmrT9dIXfDffNSRZNi+ML7mlYbEqyE+l4 6M/v6WX7yrmT9NLvWOf3HQhNrWUcgBTzW2MmOgkl0vfH1rdE76jk5BPewDk3OOTww/MqM /ZemX+OSo9QnEzjctPBzt4CUa6R4xi+pgIO8BlOP92cHuUrlYH45b9OYcUshKrn48Eg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=XsEMaJOG; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44BF5606A320; Thu, 19 Nov 2026 01:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=XsEMaJOG Received: by smtp.kernel.org (Postfix) with ESMTPSA id 971AB1F000C4; Thu, 19 Nov 2026 01:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795052194; bh=C8/F5y7AwJKPH15rYVML8MkEcyUbvetx+CaS+OKKyjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XsEMaJOGONrvAi0npxCZcAZ+VjyIXSqcxUby+7Chp58pH3eZr5dc3HTkHID2mTPk/ sg63vwcD2cqzpdVP0TEvfIPyo5bn/5ArK+VARrssFsqfag74dA+XDkVq3FP7N9cJ0z 3zAb4KWZQqo4p0tNQanBF6ucpcYWr7zrCndfBSNI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jean-Baptiste Maneyrol , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.15 0478/2214] iio: imu: inv_icm42600: fix odr change not caught in certain cases Date: Wed, 18 Nov 2026 15:35:54 +0100 Message-ID: <20261118150030.280138633@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jean-Baptiste Maneyrol [ Upstream commit f670d4d3477386d62017936f0121909f93ac17f8 ] When using both accel and gyro with different frequencies, the ODR change flag in the FIFO header can be sometime in a packet with invalid data. Since we are ignoring these packets, we miss the ODR change and any further change are blocked until sensor is turned off. Fix this by moving the packet data validity check after the ODR change flag check. Fixes: ec74ae9fd37c ("iio: imu: inv_icm42600: add accurate timestamping") Cc: stable@vger.kernel.org Signed-off-by: Jean-Baptiste Maneyrol Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 8 ++++---- drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c index f7ba257a3b0b2..6f209f0a97e95 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c @@ -771,15 +771,15 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev) if (size <= 0) return size; - /* skip packet if no accel data or data is invalid */ - if (accel == NULL || !inv_icm42600_fifo_is_data_valid(accel)) - continue; - /* update odr */ if (odr & INV_ICM42600_SENSOR_ACCEL) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); + /* skip packet if no accel data or data is invalid */ + if (accel == NULL || !inv_icm42600_fifo_is_data_valid(accel)) + continue; + memcpy(&buffer.accel, accel, sizeof(buffer.accel)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c index f67e4cfa9cf3f..ce1b4e804a662 100644 --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c @@ -783,15 +783,15 @@ int inv_icm42600_gyro_parse_fifo(struct iio_dev *indio_dev) if (size <= 0) return size; - /* skip packet if no gyro data or data is invalid */ - if (gyro == NULL || !inv_icm42600_fifo_is_data_valid(gyro)) - continue; - /* update odr */ if (odr & INV_ICM42600_SENSOR_GYRO) inv_sensors_timestamp_apply_odr(ts, st->fifo.period, st->fifo.nb.total, no); + /* skip packet if no gyro data or data is invalid */ + if (gyro == NULL || !inv_icm42600_fifo_is_data_valid(gyro)) + continue; + memcpy(&buffer.gyro, gyro, sizeof(buffer.gyro)); /* convert 8 bits FIFO temperature in high resolution format */ buffer.temp = temp ? (*temp * 64) : 0; -- 2.53.0