From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030583; b=G/MuRtobT3jn2Yp1Kxvy+h7TbvYScn+92pKLEhzJ8LZwzrO0TqC80ZWnu8DMHfjo1Moh aWhrwRCQSzZgpDTBhnSzpOk3QNqOZgP8fZ0c53wzea+yxPBzhonzJMWldytTKKmJAUbX9 MzFatMZyzJk0IkJAAtwpCshE9VJBaCTkTDKETXWBqEtMdAu7jdasDkpKjiI/9E+/Tn+K7 VLC5kdl2n9aT0v92jtFvMu2FNuhF6YuMOkYu4mYg+/aZcbg5BqTj1+fGL1bxuTQn6OW9H WuFm9Hchw2CyyDPigW5FDSZFWmrIULq2ufpdUtero5FxAqscEhilThoojSXjYXux1jw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030583; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=hPMfPkmRjwZ5GFgxXDOYAhkQEe1E/xVnQmFALGj7z4E=; b=fzqVQ4fgH/Lubl7NSkLGDoK0OZfsghC0uL7YRvo271nOn6r2k080G1F4jRDEKoORWiLU 8OY8pyEmRRwX5+QQyk6ATfEEelgfe8YqEAl+YT0BYzN3F0vtQIKyPv/Wnt8gIY2smRNct tVTjb0xRdGwA5Wj+7YnxNiHTcE5Tou8grxXRVMlwdUnUH1tztfXq/xrF+Ij4mIMESR5LG /voCJNDMG8hPx9sv3FYnknb6cZRz5n4GicDuC6DVdpgcVCQmtgXcp2m4uHxJKt/42pabR Fsv1kg7lnKOeixtg3fAS9OwhT3NXQrFbwdt5qW645JQJB6nd9W/GvLJq1qfw0yu4h5A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h9HJEa7b; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFBE360A381D; Wed, 18 Nov 2026 19:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=h9HJEa7b Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA0A1F000CB; Wed, 18 Nov 2026 19:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030582; bh=hPMfPkmRjwZ5GFgxXDOYAhkQEe1E/xVnQmFALGj7z4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=h9HJEa7bEHvilaK574wl8CAGIIKOOIwUOqvQpFn966I8Cn5gCeO4DMGPfl+htu0aG qNEOnxFe8poauIyOyQpw6p3LYpxPyAq2EO9VEyEOL/LlgLNraBTyvGjMeKdd/4e6PD jp1lowexDO9nQPpjvfhb1XfHkv3zUruOYfEJXGx4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liu Dalin , Linus Walleij , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.12 0757/1756] rtc: ftrtc010: fix integer overflow in time calculation Date: Wed, 18 Nov 2026 15:48:04 +0100 Message-ID: <20261118150039.766930713@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Dalin [ Upstream commit 32f04694fa87b8ac9fa58f9ceb2dc6cbc476e2a1 ] In ftrtc010_rtc_read_time() and ftrtc010_rtc_set_time(), all variables (offset, days, hour, min, sec) are u32. The expression "days * 86400 + hour * 3600 + min * 60 + sec" is evaluated in 32-bit arithmetic, which silently wraps around for dates beyond approximately year 2106 (U32_MAX / 86400 ≈ 49710 days). In ftrtc010_rtc_read_time(), perform the addition in 32-bit arithmetic first to preserve two's complement wrapping for negative offsets, then cast the result to timeu64_t. In ftrtc010_rtc_set_time(), cast individual u32 operands to timeu64_t before multiplication to prevent overflow in the right-hand side of the offset calculation. Fixes: 1d61d2592c1f ("rtc: gemini/ftrtc010: rename driver and symbols") Assisted-by: Sashiko AI [static analysis] Signed-off-by: Liu Dalin Reviewed-by: Linus Walleij Tested-by: Liu Dalin Link: https://patch.msgid.link/42C8FBD59AA34EA9+20260827080320.3351155-4-liudalin@kylinsec.com.cn Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-ftrtc010.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index 2f610a0fc6e9b..c989574b1fbc6 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -73,7 +73,7 @@ static int ftrtc010_rtc_read_time(struct device *dev, struct rtc_time *tm) days = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); offset = readl(rtc->rtc_base + FTRTC010_RTC_RECORD); - time = offset + days * 86400 + hour * 3600 + min * 60 + sec; + time = (timeu64_t)(offset + days * 86400 + hour * 3600 + min * 60 + sec); rtc_time64_to_tm(time, tm); @@ -93,7 +93,8 @@ static int ftrtc010_rtc_set_time(struct device *dev, struct rtc_time *tm) hour = readl(rtc->rtc_base + FTRTC010_RTC_HOUR); day = readl(rtc->rtc_base + FTRTC010_RTC_DAYS); - offset = time - (day * 86400 + hour * 3600 + min * 60 + sec); + offset = time - ((timeu64_t)day * 86400 + (timeu64_t)hour * 3600 + + (timeu64_t)min * 60 + (timeu64_t)sec); writel(offset, rtc->rtc_base + FTRTC010_RTC_RECORD); writel(0x01, rtc->rtc_base + FTRTC010_RTC_CR); -- 2.53.0