From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795052836; b=BzpayzoVpwU4/EaROc0EMAXTh3e621uFagSUino1SdDieF11S3SboG0/KGZ2lJm0omJ4 JmqfijVOmPafNW9dAHYHp5cJSRfxAmwNfVFZDguFHSC5DtlRQpyfDF48Iwt1iSTlmkKGi i52cRPP6WqAYa9sa19IYJImAs6APSegyuTl6cNDm5M2+1LxMY6I2h9yUSIwXOjJ3Z+jhI KwPcWFbHnJu1X19v4aO6h3poQf/hBhs+46nNYjhRvzgh0eVoAy7PnBd4BWk2Y+Iv9j85T jSU/imFmvHNTT2TOnZfVXaDimoaeVFEcMDXbNTj4V7ZYfR1fi/Q+DYz5Wh9P0+b+m3g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795052836; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=xmBlS2kKzP6Pvfn5cd6uZBGjBUXlTwJbIyobrJdbXKc=; b=AhN7fwLThUnI+dTPgrZfBluB3HwPqedIoabafR6q8M3v6D3FYTeExuMdWdOtVmZXLJGA kN3sHotgXuDz1Lb8yTh0+s051LwBlhrb7nAGNKGig9+CGUoHZyYZzUyrVcjbfDOt0ugmP YkwcC/rwyp5P0n1l+9J6yQvPhqsYR82mwPZzWMKF1POvybxwxZYqigQt8QdwqRxulPDqT x6w5zroAF5ET3s+yivEYLPQQ75FTHRe8b6fvhQGZYjlgXA2Elocwtie+pMptj5zA4qpxI Sglw9Uu8fIHH5ha7DOgU/26HL/zVibi3wZTnXXnEp6B/goGq9ZdxRmGv2uIwTigOG4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="1SOh/WOx"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A779606A31C; Thu, 19 Nov 2026 01:47:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1SOh/WOx Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0F3F1F000C4; Thu, 19 Nov 2026 01:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795052836; bh=xmBlS2kKzP6Pvfn5cd6uZBGjBUXlTwJbIyobrJdbXKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1SOh/WOxFExAxivXgWizfeclcx5rJvEx9FoNEoL6jcgDev2NHV/Ao2AzicHaH92IA 5Uh+PToQ582QHzfKb2bzSsi8jvY8eQLgt0k61i58Uu7JYlmbY7yNTHkkUzqsn35Qmc uGgbqMA8TvBqHoZg8B43hzj8vw4qr+9Y3f4sMMsk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cen Zhang , Andrew Morton , Joseph Qi , Mark Fasheh , Joel Becker , Heming Zhao , Jia-Ju Bai , jjzuming@gmail.com, Sasha Levin Subject: [PATCH 5.15 0705/2214] ocfs2: snapshot the dentry name while tracing file release Date: Wed, 18 Nov 2026 15:39:41 +0100 Message-ID: <20261118150040.004280658@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cen Zhang [ Upstream commit 5898987d4a92b70ae73fd8355cc3a388b4dfa4e6 ] ocfs2_file_release() passes the live dentry name and length to a trace event while holding oi->ip_lock. This lock protects the open count and delays RCU reclamation of external names, but it does not serialize name changes during rename. The dentry can switch between inline and external names, and a separately loaded length can describe a different name. The ocfs2__file_ops event sizes and copies its __string separately. A concurrently rewritten inline name need not remain consistent between those operations. External names can also be selected at this call site; the existing spinlock critical section protects their allocation lifetime, while a snapshot additionally pairs a stable name with its length. Take a name snapshot before acquiring oi->ip_lock and release it after dropping the lock. Keep the trace call and open-count argument inside the original critical section. Cache the event-enabled check so the snapshot stays paired even if tracing is toggled meanwhile. Link: https://lore.kernel.org/pm-ocfs2-objects-candidate-0088-v7-6324344256f0c3b1c3d8-2@gmail.com Fixes: 468eedde23d6 ("ocfs2: Remove mlog(0) from fs/ocfs2/file.c") Signed-off-by: Cen Zhang Signed-off-by: Andrew Morton Reviewed-by: Joseph Qi Assisted-by: LLM Cc: Mark Fasheh Cc: Joel Becker Cc: Heming Zhao Cc: Jia-Ju Bai Cc: Cc: Signed-off-by: Sasha Levin --- fs/ocfs2/file.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index cb8a40a73adeb..f66f17df1ad8f 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -140,18 +140,26 @@ static int ocfs2_file_open(struct inode *inode, struct file *file) static int ocfs2_file_release(struct inode *inode, struct file *file) { struct ocfs2_inode_info *oi = OCFS2_I(inode); + struct dentry *dentry = file->f_path.dentry; + struct name_snapshot name; + bool trace_enabled = trace_ocfs2_file_release_enabled(); + + if (trace_enabled) + take_dentry_name_snapshot(&name, dentry); spin_lock(&oi->ip_lock); if (!--oi->ip_open_count) oi->ip_flags &= ~OCFS2_INODE_OPEN_DIRECT; - trace_ocfs2_file_release(inode, file, file->f_path.dentry, - oi->ip_blkno, - file->f_path.dentry->d_name.len, - file->f_path.dentry->d_name.name, - oi->ip_open_count); + if (trace_enabled) + trace_ocfs2_file_release(inode, file, dentry, + oi->ip_blkno, name.name.len, + name.name.name, oi->ip_open_count); spin_unlock(&oi->ip_lock); + if (trace_enabled) + release_dentry_name_snapshot(&name); + ocfs2_free_file_private(inode, file); return 0; -- 2.53.0