From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030703; b=nJ4b8/NPD0XLjVFsm8oVVbOckx5xo+H/1lx4Dj7OBTumz2Y6ME4q4yzCcPbz3FIXCI7h yAeAw+syaiWIz3kwFh/AikikYa9pZPeyABrtoyq2Hz4laFLeY77HLej9jhxzEDU1ZHS1Z I/q85/Soof5MGhJxXlTF77hStKTQUG8XAJz9TnmlpR4pt1hhCwKSrCDnnHTRtFjW3krht wJFNPhD10dK3bbrqRYKNK82E013Yf4Zkjdips7jUB7E4Itzkrb4vWi2R9P7pLDn2hGGoy siHTbERnjtzXhC7/LwtBf69B6Y3QsAJk97TG3yJbDgwnEJ14fCNrEgBxbCzVjWVu3Vw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030703; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=meg6UimyK32Hj8m1v2tY4FMaEAQqBGG0fll659SPpRg=; b=vTnF3Or7wJSiUbfCw2wA2kuwp9xPx+oGga5X0eyzHznqMOYzo+p43njeiX7HLoGecnKt UGtiCyBsPBJuzwIpXWuD+LUr8xRanEZt7CzlvyL2MqWN+6yVZnGaTHJ6OBK948s8rkfzh B4xDHkbeqDSZGRCsT8KUKUydVOsVn5ADGvCEYxCAE8uxxULcACRLTKMFEoenpUkgxCHcS 9EcGkTRoAHz5c16GqfP0sjniRnHIKl48HS3sOAEZALS4u++93Twom+fl/Q1sH8+vezOm/ quQCiN/p58c/uSxqhoG5QcKnl0kRCrCmx7TVyM3FQhqtyku3JQOFjh3M6hnRkQ8MF4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=OaJ3MY2K; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02BD2606A33A; Wed, 18 Nov 2026 19:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=OaJ3MY2K Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F2E61F000C4; Wed, 18 Nov 2026 19:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030702; bh=meg6UimyK32Hj8m1v2tY4FMaEAQqBGG0fll659SPpRg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OaJ3MY2K5aTxwNXCmIC40Z2FF52XkkHtUS7Z9BNrKEVmee6MSpTs/nOFVtLiwZvy1 3KlsjLvroR4uIuUZMVW6IsStpqpMRWphXxpf/elxED0l4DMPyuhOaEyOJ0GjFDVg7e zPjWJUtADoT0hDW1W1a6376d3y2EV5urCiVN1AEs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Kai=20M=C3=A4kisara?= , Laurence Oberman , =?UTF-8?q?Kai=20M=C3=A4kisara?= , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 6.12 0799/1756] scsi: st: Record the tape position after a successful MTLOAD Date: Wed, 18 Nov 2026 15:48:46 +0100 Message-ID: <20261118150041.503724540@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laurence Oberman [ Upstream commit 54ee0ee9bdeb7e9d3b70cc5c2bdf7e58c4423e8d ] Commit 0b120edb37dc ("scsi: st: Add MTIOCGET and MTLOAD to ioctls allowed after device reset") allows MTLOAD to clear the reset condition because the tape location is known after MTLOAD. But the driver does not record it: reset_state() sets the file and block numbers to -1, and do_load_unload() leaves them there. check_tape() sets them to 0 only for a new session, which requires a new-medium unit attention. Drives that do not report one when the medium was already loaded (seen with IBM LTO drives) keep reporting file/block -1 in MTIOCGET and no BOT, although the tape is at the beginning. After a successful load, reset the partition and the state of all partitions, as the new-session path in check_tape() does: partition 0, position at BOT, EOF state cleared and no pending write. Otherwise the driver may still record the previous partition, so that a later MTSETPART to that partition is not performed; a read after loading at EOD fails with EIO; and a partition left in the ST_WRITING state by a partition switch in read() or write() makes st_flush() write a filemark at the beginning of partition 0 when the device is closed. Fixes: 0b120edb37dc ("scsi: st: Add MTIOCGET and MTLOAD to ioctls allowed after device reset") Suggested-by: Kai Mäkisara Assisted-by: Claude sashiko Signed-off-by: Laurence Oberman Reviewed-by: Kai Mäkisara Link: https://patch.msgid.link/20260929192821.997675-3-loberman@redhat.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/st.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 39c9b1dfe6b67..0ce9454cdb3e5 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -2663,6 +2663,30 @@ static int do_load_unload(struct scsi_tape *STp, struct file *filp, int load_cod else { STp->rew_at_close = STp->autorew_dev; retval = check_tape(STp, filp); + /* + * LOAD leaves the medium at the beginning of partition + * 0. check_tape() records that only for a new session; + * without a new-medium unit attention (the medium was + * already loaded) the partition and the partition state + * would be left as before the load. Reset them as a + * new session does, for all partitions: a stale + * ST_WRITING state would make st_flush() write a + * filemark at the beginning of partition 0. + */ + if (retval == CHKRES_READY) { + int i; + + STp->partition = STp->new_partition = 0; + for (i = 0; i < ST_NBR_PARTITIONS; i++) { + STps = &(STp->ps[i]); + STps->rw = ST_IDLE; + STps->eof = ST_NOEOF; + STps->at_sm = 0; + STps->last_block_valid = 0; + STps->drv_block = 0; + STps->drv_file = 0; + } + } if (retval > 0) retval = 0; } -- 2.53.0