From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030722; b=pTKFSZNeU5VClQLcMdN7jnysQTFjXmWLqUakLMllP+hF5GjST1EjrHwYS3kgECdu8IPE HdTWSSjk02UGx7uDeh20SvOSOE2xKqxFo/giUPH9YLuTif+j4oqWd5i+XyqZ94iLqoshZ T4T4wANj106XV55WWI5WeYNAMnxmheZBp/+7zoS/g7uWhB5oUNYI5nyZTVhQKZQqz/3be i2pz2CotaIkRZoUNvnVgCCHHCE6Ae2zJR9aHr+pYB25QtLymDv5qPgVDNrRCeAmW70UFU YAc85Z+qTgl9Civf4KDAUZRxi5yyYv5/GURHTHQ8Nhmcnb1El4Zn4a8iuzXHYVSgboQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030722; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=GvKKNYTlBz1fjZFWsWphY9iDljiKEYiyL/md2y5ILw0=; b=lWW+QJCrQOSCldD2bMeWON+Y2kJHro3IkUlCuW+CcoKB8RwbMGopqsUyHqOxoH1QbXYr GfbzC72YVxkhUQ9anhritQXPtHVpNtc0ns2A3geVX7AJAMfHFAKodeG/ab0PyFfTsbhs1 QZgH/P9TqKTzonw0Hcar4/v11fY5Igiik1+loQWVOAf9FJvBzqkh5/xj0JCxAKK2H2Vnt faF8cztM2jd51vBwzR99MLGuzy2ewrqXFGUg+kMtwDzzS6q3u9tyQkF9uoJqw0iAS6qwD JWpfHBj1sN3guj8EPpCCA5fP9dk8oyZLRu4oEj4b49+jGWhs+czDT7djkQmDI39G4NA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="eNg5t/fj"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB60B606A333; Wed, 18 Nov 2026 19:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=eNg5t/fj Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B8B81F000C4; Wed, 18 Nov 2026 19:38:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030722; bh=GvKKNYTlBz1fjZFWsWphY9iDljiKEYiyL/md2y5ILw0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eNg5t/fjMdDo5h0PValZ0IcTFEg6jNRb3N7hKtwzjyH8p70v7XdlfFCuPhaIpvScV LJvB0kFu/R5ma75OFxrQHZY7jHzT+LENDqHfvM0OFDdCHwE3yy3Wx0pmetRyzAoBlq CxRatIuWupZV3lutD5pWWqLzwTt+36L3bLH+4ZAw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com, Li Youhong , Yu Kuai , Sasha Levin Subject: [PATCH 6.12 0806/1756] md/raid5: drain released_stripes before destroying the cache Date: Wed, 18 Nov 2026 15:48:53 +0100 Message-ID: <20261118150041.734514978@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li Youhong [ Upstream commit af560e357a81964544be40c549e241b032ef7565 ] grow_one_stripe() calls raid5_release_stripe() for each new stripe. When mddev->thread is already set, that queues the stripe on conf->released_stripes and wakes the thread. Only raid5d moves that list onto inactive_list. Takeover calls setup_conf() while mddev->thread still belongs to the previous personality, so those stripes stay on released_stripes. If setup_conf() then fails, shrink_stripes() only frees inactive_list and kmem_cache_destroy() warns that objects remain. Move stripes still queued on released_stripes onto inactive_list before shrink_stripes() frees them. Fixes: 773ca82fa1ee ("raid5: make release_stripe lockless") Reported-by: syzbot+6a132745caefcf42cb0d@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-raid/6ab6b743.7eec07f4.c25c.0006.GAE@google.com/T/#t Signed-off-by: Li Youhong Link: https://patch.msgid.link/20260929083916.50620-1-dayou5941@163.com Signed-off-by: Yu Kuai Signed-off-by: Sasha Levin --- drivers/md/raid5.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 99660cf51f533..84b3d60605189 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -2706,6 +2706,37 @@ static int drop_one_stripe(struct r5conf *conf) static void shrink_stripes(struct r5conf *conf) { + struct list_head temp[NR_STRIPE_HASH_LOCKS]; + int i; + + /* + * grow_one_stripe() parks new stripes on released_stripes when + * mddev->thread is already set. Takeover leaves the previous + * personality's thread there, so raid5d never moves them to + * inactive_list. Drain them before the cache is destroyed. + * slab_cache is assigned only after device_lock and the hash + * lists exist; earlier abort paths have nothing to drain. + */ + if (conf->slab_cache) { + for (i = 0; i < NR_STRIPE_HASH_LOCKS; i++) + INIT_LIST_HEAD(&temp[i]); + + spin_lock_irq(&conf->device_lock); + release_stripe_list(conf, temp); + spin_unlock_irq(&conf->device_lock); + + for (i = 0; i < NR_STRIPE_HASH_LOCKS; i++) { + if (list_empty(&temp[i])) + continue; + spin_lock_irq(conf->hash_locks + i); + if (list_empty(conf->inactive_list + i)) + atomic_dec(&conf->empty_inactive_list_nr); + list_splice_tail_init(&temp[i], + conf->inactive_list + i); + spin_unlock_irq(conf->hash_locks + i); + } + } + while (conf->max_nr_stripes && drop_one_stripe(conf)) ; -- 2.53.0