From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053040; b=EpsGDHtcX4tOmxXGp6Icbmv31CaHx5A2T+Vse0+sKEXgIZLAkwVEZRsk0LUIvpYaLOD8 cSPnEeLrYVgB5vzs7BT7Y9VQDQ9wqrx26ZZs2edUGXOrnu5Lqd6wGGrq5VSOShAQbQ+6f ZSA/HvrZsUkysiEzg4y7VeAU2yzqhA6T4BDlN9fne2HZ+mGfZL7ODydCWbMQgTpeLE+UR E5H3ROuSMB3xC3qCm073/rrFQJMUiJj6ZZipNHHBCOARMKbB1ASz2nuzqFvm+1+kzltQS sQQnNG/F65rj80l2/5gMYEr15HEXkRs99ib9fVThl+r0EcmmAidZHJFc5rrxugy8M2Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053040; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Mn5th3VerCWSvyKgf//ZvAzod6EMwU1fgB9LW4t+9n4=; b=CBhzhsUkPZP+2QJEquxFzaaVtP7B2dNRJdnxNgROBy+TgfAiF/nQ2KmVpXvOxl52xaxG S2a2Obz7YfXnE8Fsw5+UeT1jsKLFZkppEsUt6XZfnvIypb3DuTRSWOUB3K3qHngshgBsP 9mR+Z1/3KH4vuCJwCNC96OR9/Am8qPn0eano7M8JF2NXDg05YM75YvD0wDwOjX3MJtq/R incRV2A5tAFL10asMa2RQJL/BG1CWBJ0m0ToGSARUHK/tVOCjE+Wt+tCQuNNtnBToT61T /3aJ2AkZvs0cwBgJvhTaRaFeozM8fb6IHXYTW5Dk5Quv+nlBVDK5ENKJnjsGYTbnWEA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=P9cRV+gw; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD0FE606A320; Thu, 19 Nov 2026 01:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=P9cRV+gw Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F33F1F000C4; Thu, 19 Nov 2026 01:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053040; bh=Mn5th3VerCWSvyKgf//ZvAzod6EMwU1fgB9LW4t+9n4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P9cRV+gwC152y00+FvfAkMOcN5JZSFRynsC20WsXMLDQSGyyP2MsA0h92KOPrslu2 d5cg5etPqTKWoM1YNsAFJFA8ZKGR8Z9JVPOtPzxmbpSYzjGvdNr2HQv+gJz6X5PIke NZ8cBHKF8xa+NN9p8Ty4TTR7fUb4+bCoPsz8zPAI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ratnaker Gautam , Paulo Alcantara , Sasha Levin Subject: [PATCH 5.15 0776/2214] smb: client: validate SMB1 EA list bounds before parsing Date: Wed, 18 Nov 2026 15:40:52 +0100 Message-ID: <20261118150042.692410042@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ratnaker Gautam [ Upstream commit ddc7a7e1eeb116ccaf010a6f1fb6ab927f3f888d ] CIFSSMBQAllEAs() checks the server-provided EA list length by adding it to the response pointer. On 32-bit systems, a positive length can wrap the pointer and pass the comparison. The parser then walks outside the received response while reading the next FEA header. A response with a list length of 0x40000000 reproduces this as a native i386 page fault and kernel panic from listxattr() against an SMB1 server. Check that the EA list starts within the SMB byte area before reading its header. Keep its length unsigned and compare it with the bytes left in the response without pointer addition. SMB1 is not negotiated by default and requires an explicit vers=1.0 mount. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Ratnaker Gautam Signed-off-by: Paulo Alcantara [ sashal: Replaced unavailable smb_EIO2() calls with direct -EIO assignments. ] Signed-off-by: Sasha Levin --- fs/cifs/cifssmb.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 685fdf7ecd070..2a085d4e99c5d 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -6039,9 +6039,11 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon, int rc = 0; int bytes_returned; int list_len; + u32 ea_list_len; struct fealist *ea_response_data; struct fea *temp_fea; char *temp_ptr; + char *byte_area; char *end_of_smb; __u16 params, byte_count, data_offset; unsigned int ea_name_len = ea_name ? strlen(ea_name) : 0; @@ -6118,9 +6120,18 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon, ea_response_data = (struct fealist *) (((char *) &pSMBr->hdr.Protocol) + data_offset); - list_len = le32_to_cpu(ea_response_data->list_len); - cifs_dbg(FYI, "ea length %d\n", list_len); - if (list_len <= 8) { + byte_area = pByteArea(&pSMBr->hdr); + end_of_smb = byte_area + get_bcc(&pSMBr->hdr); + if ((char *)ea_response_data < byte_area || + (char *)ea_response_data > + end_of_smb - sizeof(ea_response_data->list_len)) { + rc = -EIO; + goto QAllEAsOut; + } + + ea_list_len = le32_to_cpu(ea_response_data->list_len); + cifs_dbg(FYI, "%s: ea length: %u\n", __func__, ea_list_len); + if (ea_list_len <= 8) { cifs_dbg(FYI, "empty EA list returned from server\n"); /* didn't find the named attribute */ if (ea_name) @@ -6129,12 +6140,12 @@ CIFSSMBQAllEAs(const unsigned int xid, struct cifs_tcon *tcon, } /* make sure list_len doesn't go past end of SMB */ - end_of_smb = (char *)pByteArea(&pSMBr->hdr) + get_bcc(&pSMBr->hdr); - if ((char *)ea_response_data + list_len > end_of_smb) { + if (ea_list_len > end_of_smb - (char *)ea_response_data) { cifs_dbg(FYI, "EA list appears to go beyond SMB\n"); rc = -EIO; goto QAllEAsOut; } + list_len = ea_list_len; /* account for ea list len */ list_len -= 4; -- 2.53.0