From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053210; b=pdltED50oS4kWgc65SXVPoT5YzuYfLWJAqW1GUQJ6O3y6tFi2ShPQIT0Y1I4T6Ex1bca jYO4V3V8w4y4YyhvQ9hQYTDhXgzWM9GDYBLReJMljZqMDJUuCMZ2vehw/MKfognho2YCu hTf/muTasFwcEtDrMP5bvVOyhtEDz/uIeLHpl1rW9OXF0AFq37MK3pNJ1c9b8uy0dCdh7 7rQEjC+rMhzwPJCWbgEaIvkRa2aWdNs6kAOLFnCWWfKsDZkuTldMpijN3btIrc8424zvL hiXvFfPdh5scraMfxd1qtzDXuges5usTo4geLhhcw/xYVa/EFWgqPBz4e6w0GGta49Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053210; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=+PY9cvIv720OjbXenIe+OpErv5TjgfhAyL8dMnQ2k7I=; b=quKE1Oo3hWJxmCQrGjYWRRPPItiWLvQba6GvZxNUYUxjmqWYJNuUPYsiD62fnYLTJz54 mDw0WU7h08h5IstYYXx+clpofb8TVeZquaVjjKLcxqzjzEDe4oOLkgg2bZckLDCmZPSV9 83kINUmS4ivDgXaE9C6dbf90XJNjiHZg5jl/qC1uXLMNDoewvx+1Hsgp5hfpaHC4ChvfB QWpOpmWvzNExrXfHFDtN2hiQujQ1YDNvA6hPO7beiPVKzHOCR9c+JinKcoOeTVqLInQpp iFKwpFxGAWNYe8C70vGNDek18TWgafqAHYQ6P5gYaa7aq6SK7C5vzrw5gb9A8S+yzfg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SoSIZgg9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B4B606A325; Thu, 19 Nov 2026 01:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=SoSIZgg9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AAF11F000C4; Thu, 19 Nov 2026 01:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053209; bh=+PY9cvIv720OjbXenIe+OpErv5TjgfhAyL8dMnQ2k7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SoSIZgg9p4f/M5nMKYHlAgn5ubsq/Zj06bc3wchJpWjsXb8KBrMt2SagpZOkrbW52 PZM42tR56werLPxdYUbR/EzBwegL4TI8C9vw1WmImqjmMkAb7n67B9qmv43rhIrz+U BoEO/GSXas7Wi40hPJvOYKBrEciwLKKSs9ggWOPk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Tan , Zhengchuan Liang , Xin Liu , Zhao Zhang , Ren Wei , Dominique Martinet , Sasha Levin Subject: [PATCH 5.15 0835/2214] 9p: fix caches_show() out-of-bounds write Date: Wed, 18 Nov 2026 15:41:51 +0100 Message-ID: <20261118150045.489194206@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhao Zhang [ Upstream commit 2acd800de8827b7cdce8cb5c2c63b8e8608ec8e3 ] The sysfs show handler for /sys/fs/9p/caches appends cache tags with snprintf(buf + count, limit, ...) and then advances count and limit by the return value. This is incorrect for truncation because snprintf() returns the full would-have-been length, not the number of bytes stored. Once the accumulated output exceeds PAGE_SIZE, count can advance past the sysfs buffer and limit can become negative. A later iteration then passes an out-of-bounds destination pointer and an oversized size_t into snprintf(), leading to an out-of-bounds write. Use sysfs_emit_at() for the append instead. It follows the sysfs buffer contract and returns the number of bytes actually stored, so the offset remains bounded even when the output is truncated. Fixes: 86db0c32f16c ("9p: fix /sys/fs/9p/caches overwriting itself") Cc: stable@vger.kernel.org Reported-by: Yuan Tan Reported-by: Zhengchuan Liang Reported-by: Xin Liu Assisted-by: Codex:GPT-5.4 Signed-off-by: Zhao Zhang Co-authored-by: Ren Wei Signed-off-by: Ren Wei Message-ID: Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- fs/9p/v9fs.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c index 3a44a77e276b8..d95a4023de65e 100644 --- a/fs/9p/v9fs.c +++ b/fs/9p/v9fs.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -552,21 +553,14 @@ static ssize_t caches_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { - ssize_t n = 0, count = 0, limit = PAGE_SIZE; + ssize_t count = 0; struct v9fs_session_info *v9ses; spin_lock(&v9fs_sessionlist_lock); list_for_each_entry(v9ses, &v9fs_sessionlist, slist) { - if (v9ses->cachetag) { - n = snprintf(buf + count, limit, "%s\n", v9ses->cachetag); - if (n < 0) { - count = n; - break; - } - - count += n; - limit -= n; - } + if (v9ses->cachetag) + count += sysfs_emit_at(buf, count, "%s\n", + v9ses->cachetag); } spin_unlock(&v9fs_sessionlist_lock); -- 2.53.0