From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795023729; b=izwOS4iIA2RA92KQfQKBinuuCJJW75F7NUDfKvCL5qMA9cNb66b9BUjdwxvXMul8SZmm d6Fy5Eo1SWVDbeAXIqP09A0NYffbUJ4oDWnsFmJMN1XEeHE2LOReZnSRXQ2POlD/LVLCj Vm3DdqUp63hthXTHjSL9GcoaLiZaPxiRrR0xG3DLoZ4b/Isv81mYa22w2jCxj29CN5iLd GloGbcJnprSOA5HhI0bHPjzE6od+M6fFRpDGgD22yUXfMIBafu5jtkXvOSE8d5BvMtBqH wR/Sgfhd4x4oYqw8biRdRL5KPXEi+irQxY17P9EEBYQPPVo9kjAQ/BffjFbo/ScTOIQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795023729; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=aOcF9fJwclEBqK+hnL7p8u/woir6q5r+/mU6zed4AHo=; b=TK2H62tjGqtOVPtX/E4etkFON1C8RISxMRXMK4FtUhvC9Z064cPyJwZcZi8gTzaEXJdR HJelEeKfBDcc6nqPlDWibbI+SWgHTf23IolLTF4VQBBdO7+HJKZFCo+B6OuKr2AlNxCx5 OATtAl75SwXNcFwl0rKVe8wH45+wqMsL/3/Lst7m/nrg955ZKtIx1k4FF6EILKOTKncCf ne+zzZXolqqUAA/TOeyKQDQlonGrYFEFkKI8829jWYgv7UTTE3QtWbLXRlDhFmrxoClsD Vbln/E2DrptZ1P8HPCLZaeBP8U7ZTw4nZAH+uSMU0zEPe4juWyTGha1tZ4O6+TjpC8A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CNrzRAhX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ADA3606A32C; Wed, 18 Nov 2026 17:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CNrzRAhX Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC9BF1F000C4; Wed, 18 Nov 2026 17:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795023729; bh=aOcF9fJwclEBqK+hnL7p8u/woir6q5r+/mU6zed4AHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CNrzRAhXIMuoTqSENM9XSMe3gDMuLsVm3ZQtDlqiO/GRDZt43U/1sJt7bxQhrVAPq 91CBDyjQeOSoQvG+XcMHEdEcrY7ymZfwvbCffXdYPL6QDmNV8mEbBQ75Xihp3CzsRF OddqVYtu2Px2HrFULLeHlvho1PnpsfmQPl1dIUCI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Weiming Shi , Konstantin Komarov , Sasha Levin Subject: [PATCH 6.18 0432/2151] fs/ntfs3: take run_lock when freeing offs_folio in ni_decompress_file Date: Wed, 18 Nov 2026 15:36:07 +0100 Message-ID: <20261118150137.781913891@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit ad39d8d90fa0fd99b2714d4c84c6f4e1c399f1f4 ] attr_wof_frame_info() allocates, caches and dereferences ni->file.offs_folio under down_write(&ni->file.run_lock). ni_decompress_file() frees the same folio with folio_put() without taking run_lock. When a WOF externally-compressed file is opened for write, ni_decompress_file() can drop the last reference while a concurrent O_RDONLY reader is dereferencing the folio in attr_wof_frame_info(), leading to a use-after-free: BUG: KASAN: use-after-free in attr_wof_frame_info (fs/ntfs3/attrib.c:1619) Read of size 4 at addr ffff8880120c9000 by task exploit Call Trace: attr_wof_frame_info (fs/ntfs3/attrib.c:1619) ni_read_frame (fs/ntfs3/frecord.c:2421) ni_read_folio_cmpr (fs/ntfs3/frecord.c:1916) ntfs_read_folio (fs/ntfs3/inode.c:648) read_pages (mm/readahead.c:181) page_cache_ra_unbounded (mm/readahead.c:292) force_page_cache_ra (mm/readahead.c:364) page_cache_sync_ra (mm/readahead.c:573) filemap_get_pages (mm/filemap.c:2688) filemap_read (mm/filemap.c:2806) generic_file_read_iter (mm/filemap.c:2994) ntfs_file_read_iter (fs/ntfs3/file.c:842) vfs_read (fs/read_write.c:574) __x64_sys_pread64 (fs/read_write.c:773) Take run_lock around the folio_put(), as is done for every other access to ni->file.offs_folio. Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation") Reported-by: Xiang Mei Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Weiming Shi Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/frecord.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index 1cc905a265553..2d0ab6c77d13c 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -2338,10 +2338,13 @@ int ni_decompress_file(struct ntfs_inode *ni) /* Clear cached flag. */ ni->ni_flags &= ~NI_FLAG_COMPRESSED_MASK; + /* offs_folio is accessed under run_lock in attr_wof_frame_info(). */ + down_write(&ni->file.run_lock); if (ni->file.offs_folio) { folio_put(ni->file.offs_folio); ni->file.offs_folio = NULL; } + up_write(&ni->file.run_lock); mapping->a_ops = &ntfs_aops; out: -- 2.53.0