From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795024395; b=EMifdJFMk7EhO+7y+4QSkYTMNYrfyMPGtEjUKoQS0xTbEjVAledp7Vsx1lVKLh2kj948 OFfhnwWvgMJvCiQDgeHSTBNY6A6tiUNmsqAcUidpTC17Z0PcJM9C5eHenQyTAZexwGjuu 2cesaT0kPp6XZAFyuOASle3D082sDVurmDt0i/F56ZcRQKf6E5xV9BxYE2pe/PyUp8syw KelqPPzJOiRbrshz6ijXynTpas+naVdw/V0Fd/e+alJl2MCNzcWoEkAAHqEl/scuxDei2 8qItxLCfZ5yckfeTVYWPcJ0+tLC7eU79qBpcbOPeQhQbn6q3kkN4jI5uJCzOb6cx7ig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795024395; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=/iFYlVR4Ynaa1o/k1MVtQg/cHS+0DJKMZRBSZ8qjUGs=; b=Y9qamFu+kG+W98zKjykGUlOLzOb5exs6vvDS6/Qm0B6zJlaOZzJnTmpyHRCuBKgEavYb gji+AC7gQ6Y1roFJz+Ax2n2YPQm0T06/IXmaHh1KjdrOjpq4HPn+QFCRBic6n3WYZyXIF ykyxN0HET8UZsPQHR+59+Hx0DkSOooYI8Zv54A9t3w0ifU/1ZPnMesh9n98RpgTHf5Pxn 6b568Byiu/BifPIbdVp0WjobvohLjzzxdCiNnaoborytfSVIMcTEHd5RDJMkJB3eoo0WU FSEpoe58tFTcpO9nrAW0ttWjrwXzJkOd14mH0dL8s+jUVfB7gDRcrxLfLiywVX+z2Og== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1LwnLeEB; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76DC6606A325; Wed, 18 Nov 2026 17:53:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1LwnLeEB Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BB001F000C4; Wed, 18 Nov 2026 17:53:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795024395; bh=/iFYlVR4Ynaa1o/k1MVtQg/cHS+0DJKMZRBSZ8qjUGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1LwnLeEBRzMQ4tiaDrqct+Xbiwhr4RcrfiX4aOcdcqwFS11rhyeiF02JL0vr2gk/h hGMvYdAZMpc+Zv+J1qiTNys90ZPx007LvoDSlIct69HdVwd7lJKoSy8i5EU9uqWL6+ PlL2SVkRqyTAP2xpgdxXTykTbVxuWoaX3dhlrNMU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, bui duc phuc , Cezary Rojewski , AngeloGioacchino Del Regno , Mark Brown , Sasha Levin Subject: [PATCH 6.18 0710/2151] ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate regmap update errors Date: Wed, 18 Nov 2026 15:40:45 +0100 Message-ID: <20261118150147.749516420@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: bui duc phuc [ Upstream commit 60a8112a088aee38d728457a14fa8bfb50f4c87e ] The return values from regmap_update_bits() are currently ignored by the clock and AFE control functions. Propagate the errors to allow callers to handle regmap update failures. Fixes: f6b026479b13 ("ASoC: mediatek: mt8188: support audio clock control") Signed-off-by: bui duc phuc Reviewed-by: Cezary Rojewski Reviewed-by: AngeloGioacchino Del Regno Link: https://patch.msgid.link/20260907120310.135693-4-phucduc.bui@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/mediatek/mt8188/mt8188-afe-clk.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-clk.c b/sound/soc/mediatek/mt8188/mt8188-afe-clk.c index b41069b752a94..516b9b4ee0339 100644 --- a/sound/soc/mediatek/mt8188/mt8188-afe-clk.c +++ b/sound/soc/mediatek/mt8188/mt8188-afe-clk.c @@ -574,9 +574,7 @@ static int mt8188_afe_enable_top_cg(struct mtk_base_afe *afe, unsigned int cg_ty unsigned int mask = get_top_cg_mask(cg_type); unsigned int val = get_top_cg_on_val(cg_type); - regmap_update_bits(afe->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(afe->regmap, reg, mask, val); } static int mt8188_afe_disable_top_cg(struct mtk_base_afe *afe, unsigned int cg_type) @@ -585,9 +583,7 @@ static int mt8188_afe_disable_top_cg(struct mtk_base_afe *afe, unsigned int cg_t unsigned int mask = get_top_cg_mask(cg_type); unsigned int val = get_top_cg_off_val(cg_type); - regmap_update_bits(afe->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(afe->regmap, reg, mask, val); } int mt8188_afe_enable_reg_rw_clk(struct mtk_base_afe *afe) @@ -627,14 +623,12 @@ int mt8188_afe_disable_reg_rw_clk(struct mtk_base_afe *afe) static int mt8188_afe_enable_afe_on(struct mtk_base_afe *afe) { - regmap_update_bits(afe->regmap, AFE_DAC_CON0, 0x1, 0x1); - return 0; + return regmap_update_bits(afe->regmap, AFE_DAC_CON0, 0x1, 0x1); } static int mt8188_afe_disable_afe_on(struct mtk_base_afe *afe) { - regmap_update_bits(afe->regmap, AFE_DAC_CON0, 0x1, 0x0); - return 0; + return regmap_update_bits(afe->regmap, AFE_DAC_CON0, 0x1, 0x0); } static int mt8188_afe_enable_a1sys(struct mtk_base_afe *afe) -- 2.53.0