From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795024988; b=4/3yrRMP6er8OXPZzm6Ng0EBZYJ/VOyhS6wYGU4U4Db0Uk6I6b42M19CtSPVJOdylplu Ge69ZMqbuf3NeL4U3dagwAsory4pdts0bcsXmESFihd3c3DB8zN2COfn2DdwyMvPEckBJ 03LGGqL+zB5ow8+upR9X3URYA2+klNzlkNi6G2KvOerrw1U0tBth5MQ4lhq5U2U8vfMkx nn+o7s+TWTWmOjwiel+JRRP2YiIDSvOYk4ULKAJm5UIRViDjIw84/Ur8Cx0UBB5Rc6ebU NtC7UI2aeQsE9mOkqppEUZBr2ENSbnaGzNemNDSwBdBUuwTaf7mM1gGi9/GWdhXLiBA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795024988; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=qTSRs2XVKAPs8UwoF3tPU4bEr5mDaBGOHP4xgOvyWB4=; b=hVZAJ/pY4fKFgP7ImSagUc0cE4Rcx2Ku5wBzbpiZA/3LnnSsqtLG+auTEZuM1tHVeZGs EIIrBUcjtdDe13vtOBZxkWgbkHk3Mmowg/+bfUnnOO+TPcx4hSkQxiv7WwYy06OY0Vv7j PvD3801idTQT8zxNBX+WyzZS6iPxRYk5ZzuNe1vLuC4J21d/eJoe85b9bgpiCgVDufYio RDaSt97zHnBDPoLctOYjZBn8UJyeTx5e/o050GQ8ZRLd0FJr0dTWWTr9Nn4qsnBM1LePX QHazI9m4rw73xkxfnv2HITJs4sL+eJXrTw235TCGz1mD2TiU/ZechAGPCn+Y3TyQjpQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=atTBbnWd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 470E7606A31C; Wed, 18 Nov 2026 18:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=atTBbnWd Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1F071F000C4; Wed, 18 Nov 2026 18:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795024988; bh=qTSRs2XVKAPs8UwoF3tPU4bEr5mDaBGOHP4xgOvyWB4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=atTBbnWdEFV/qp5fJzRn6ph4iSFCXtUhp86/0VRjRDh8qr42n0wa5KuZh+Ly4XzOW JbVtYU182YT/DOAQqTzIdjuzxr8orY7KDCeIM5pbG8hpYXIIiN6dCWC8eJimoOclSb SCXODlctWbNoLi8Qy2SGAQZdvt1uCUT5vxSbGLrQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liu Dalin , Linus Walleij , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.18 0921/2151] rtc: ftrtc010: use devm clock APIs to fix use-after-disable in remove Date: Wed, 18 Nov 2026 15:44:16 +0100 Message-ID: <20261118150156.013947867@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Dalin [ Upstream commit d41ee317c9907d714014d0d5e4726fbd6acf338e ] The driver mixes devm_rtc_register_device() with manual clock disabling in ftrtc010_rtc_remove(). Because the RTC device was registered via devm, it remains registered until devres cleanup runs after .remove() returns. An unprivileged process holding an open /dev/rtc0 file descriptor could issue ioctl(RTC_RD_TIME) during this window, triggering MMIO reads on clock-gated hardware and causing a synchronous external abort. Replace devm_clk_get() + clk_prepare_enable() with devm_clk_get_enabled() to tie clock lifecycle to devres. Remove the manual .remove() callback and the corresponding error handling labels in ftrtc010_rtc_probe(). Fixes: 1d61d2592c1f ("rtc: ftrtc010: Rename to Faraday FTRTC010") Assisted-by: Sashiko AI [static analysis] Signed-off-by: Liu Dalin Reviewed-by: Linus Walleij Tested-by: Liu Dalin Link: https://patch.msgid.link/0238203A74C9B9F6+20260827080320.3351155-3-liudalin@kylinsec.com.cn Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-ftrtc010.c | 67 +++++++++----------------------------- 1 file changed, 16 insertions(+), 51 deletions(-) diff --git a/drivers/rtc/rtc-ftrtc010.c b/drivers/rtc/rtc-ftrtc010.c index f398d6dc85ae4..2f610a0fc6e9b 100644 --- a/drivers/rtc/rtc-ftrtc010.c +++ b/drivers/rtc/rtc-ftrtc010.c @@ -120,51 +120,33 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) return -ENOMEM; platform_set_drvdata(pdev, rtc); - rtc->pclk = devm_clk_get(dev, "PCLK"); - if (IS_ERR(rtc->pclk)) { + rtc->pclk = devm_clk_get_enabled(dev, "PCLK"); + if (IS_ERR_OR_NULL(rtc->pclk)) { dev_err(dev, "could not get PCLK\n"); - } else { - ret = clk_prepare_enable(rtc->pclk); - if (ret) { - dev_err(dev, "failed to enable PCLK\n"); - return ret; - } + return PTR_ERR_OR_ZERO(rtc->pclk); } - rtc->extclk = devm_clk_get(dev, "EXTCLK"); - if (IS_ERR(rtc->extclk)) { + rtc->extclk = devm_clk_get_enabled(dev, "EXTCLK"); + if (IS_ERR_OR_NULL(rtc->extclk)) { dev_err(dev, "could not get EXTCLK\n"); - } else { - ret = clk_prepare_enable(rtc->extclk); - if (ret) { - dev_err(dev, "failed to enable EXTCLK\n"); - goto err_disable_pclk; - } + return PTR_ERR_OR_ZERO(rtc->extclk); } rtc->rtc_irq = platform_get_irq(pdev, 0); - if (rtc->rtc_irq < 0) { - ret = rtc->rtc_irq; - goto err_disable_extclk; - } + if (rtc->rtc_irq < 0) + return rtc->rtc_irq; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - ret = -ENODEV; - goto err_disable_extclk; - } + if (!res) + return -ENODEV; rtc->rtc_base = devm_ioremap(dev, res->start, resource_size(res)); - if (!rtc->rtc_base) { - ret = -ENOMEM; - goto err_disable_extclk; - } + if (!rtc->rtc_base) + return -ENOMEM; rtc_dev = devm_rtc_allocate_device(dev); - if (IS_ERR(rtc_dev)) { - ret = PTR_ERR(rtc_dev); - goto err_disable_extclk; - } + if (IS_ERR(rtc_dev)) + return PTR_ERR(rtc_dev); rtc_dev->ops = &ftrtc010_rtc_ops; @@ -179,29 +161,13 @@ static int ftrtc010_rtc_probe(struct platform_device *pdev) ret = devm_request_irq(dev, rtc->rtc_irq, ftrtc010_rtc_interrupt, IRQF_SHARED, pdev->name, dev); if (unlikely(ret)) - goto err_disable_extclk; + return ret; ret = devm_rtc_register_device(rtc_dev); if (ret) - goto err_disable_extclk; + return ret; return 0; - -err_disable_extclk: - clk_disable_unprepare(rtc->extclk); -err_disable_pclk: - clk_disable_unprepare(rtc->pclk); - return ret; -} - -static void ftrtc010_rtc_remove(struct platform_device *pdev) -{ - struct ftrtc010_rtc *rtc = platform_get_drvdata(pdev); - - if (!IS_ERR(rtc->extclk)) - clk_disable_unprepare(rtc->extclk); - if (!IS_ERR(rtc->pclk)) - clk_disable_unprepare(rtc->pclk); } static const struct of_device_id ftrtc010_rtc_dt_match[] = { @@ -217,7 +183,6 @@ static struct platform_driver ftrtc010_rtc_driver = { .of_match_table = ftrtc010_rtc_dt_match, }, .probe = ftrtc010_rtc_probe, - .remove = ftrtc010_rtc_remove, }; module_platform_driver_probe(ftrtc010_rtc_driver, ftrtc010_rtc_probe); -- 2.53.0