From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795042936; b=wEL2wBdIfEPuOEZIHiTioYdjjUa54jGpkio+7xBryTxsxaVy0aHppOSbr3qgMLdJe8cs cC5QVAePxhZpQcM74F2gtkWrQdT1DQsT+w5asnPjDkjZVV2BRnHOXnT5igqE8r8B2WCOf X1cKeknnTiZQBpZxBF1cCxUwrdJG99H0FkbXbFuOmsdB4TlbhIOtFGRNWy8hF8McaQ01L 2LZ8Og2PBTZgGHvmomrY/S+9hYoW6XeAJafQIeQvZsv+1oLEd4EgzaKLRoAFZNpJgmnQV hi//CQFkmbU6If9YP7GRMLZL3LFy6ZfwmIZMTyPzf6EYDqt6/3JpHRT4lmKnjE9FWBw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795042936; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=etePr2VCXZ+zAzncTtMsFW6B/JufIhMoTIc0UJ7rKeE=; b=oxiQZUXS0E3kxO4D7FMrC/gHUE1a5DgLQyjN+XQugUKfOb72WmxAbo8DBBy/ipm0QO1T 3Qw5rDBacYS3gQoFA3nHeGAYn37oAfi1DtQzItO9rJld664PRXY0Flnl4TzhWPT72H9Dm uCCN3iNPZDRwfb0QLNaKXoki98wDTYkkJiDgjVCQ78uglsVA0rjzu/48sAPG3wBiGLFW7 ZenvdSSoFSEaC2+REKSmg9EMhCgb6ceZ2QCUN5fXg972pe05UF7q57hCkC17Unjh9Hg8k AYtXXBsXaMAy6dHkuskOMY7ivUMcODnRYyITZ+QCy/aWDYAktvxz8T6dlvnauR8wz4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hZIvqLaa; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576E5606A320; Wed, 18 Nov 2026 23:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hZIvqLaa Received: by smtp.kernel.org (Postfix) with ESMTPSA id 346FE1F000C4; Wed, 18 Nov 2026 23:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795042935; bh=etePr2VCXZ+zAzncTtMsFW6B/JufIhMoTIc0UJ7rKeE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hZIvqLaaYHSrddr1075mNi7COIPRQzzyKfpf0fXosMjnQYOM+zN0ve9r7lskJfNaz +aUmRy+sQOAdwNvQS5OegqQXmCfCwwPdqKATJZ2uhCMXofsAlKLTgRBMYM7Xe2i5QX FS8q6JeCKmbTPXKQz7uQgUYo+qx1U3EpMTbicMkY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baolin Wang , Barry Song , Kairui Song , Johannes Weiner , Shakeel Butt , Axel Rasmussen , David Hildenbrand , "Lorenzo Stoakes (Oracle)" , Michal Hocko , Qi Zheng , Wei Xu , Yuanchu Xie , Andrew Morton , Leno Hou Subject: [PATCH 6.1 0015/2857] mm: vmscan: fix dirty folios throttling on cgroup v1 for MGLRU Date: Wed, 18 Nov 2026 15:17:29 +0100 Message-ID: <20261118150201.916675026@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Baolin Wang commit 13b6b620910436c29dea398382e83c9499fd13e4 upstream. The balance_dirty_pages() won't do the dirty folios throttling on cgroupv1. See commit 9badce000e2c ("cgroup, writeback: don't enable cgroup writeback on traditional hierarchies"). Moreover, after commit 6b0dfabb3555 ("fs: Remove aops->writepage"), we no longer attempt to write back filesystem folios through reclaim. On large memory systems, the flusher may not be able to write back quickly enough. Consequently, MGLRU will encounter many folios that are already under writeback. Since we cannot reclaim these dirty folios, the system may run out of memory and trigger the OOM killer. Hence, for cgroup v1, let's throttle reclaim after waking up the flusher, which is similar to commit 81a70c21d917 ("mm/cgroup/reclaim: fix dirty pages throttling on cgroup v1"), to avoid unnecessary OOM. The following test program can easily reproduce the OOM issue. With this patch applied, the test passes successfully. $mkdir /sys/fs/cgroup/memory/test $echo 256M > /sys/fs/cgroup/memory/test/memory.limit_in_bytes $echo $$ > /sys/fs/cgroup/memory/test/cgroup.procs $dd if=/dev/zero of=/mnt/data.bin bs=1M count=800 Link: https://lore.kernel.org/3445af0f09e8ca945492e052e82594f8c4f2e2f6.1774606060.git.baolin.wang@linux.alibaba.com Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation") Signed-off-by: Baolin Wang Reviewed-by: Barry Song Reviewed-by: Kairui Song Acked-by: Johannes Weiner Acked-by: Shakeel Butt Cc: Axel Rasmussen Cc: David Hildenbrand Cc: Lorenzo Stoakes (Oracle) Cc: Michal Hocko Cc: Qi Zheng Cc: Wei Xu Cc: Yuanchu Xie Signed-off-by: Andrew Morton Signed-off-by: Leno Hou Signed-off-by: Greg Kroah-Hartman --- mm/vmscan.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -5259,8 +5259,22 @@ done: * If too many file cache in the coldest generation can't be evicted * due to being dirty, wake up the flusher. */ - if (sc->nr.unqueued_dirty && sc->nr.unqueued_dirty == sc->nr.file_taken) + if (sc->nr.unqueued_dirty && sc->nr.unqueued_dirty == sc->nr.file_taken) { + struct pglist_data *pgdat = lruvec_pgdat(lruvec); + wakeup_flusher_threads(WB_REASON_VMSCAN); + /* + * For cgroupv1 dirty throttling is achieved by waking up + * the kernel flusher here and later waiting on folios + * which are in writeback to finish (see shrink_folio_list()). + * + * Flusher may not be able to issue writeback quickly + * enough for cgroupv1 writeback throttling to work + * on a large system. + */ + if (!writeback_throttling_sane(sc)) + reclaim_throttle(pgdat, VMSCAN_THROTTLE_WRITEBACK); + } clear_mm_walk();