From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795043189; b=nvWTEeuGtLCex8z9VYdqdF2vGPqVYI/Tyi6L6treMOXmxSTU3tZuMWyM/Z2Vblte0ErB GIn2anad6H5OlAOZM7MJSOqw/BP/6caHs4Bkmw9e6VQ+UlaWsjG1tj8ro5/fnKuCSp9zY witjid5U48UJoG2UwYSPpuMz7VJm3W3iqRwfQ7KJIWttVKarx2PJVtYMIcLMByuTeDq7j Ycb2LV8O0LjwmGN0zDqjA6Fo9dbwq5qcBoS0BRtri1Hw9TLlektfatPhDSEmHjJvp2d3a 7bODDlBLOoARr7ukobb7LXYv1GWgVmRIIiaDMKfyWmpR4YKR93UdOOojTMEx3LRY0ig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795043189; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=9t2Ceyk/0nUTNHzMQbzcJMnhGmH0xZ5OVWh9RZgfuhU=; b=OZD6ZzEE28uuLLaC1XRm5YW2GGCoM3RGVoz9SvCyH2HCPTZOsq8XmYiQR6AsY3xQj6+E rZXtIXVmLAx8Zh5yKRQZBzc0CaYbWZG63mtmPmKcKy10M60wXWug1dyYuVl2W1wFxBewk 7cznYdSsa4VAY6ZukbXf3TG6PxWgmMvrS/P7Fgesn0Pp7czHHRqYRt4XHqnnc9YXD8ODs ZX3L2Kq1KOuQDpF8++7SWIgh57jWwP+WxYKVHbGLgJbHwbuz+nYRFKzhiL6eNhTt05bT+ +pWroTRLjMtwMee2qdJWzZ6/vxxMef8buPB59F6a32auxSy4GZTaTYr9OEobDxZAMmA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=qhfCTs3+; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51CCA606A334; Wed, 18 Nov 2026 23:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=qhfCTs3+ Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7CDB1F000C4; Wed, 18 Nov 2026 23:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795043189; bh=9t2Ceyk/0nUTNHzMQbzcJMnhGmH0xZ5OVWh9RZgfuhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qhfCTs3+bYHWx+2DymSj9zzNkfSybu1HQsEq37G9LzrOHqF2SegHn71GPF8tmNOOd hP7fyHsZR4UZIwtrffQNljr3bP8+YOJFYvOK7ugDhemRVNwWslGi/VCxvwyePKe79g oli7TY2a02OowMj4t4OjS4Pcz9bNs3bpRPEnzpds= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Abbott , Sasha Levin Subject: [PATCH 6.1 0105/2857] comedi: ni_at_a2150: Fix sanity check in interrupt handler Date: Wed, 18 Nov 2026 15:18:59 +0100 Message-ID: <20261118150205.045069185@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Abbott [ Upstream commit e7356cdc7077a4f30fc5232a18e9fc6a4d404581 ] The driver requests an interrupt handler for the device before it is fully set up. For safety, the interrupt handler checks the dev->attached flag to ensure the device is fully set up, but it currently does that after dereferencing various pointers which may be NULL if dev->attached is false. Move the check to avoid the possible null pointer dereferences. Signed-off-by: Ian Abbott Link: https://patch.msgid.link/20260618102949.26607-5-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/comedi/drivers/ni_at_a2150.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/comedi/drivers/ni_at_a2150.c b/drivers/comedi/drivers/ni_at_a2150.c index df8d219e67234..cc106437de3c3 100644 --- a/drivers/comedi/drivers/ni_at_a2150.c +++ b/drivers/comedi/drivers/ni_at_a2150.c @@ -132,11 +132,11 @@ static irqreturn_t a2150_interrupt(int irq, void *d) struct comedi_device *dev = d; struct a2150_private *devpriv = dev->private; struct comedi_isadma *dma = devpriv->dma; - struct comedi_isadma_desc *desc = &dma->desc[0]; + struct comedi_isadma_desc *desc; struct comedi_subdevice *s = dev->read_subdev; - struct comedi_async *async = s->async; - struct comedi_cmd *cmd = &async->cmd; - unsigned short *buf = desc->virt_addr; + struct comedi_async *async; + struct comedi_cmd *cmd; + unsigned short *buf; unsigned int max_points, num_points, residue, leftover; unsigned short dpnt; int status; @@ -145,6 +145,11 @@ static irqreturn_t a2150_interrupt(int irq, void *d) if (!dev->attached) return IRQ_HANDLED; + desc = &dma->desc[0]; + async = s->async; + cmd = &async->cmd; + buf = desc->virt_addr; + status = inw(dev->iobase + STATUS_REG); if ((status & INTR_BIT) == 0) return IRQ_NONE; -- 2.53.0