From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795043597; b=tCKf5D4rmWgkfoogu6feN0wPAcMDHZgnxtzRbpH4xSD7/VWKWOFBg+s6pKkItRgBXU9f Bbh4lFbNploAKJ33AfqzwrGqCHGMaxVsjsAe4XGsLw3wWgN5RMyNJLKNH3NpB5/6bnVl3 puZG6ZCG4PQ+O38Vc0+cVcl3IrSKhlQfhGfjFqp/mZHCxf0Eh+0r8uXOcP50Y+KT9cWv5 f3CZBxmmHZISX+0AFfdK/pi9jUDlHt/3hhBcUiQuZJ6hEASW2bAmNYo5dPcUzYHhW7Bz5 g26WTcFyx5QGekmUXU8YahuHEFUM45qztHw852Osnn2YjPb1h18+M6MH2Pbn7Zy1Vvg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795043597; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=+4ncolyL7DEGVuCpTs1ESs9wueF6ERWeLCcD4crggU8=; b=duwKW/VPavaCC/3mLnCVZ1t/QoUKa+1VM4E3jXvPbZ5G9ggb+G0OcO9my+GksaZRKoRA BVk57P99gUAocFV8lgtzS7KrwVjdmeJxCi1H69kKtBgVYU/445SZYNuw46BZ40hyG5hOa 5kevTrgc6pLHMn5WxL/w40m16aBiH2CSKF/3Lq/v9bzXT4//GKi/iGZ0I1WxeQlsWo4jn GNi5wLa8tARurVm4tHsvbMQ4QfsDrZp1hxkFLQt9Cc6sbiYQzy5UcnF8CGia83HxuJ50N tUpEOTsZf/7kCccUKn/1+uYZyNgNlJNd+FblXw531747+2OOPnN9XwluGQQtph9ak0w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ucUH5Zxn; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D44606A31C; Wed, 18 Nov 2026 23:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ucUH5Zxn Received: by smtp.kernel.org (Postfix) with ESMTPSA id A77101F000C4; Wed, 18 Nov 2026 23:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795043597; bh=+4ncolyL7DEGVuCpTs1ESs9wueF6ERWeLCcD4crggU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ucUH5ZxnZW7pNyj0Afb1JXkWGwucakkTvk16vMphJQdnf0f3++yIzjPxThTEcxdJv 1AE61B5tPAy7pxyX74B/B2EmxYMYLAab8c8k7UzMYxPsapiVRrIbsaBsTTlpWdk6y2 o2HeKfSF7U3rOD8kM9LSkc1yIy6AJyVMdYpVN4LM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, BingKun Yue , Helge Deller , Sasha Levin Subject: [PATCH 6.1 0266/2857] fbdev: platinumfb: add error checking for ioremap calls Date: Wed, 18 Nov 2026 15:21:40 +0100 Message-ID: <20261118150211.011226976@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: BingKun Yue [ Upstream commit ba13226fc966004713aed47931db8922b84d1960 ] The ioremap() and ioremap_wt() calls in platinumfb_probe() were not checked for failure. If any of these mappings fail, the driver would dereference NULL pointers, leading to a kernel panic. Add proper error checking and use goto-based cleanup to avoid code duplication across the error paths. Signed-off-by: BingKun Yue Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/platinumfb.c | 35 ++++++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/platinumfb.c b/drivers/video/fbdev/platinumfb.c index 5b9e26ea64494..12454703c1886 100644 --- a/drivers/video/fbdev/platinumfb.c +++ b/drivers/video/fbdev/platinumfb.c @@ -570,15 +570,30 @@ static int platinumfb_probe(struct platform_device* odev) /* frame buffer - map only 4MB */ pinfo->frame_buffer_phys = pinfo->rsrc_fb.start; pinfo->frame_buffer = ioremap_wt(pinfo->rsrc_fb.start, 0x400000); + if (!pinfo->frame_buffer) { + dev_err(&odev->dev, "failed to ioremap frame buffer\n"); + rc = -ENOMEM; + goto err_release_fb; + } pinfo->base_frame_buffer = pinfo->frame_buffer; /* registers */ pinfo->platinum_regs_phys = pinfo->rsrc_reg.start; pinfo->platinum_regs = ioremap(pinfo->rsrc_reg.start, 0x1000); + if (!pinfo->platinum_regs) { + dev_err(&odev->dev, "failed to ioremap registers\n"); + rc = -ENOMEM; + goto err_unmap_fb; + } pinfo->cmap_regs_phys = 0xf301b000; /* XXX not in prom? */ request_mem_region(pinfo->cmap_regs_phys, 0x1000, "platinumfb cmap"); pinfo->cmap_regs = ioremap(pinfo->cmap_regs_phys, 0x1000); + if (!pinfo->cmap_regs) { + dev_err(&odev->dev, "failed to ioremap cmap registers\n"); + rc = -ENOMEM; + goto err_release_cmap; + } /* Grok total video ram */ out_be32(&pinfo->platinum_regs->reg[16].r, (unsigned)pinfo->frame_buffer_phys); @@ -626,13 +641,21 @@ static int platinumfb_probe(struct platform_device* odev) dev_set_drvdata(&odev->dev, info); rc = platinum_init_fb(info); - if (rc != 0) { - iounmap(pinfo->frame_buffer); - iounmap(pinfo->platinum_regs); - iounmap(pinfo->cmap_regs); - framebuffer_release(info); - } + if (rc != 0) + goto err_unmap_cmap; + + return 0; +err_unmap_cmap: + iounmap(pinfo->cmap_regs); +err_release_cmap: + release_mem_region(pinfo->cmap_regs_phys, 0x1000); + iounmap(pinfo->platinum_regs); +err_unmap_fb: + iounmap(pinfo->frame_buffer); +err_release_fb: + release_mem_region(pinfo->rsrc_fb.start, resource_size(&pinfo->rsrc_fb)); + framebuffer_release(info); return rc; } -- 2.53.0