From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795044161; b=YDnFKF5/+GmgCfEUWe0IrLuD6V+h5QM1feeoqYL/OCI2KPh9EIwRgYXJvXTLDcD9f1OY 1rRSqxxtAHvgjQ0MnFVUuS2m/OB3Y1ACFhHKMWfQSKl0AZ4Ukji8jB3WXCYSwHVVy2vHQ C02zfuYjO4COQR/YwK82VU9NQQtuqoRyR9yMydm+tiH4C7pqQLggbeR634nvAQq1RPKVF y4CuAxPHe43j+WIOtiLA43v6Y5HuydTfhrXab9j2zhe3Z+7tIQovGPCANsTg6zGfmdSEH 0WyDrRJM89NgmeOfAOfYP5ztBndR1dsKGc5fkxGYn3qNKT7VSDLPX6S8ra7NxlpFlug== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795044161; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=283f+IkWzx50DsbQWWBYK8mEjmO69QiLGTTnyoIYHAE=; b=lxbNv1A2z7FKwBhdyOmwVXyGUR6lClsBADBQ1QdeMm7p95tYWMKz3eYcI4TrqjskTxkM AODbRvXb69JqgoF483/AJ6GwBHLOOchTqB/syH5pasQSKB7xXgAoY56/EAirXXZ8NOPbB 2iZXAnZXaGO5nMrPvUPooyA+SSKOEEYxkJH6nluqlNIJZqkHYTtqrL79XnQIiMx4EAAcy BjwqILHXk388TnViQf7lGFkml7tTXM0v4+oktFHNkQCgdXh3b35bC8ESlp8iDgtWEk14d gStekRiMkO+Xap11qKT9bgQTijdNsOY41/bbWAp/mpW7t+RjLSqjJ5+LBlr31nvyLPw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=XDuSSARh; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 709FC606A320; Wed, 18 Nov 2026 23:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=XDuSSARh Received: by smtp.kernel.org (Postfix) with ESMTPSA id C995C1F000C4; Wed, 18 Nov 2026 23:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795044161; bh=283f+IkWzx50DsbQWWBYK8mEjmO69QiLGTTnyoIYHAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XDuSSARhUBhXQ5HANclcYk8/Jdb/W/vPNpuwitvZN93aGd89u2mova6ctIwlZsBdg kHMT54Luoy4gYf6Z+F1hUwQZErifB5oRHdli2IDTn47NZHT8+LoXVejXHa4e99CCFP p6H4MxI3jRkW+xxe2FSw0Bx4dmkj2hXJQAQZ/dt8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mark Rutland , Jinjie Ruan , Ada Couprie Diaz , Ard Biesheuvel , Catalin Marinas , James Morse , Marc Zyngier , Peter Zijlstra , Vladimir Murzin , Will Deacon , Yang Shi , Sasha Levin Subject: [PATCH 6.1 0420/2857] arm64: percpu: Fix LSE operations on {8,16}-bit types Date: Wed, 18 Nov 2026 15:24:14 +0100 Message-ID: <20261118150216.505359844@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Rutland [ Upstream commit 8cf2093f5372952a9ebc805c418d45df7112cd14 ] The assembly for __percpu_##name##_case_##sz() and __percpu_##name##_return_case_##sz() doesn't use the 'sfx' macro argument to form the LSE instruction. Without 'sfx', a W register argument will imply a 32-bit memory location, and consequently {8,16}-bit ops will erroneously read and write 32 bits of memory when the LSE instruction is used. Fix this by appending 'sfx' to 'op_lse' to LSE instruction. It is not necessary (and not valid) to append 'sfx' to 'op_llsc', as 'op_llsc' is a register-register operation which does not access memory (and does not take a size suffix). Fixes: 959bf2fd03b5 ("arm64: percpu: Rewrite per-cpu ops to allow use of LSE atomics") Signed-off-by: Mark Rutland Reviewed-by: Jinjie Ruan Cc: Ada Couprie Diaz Cc: Ard Biesheuvel Cc: Catalin Marinas Cc: James Morse Cc: Marc Zyngier Cc: Peter Zijlstra Cc: Vladimir Murzin Cc: Will Deacon Cc: Yang Shi Cc: stable@vger.kernel.org Reviewed-by: Vladimir Murzin Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- arch/arm64/include/asm/percpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/percpu.h b/arch/arm64/include/asm/percpu.h index f4b57b911139d..3e7ca9c683f10 100644 --- a/arch/arm64/include/asm/percpu.h +++ b/arch/arm64/include/asm/percpu.h @@ -77,7 +77,7 @@ __percpu_##name##_case_##sz(void *ptr, unsigned long val) \ " stxr" #sfx "\t%w[loop], %" #w "[tmp], %[ptr]\n" \ " cbnz %w[loop], 1b", \ /* LSE atomics */ \ - #op_lse "\t%" #w "[val], %" #w "[tmp], %[ptr]\n" \ + #op_lse #sfx "\t%" #w "[val], %" #w "[tmp], %[ptr]\n" \ __nops(3)) \ : [loop] "=&r" (loop), [tmp] "=&r" (tmp), \ [ptr] "+Q"(*(u##sz *)ptr) \ @@ -98,7 +98,7 @@ __percpu_##name##_return_case_##sz(void *ptr, unsigned long val) \ " stxr" #sfx "\t%w[loop], %" #w "[ret], %[ptr]\n" \ " cbnz %w[loop], 1b", \ /* LSE atomics */ \ - #op_lse "\t%" #w "[val], %" #w "[ret], %[ptr]\n" \ + #op_lse #sfx "\t%" #w "[val], %" #w "[ret], %[ptr]\n" \ #op_llsc "\t%" #w "[ret], %" #w "[ret], %" #w "[val]\n" \ __nops(2)) \ : [loop] "=&r" (loop), [ret] "=&r" (ret), \ -- 2.53.0