From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795044401; b=CG23G3Yyh9CTaIgfdoL7hewo96NCWpMZipYZtllNQnbjLgEON+V8uqwSBFkzDW3WqTl5 ZkIbTEqNVLF5NDADRXhDUqE6NPae52aTg33HiDC6UTT4AGJiFztapXzFUPF8yTDIx4K/m YgYPZyh6EJHpe2nOf7vj6bGJMuvXj1xsyABOcXikAyLZtObt7Da3ZDc/zow2THPrxXC9S 1IFBPXFqk2m02mPeC2g/lUiQ9IXHcx1RxxxU+phkcsk0mWsCi3Lr2PYFLFWswAMnX0zsa Dw0Y6Xs4evgDz5iAxR3Zu/nE1k1eh/gi5wez3faHXGekzgyJujBMd2dz8wMobJ+1hJg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795044401; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=N1lPwMEnkjftD6vvqARJJJj57R8Mt16C1wctOPFcvtE=; b=JJI4JkKLq5Fli/bqllBCQ3BP+ly5h/LkEUw6pTPCY4pdf7BbinB0O1I11hM+GQac9Sy/ HZHKDMs2SMo6ACFtpk9tdQC76C5We5OSK73KNvOLz3aZVbseqoERzFfxRXvkQwylk59ZW cgk2Fx+Bu9p5SbBuw8mFrrwxF3vxjL7HBYd0KyS5qdgbGsS1cZfhUWkWMgaZp6aAtUPOS St2uydr4NRmOdbt5ziaI34SPmjfwAtawAhYhz776kUmq3NpkdqEsQU1wcrf6PvCd9jK3S akkoNiD84bASNSqsH3icVvaY0/NKs8PWR6pY4pg12QIlvtiPx1KACLkOvG5MDws60Ow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=r+7RdAQK; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D2F606A320; Wed, 18 Nov 2026 23:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=r+7RdAQK Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8836E1F000C4; Wed, 18 Nov 2026 23:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795044401; bh=N1lPwMEnkjftD6vvqARJJJj57R8Mt16C1wctOPFcvtE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=r+7RdAQKEDChd2ic1LvauJIZoxZjLk3QqoDiHfTtogjxDyg8dSyUFltnoMwXuBZT4 zk60RcG+CMtHxuTO1Ozq4f9RmEH/YlqUgNVMk9l1ZiMSKVS7NoRNhIHmVQEyKXcGB0 qRaoQDIRrAG3FavRVjOIbouTDVNi450q6gGFdXKQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yibo Tan , Helge Deller Subject: [PATCH 6.1 0553/2857] fbdev: atmel_lcdfb: Prevent FIFO work after removal Date: Wed, 18 Nov 2026 15:26:27 +0100 Message-ID: <20261118150221.403688888@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yibo Tan commit 20b3b97cf89cb381bf07516090d99399cc9b91fd upstream. The LCD controller IRQ schedules sinfo->task to recover from a FIFO underflow. Probe currently requests the IRQ before initializing the work, so an early interrupt can schedule an uninitialized work item. The probe error path and remove path cancel the work before freeing the IRQ. A FIFO-underflow interrupt can schedule the work again after that cancellation. framebuffer_release() may then free sinfo while the work is still pending. KASAN reported a use-after-free in atmel_lcdfb_task() when an underflow interrupt occurred during removal. With the IRQ freed before the work was cancelled, the same test completed without a kernel diagnostic. Initialize the work before requesting the IRQ. In both cleanup paths, free the IRQ before cancelling the work so that it cannot be scheduled again after cancellation. Fixes: d22579b83735 ("atmel_lcdfb: FIFO underflow management") Cc: stable@vger.kernel.org Assisted-by: Codex:GPT-5 Signed-off-by: Yibo Tan Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/atmel_lcdfb.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -1171,6 +1171,9 @@ static int __init atmel_lcdfb_probe(stru /* Initialize PWM for contrast or backlight ("off") */ init_contrast(sinfo); + /* Some LCDC recovery operations require process context. */ + INIT_WORK(&sinfo->task, atmel_lcdfb_task); + /* interrupt */ ret = request_irq(sinfo->irq_base, atmel_lcdfb_interrupt, 0, pdev->name, info); if (ret) { @@ -1178,10 +1181,6 @@ static int __init atmel_lcdfb_probe(stru goto unmap_mmio; } - /* Some operations on the LCDC might sleep and - * require a preemptible task context */ - INIT_WORK(&sinfo->task, atmel_lcdfb_task); - ret = atmel_lcdfb_init_fbinfo(sinfo); if (ret < 0) { dev_err(dev, "init fbinfo failed: %d\n", ret); @@ -1217,8 +1216,8 @@ reset_drvdata: dev_set_drvdata(dev, NULL); fb_dealloc_cmap(&info->cmap); unregister_irqs: - cancel_work_sync(&sinfo->task); free_irq(sinfo->irq_base, info); + cancel_work_sync(&sinfo->task); unmap_mmio: exit_backlight(sinfo); iounmap(sinfo->mmio); @@ -1255,6 +1254,7 @@ static int __exit atmel_lcdfb_remove(str return 0; sinfo = info->par; + free_irq(sinfo->irq_base, info); cancel_work_sync(&sinfo->task); exit_backlight(sinfo); atmel_lcdfb_power_control(sinfo, 0); @@ -1263,7 +1263,6 @@ static int __exit atmel_lcdfb_remove(str clk_put(sinfo->lcdc_clk); clk_put(sinfo->bus_clk); fb_dealloc_cmap(&info->cmap); - free_irq(sinfo->irq_base, info); iounmap(sinfo->mmio); release_mem_region(info->fix.mmio_start, info->fix.mmio_len); if (platform_get_resource(pdev, IORESOURCE_MEM, 1)) {