From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795045614; b=4cKvi9btx8DB5p6L5SFX11aG3K6I8Zq6zvFW/eqiP+AhI11MGyY39t09IMBQ+0U/V0yw 3AJs2Vzv23JFRoiqj0XFBlArtAGKjQNW4ZGfOC7hNiw6u3dlo/VSpRIeS40JwBWxxMN6N W1s9pJbboDoVHDp4WxGAmj2AJRAqp3tlhazAkeMEzptAK5EeTXfMP3A2j/NaPvVgJrmZZ iEE+nOpe/+RJrv3ovQfYHs0UXvvffeGrl27AKESfcRm5qPIKGgnnFTAWCuGE9iZYS2FwD bxMHt6oim6nMAa86Shj6FTVHNJglAUsql4P7XsjQm9JWJThzRs8P/gmyDI6TEOyt7uA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795045614; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=UtV53unA/3y+D9eJgFLAtUW9xc8pH/YwC0IRJ3udT9Y=; b=I6V+pIZpkS2x9vwbVCNfVIB0lucEi594nHds1ygsmiqdX5qnhZw5waB9Hf80b0mKqqcN Q+SyE4vI8rPLTlylm6CMrf7MpKQguJJuav8+B3Wlnj4oXFukruLTFg7XQ5aE9GfJ1+Usw lIm28cIZfIBviFOVoWgGkuBk5x13rrWezf1sbeCuz8B9T9tyuvsA2UKh0+NCXERFh9fiR j7JBRaye9d7PeoplZ1rfqNtkTreIg8W6Bnbcm5VTMzEHB5vD14EJ3F0zABpHPB2N4tsNf nF1U2tYaW6fiH7iZcPeviZJMTjAEBL0Z7TCTRnuKY9+aGqQ1SVGAPcnUkBSe4AobzPA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mIhkNlVC; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D7FA606A325; Wed, 18 Nov 2026 23:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=mIhkNlVC Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A0F51F000C4; Wed, 18 Nov 2026 23:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795045613; bh=UtV53unA/3y+D9eJgFLAtUW9xc8pH/YwC0IRJ3udT9Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mIhkNlVCjuoleOtU47INhuOaL2wXfVWnHUnN4ijh21Lxq9xC2E1sNmk9zmkcMfr1R 2QtKJcIw4jp5ieV+7sABTIu9ws+1mJf+g4WptqOzZdEn3qzrOUQZ4xaVIHFyeAb10G mQ5zhd9l30Q9E9htM+rDQ3PAPDHVv8J0eHP4F9zw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aamir Ahmed , Andrew Morton , Alain Knaff , "H. Peter Anvin" , Sasha Levin Subject: [PATCH 6.1 0946/2857] lib: decompress_bunzip2: fix integer overflow in run-length decoding Date: Wed, 18 Nov 2026 15:33:00 +0100 Message-ID: <20261118150235.669335562@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aamir Ahmed [ Upstream commit b822ad8d702df0be9fe3f24f71caeb0522d72319 ] The RUNA/RUNB decoder in get_next_block() accumulates a run length into the signed int t with no bound. runPos doubles per symbol, so t grows as at least 2^n-1 and reaches INT_MAX after 31 RUNA symbols. The guard that follows, dbufCount+t >= dbufSize, is itself a signed addition, and as the kernel builds with -fno-strict-overflow it wraps negative once dbufCount is nonzero, so the guard is skipped. while (t--) dbuf[dbufCount++] = uc then writes INT_MAX entries into a buffer holding at most 900000. One literal symbol ahead of the run is enough to make dbufCount nonzero. Bound t to the block size as it is accumulated. t only grows within a run, so the value tested never exceeds the final run length; any stream that decodes today satisfies dbufCount+t < dbufSize at the flush, hence t < dbufSize throughout, and no such stream is rejected. Because t grows as at least 2^n-1 the bound trips by the 20th symbol, leaving runPos at most 2^19, so the following runPos <<= 1 cannot overflow either. Link: https://lore.kernel.org/AS8P251MB00010FE5E38D253CF98A652AC8B92@AS8P251MB0001.EURP251.PROD.OUTLOOK.COM Fixes: bc22c17e12c1 ("bzip2/lzma: library support for gzip, bzip2 and lzma decompression") Signed-off-by: Aamir Ahmed Signed-off-by: Andrew Morton Assisted-by: LLM Cc: Alain Knaff Cc: "H. Peter Anvin" Cc: Signed-off-by: Sasha Levin --- lib/decompress_bunzip2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/decompress_bunzip2.c b/lib/decompress_bunzip2.c index 4f98cdea7e0b3..b8fb40ed06d22 100644 --- a/lib/decompress_bunzip2.c +++ b/lib/decompress_bunzip2.c @@ -428,6 +428,10 @@ static int INIT get_next_block(struct bunzip_data *bd) t += (runPos << nextSym); /* +runPos if RUNA; +2*runPos if RUNB */ + /* Bound the run so t and runPos cannot overflow. */ + if (t >= dbufSize) + return RETVAL_DATA_ERROR; + runPos <<= 1; continue; } -- 2.53.0