From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795015022; b=bIpOFOPqtW/wEdpoVFkSAwqLBV219n42fzoNOkkaipMD0gFryfi0nluboXfcFkoAM81i TD4W3iTBgwn0dhNGWz+VLtFdJIco02vOesn9nfjEPOjgohCYrYHRB6xmnUio5SM/xhu0k TxC+p8CpfpYbWLMUWfnvY00NzmKl5y2FZKIuRkXw4TYQQRVFlGs5GQoaO/68mc3xRVpMs LsgtvUsa7keTMWjTYd9AvnkI7FZGcz6zoJVJ3rTPZcwPCDW6ME53E564IcN4L/gKlr+Ui 3DykKeFkctE6CnxEl/4HJrJhq/Tk4h/PWp/3y0wTfLwnV9Hj26PGY8/k5uRDHTCAzxw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795015022; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=zWb51WWdRa1V9cYgHt/iNPsPn+CjJK2ur5uj1NpWNnw=; b=y+pDKIxUNF0rISetmJRbl71SPrSMWjhs/oHyh3h7VLCzk0UWYHfAALb3kHGhbNbPmwWX Eo5I8ZUJJ/9rjEcle2ZabNwowzAfQsQCRJt9C/WqVEw1I4g52fTUlnbSonohv/XByfDwO hDOt1DzG5LSLdQUchQPkgYmnFVACIAi2c86MLWwy/jabb3mdtjWrkqYntfDjsG0rfCea3 MkdNbP05hIC7JdiyB0K7d8CrIYZnqtryMdFWtb9V2E4gpaICALAIlKpvlt/hBlunuxKUK o82f5zQn5ZQfmpw9wzb8iv7Gk7XXSuP4uiocnmZ15lMAaYFJYLItbKfFdqavr0WObZA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="uvHA/lDY"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1C1606A331; Wed, 18 Nov 2026 15:17:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=uvHA/lDY Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DA381F000C4; Wed, 18 Nov 2026 15:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795015021; bh=zWb51WWdRa1V9cYgHt/iNPsPn+CjJK2ur5uj1NpWNnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uvHA/lDYVM3IwQYwY8d89vu4u6XUZtfU0UWqtlg37k1qBehlKbc32uoIP4sqIzeCh csW9VQGHkipSTgvPMTetBEyvPQOdJGmoW1OtrzCFnYtdBz2XqWxIvP4sa7MFMI7vSY szi0Tw6F7mykr89df8UmDTJOLyUE/KsaBML692KY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bo Cao , Takashi Iwai , Sasha Levin Subject: [PATCH 7.3 0024/2651] ALSA: pcm: Prevent O_APPEND open on OSS streams Date: Wed, 18 Nov 2026 15:21:04 +0100 Message-ID: <20261118150248.853848609@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai [ Upstream commit 9017bc3d13da0ea4e63be618c87143a7b69185e6 ] ALSA PCM core accepts to re-use the existing stream when O_APPEND is passed, and it's been used for dmix, etc. However, this mode isn't supposed to be used for OSS: the OSS stream allows re-configuration via its hw_params/hw_refine procedure even while it's being mmapped, so it implies the usage of only a single stream. Because of this assumption, the sanity check is skipped for OSS streams, and if user may attach to an existing OSS stream with O_APPEND, it may result in a UAF of the mapped pages which could be used as a privilege escalation exploit. For addressing it, this patch simply prohibits the O_APPEND behavior on the OSS stream. O_APPEND is never used for OSS layer itself, so this can't break for the right applications. Fixes: 0df63e44c3e3 ("[ALSA] Add O_APPEND flag support to PCM") Cc: stable@vger.kernel.org Reported-by: Bo Cao Link: https://lore.kernel.org/tencent_E90BB4F086165FAA3313723567A5C675EA06@qq.com Link: https://patch.msgid.link/20261103155844.120838-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/core/pcm.c | 2 ++ sound/core/pcm_local.h | 6 ++++++ sound/core/pcm_native.c | 6 ------ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/core/pcm.c b/sound/core/pcm.c index 41c2cab7a52c4..6aad7a1fbf1a9 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -919,6 +919,8 @@ int snd_pcm_attach_substream(struct snd_pcm *pcm, int stream, return -ENODEV; if (! SUBSTREAM_BUSY(substream)) return -EBADFD; + if (is_oss_stream(substream)) + return -EINVAL; substream->ref_count++; *rsubstream = substream; return 0; diff --git a/sound/core/pcm_local.h b/sound/core/pcm_local.h index ecb21697ae3a4..4b134d435c24f 100644 --- a/sound/core/pcm_local.h +++ b/sound/core/pcm_local.h @@ -80,4 +80,10 @@ static inline void snd_pcm_dma_buffer_sync(struct snd_pcm_substream *substream, snd_dma_buffer_sync(snd_pcm_get_dma_buf(substream), mode); } +#if IS_ENABLED(CONFIG_SND_PCM_OSS) +#define is_oss_stream(substream) ((substream)->oss.oss) +#else +#define is_oss_stream(substream) false +#endif + #endif /* __SOUND_CORE_PCM_LOCAL_H */ diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index c9e80617f508b..1164ee7f14f07 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -772,12 +772,6 @@ int snd_pcm_runtime_buffer_set_silence(struct snd_pcm_runtime *runtime) } EXPORT_SYMBOL_GPL(snd_pcm_runtime_buffer_set_silence); -#if IS_ENABLED(CONFIG_SND_PCM_OSS) -#define is_oss_stream(substream) ((substream)->oss.oss) -#else -#define is_oss_stream(substream) false -#endif - static void pcm_qos_req_clear(struct snd_pcm_substream *substream) { if (cpu_latency_qos_request_active(&substream->latency_pm_qos_req)) -- 2.53.0