From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795015071; b=VSEWf2K9DiERsXV3I9ByfS2R8AUx5C1gtyVyk+9oMsd0ZS/ajjdiVKzUioNCYwJGVPW5 1S5Bc2gAihf1rl24IBB/BvkIwNw2Kw/JlA26WNRu2YKP4qCoK408UyicFT9Xv2c6pXYLU cCk/5AODhy8sANaFLeFrkCe7lHOa+5jiISiqjY6P9gv1/RPPoIT2nfAKbIZEhf9LunaYX ua22naxyaSo2UYZGQy0PaLH2DlP+dcLJzqB6vZFi01Vpkjt8Z/3USEFY5mBONSVeojhHq h786e5ffSH0OXO5UiEQ/b2yJr4R0SI36MbKclWkb1YRAxjReNmPupcy4sCxZY2ner7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795015071; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=F4ln2Dp3v8tlUuKVOfAkYSlNoy512F2QkHHCv5C30Y8=; b=Pr85c5V57eBnQVAGufhegn7IJ+jNmHaCiv+7SI7qFi34hXCJLW/EPGn5pWgWzQ/jfh9S HrC4valevcQK31vQcOce+kC29lA/9OKpvOpgC6iiOblwKC6K0PlUTVniybYu/Q5xwtE0Z foxJ2Ya630HS9eatjlNfKUqcJIIXmpCptYZVlaHm1PCrKOgHEhYwON0mW6h7MlDN17O2+ Qx9HZTVlKEG5RPHIh+EuPNbvrkEvPKdh9fMh1vHCUBP/H8eTRat2vknasNrJMrvPUaJAQ 2nzl4eoRH22MoKK/FvIRJD+61sQ+Sp9Q5NLdgg7E5a1H39IvMzQMUUrR3YV1XTrXxnA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0bfxWHmk; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8819606A335; Wed, 18 Nov 2026 15:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0bfxWHmk Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC6B71F000C4; Wed, 18 Nov 2026 15:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795015071; bh=F4ln2Dp3v8tlUuKVOfAkYSlNoy512F2QkHHCv5C30Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0bfxWHmkan0pwJwlb+rdr3eFXLkqKJziUJNJrCMMppK0xDHr8u3ZL0zxB/T/+Dw9C BAfknB3f07hUVQjhCp6HRjeDAxfJJ+5VjZnADmNeQpVLl0EUtMTvHMi/ygPuovxMDx BAZENcQAC5/Dw40RrS0DUliwTNZxo0v/NOje4odI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "David Hildenbrand (Arm)" , "Lorenzo Stoakes (ARM)" , Andrew Morton , Pedro Falcato , "Gregory Price (Meta)" , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Davidlohr Bueso , SJ Park , Kees Cook , Colin Cross , Sasha Levin Subject: [PATCH 7.3 0043/2651] mm/madvise: preserve VMA_SOFTDIRTY_BIT when changing anonymous names Date: Wed, 18 Nov 2026 15:21:23 +0100 Message-ID: <20261118150249.516470138@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Hildenbrand (Arm) [ Upstream commit 652f15be3c11415725694ccea317c51e35c0b582 ] When changing the anonymous VMA name, madvise_update_vma() calls vma_modify_name() to possibly merge with adjacent VMAs. We don't call vma_modify_flags() and consequently don't obtain the new VMA flags. Later in the function we update the VMA flags to the stale new_vma_flags we obtained before. This can result in us losing the VMA_SOFTDIRTY_BIT flag set on a VMA we just merged with. There is no need to update the VMA flags at all, so just exit early. This skips calling khugepaged_enter_vma(), but since the flags didn't change this is fine. [ljs@kernel.org: minor edit of commit message, rebased] Link: https://lore.kernel.org/20261023-fix-vma-atomic-v1-3-8ff4fae1fc85@kernel.org Fixes: 9a10064f5625 ("mm: add a field to store names for private anonymous memory") Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Lorenzo Stoakes (ARM) Signed-off-by: Andrew Morton Reviewed-by: Lorenzo Stoakes (ARM) Reviewed-by: Pedro Falcato Tested-by: Gregory Price (Meta) Cc: Liam R. Howlett Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Cc: Jann Horn Cc: Davidlohr Bueso Cc: SJ Park Cc: Kees Cook Cc: Colin Cross Cc: Signed-off-by: Sasha Levin --- mm/madvise.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 9d64e15dfdb48..7291d03d66928 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -177,6 +177,9 @@ static int madvise_update_vma(vm_flags_t new_flags, /* vm_flags is protected by the mmap_lock held in write mode. */ vma_start_write(vma); + if (set_new_anon_name) + return replace_anon_vma_name(vma, anon_name); + vma_overwrite_flags(vma, new_vma_flags); /* * If the vma become good for khugepaged to scan, @@ -186,9 +189,6 @@ static int madvise_update_vma(vm_flags_t new_flags, if (vma_flags_test(&new_vma_flags, VMA_HUGEPAGE_BIT)) khugepaged_enter_vma(vma, vma_flags_to_legacy(new_vma_flags)); - if (set_new_anon_name) - return replace_anon_vma_name(vma, anon_name); - return 0; } -- 2.53.0