From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795015336; b=Us/V+5O0SVcyOU3wxP/mRHJ2TpsPFOSXcTBUeC9anIuEbeQH+Fg9zaYuttVuTaLwHdHi xhiWNN52nnyRMaSumwfcBde5it1Elaoh2A8uYdYkAuthPN4HAHSEm5Thf3fSwTemEKUTb fpUtLg4xHfiCi8NC9t49Wb5hIMeY67/pWaSkBMrM5aDmM4a9aD8i+YZIIl+PnFSfhmY78 nIp428+SYoCBUsUfjUFc/a+AIC/RIWbWcIbqBW0Osm3Krm8kmBfGun042WvtdeUm/W7rW PKnAYdU4p0QSBtDKTczB2feM/8wrE2O/QYrLkWWbFbZKjMcO+QpnjTVJTDkhsBzRI6w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795015336; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=FB91Vwca4OHBf5SYpAzWSkeJ4FgEND9Q+HIHAUo1TrA=; b=eaIYkjZD3oHa5QOPapweYQBtaQ1uY+yhQT6YGOD0DL3m1s2HT9p6KmsIPTL0jLn9YT19 zZFLxMoqAH50aTh16waeVhyMdA31OFDeW4FENukVnViq3GcX37M/KXUwtWh/pIYQQCHkK VTmZLxLRmI96wkg68Pv2zw7Y8Go4xANwakxFpBye+NiWxZOfADmoWhCrdrPZWNrphTXmf lNeFdpbkIVEDBuq06B3jPx41IWmxqzOSRhYml5jF7D8STgv43Ky93POZRqf55zipHxaHZ J7qKWya+WqN6rAucHn0UGyyHKnCh6kbqBgwBq35/L6+NcAcKit6hObqAtymCfiKh0KA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tGxS+4WG; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E0D606A335; Wed, 18 Nov 2026 15:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=tGxS+4WG Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECF2E1F000C9; Wed, 18 Nov 2026 15:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795015336; bh=FB91Vwca4OHBf5SYpAzWSkeJ4FgEND9Q+HIHAUo1TrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tGxS+4WG9zw0YkwJsdJk4lu1uihI6KNiycu/MJ3Vyy+HH84hrmAgnTwREVdT4AEV2 cQFGHVbUoYaIEHRcepUu8IZtWIvV9njEQ/ifnhH74KnevxIXnGFYnkLbsPO8m/nUtw P4QZMThqZMwnsEgzfs3xIRCLrOAKjj1y3VtAUObo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ruoyu Wang , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 7.3 0137/2651] pwm: renesas-tpu: Fix runtime PM reference leak Date: Wed, 18 Nov 2026 15:22:57 +0100 Message-ID: <20261118150252.782540361@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ruoyu Wang [ Upstream commit 62cff15fbf2b12ebbb0b01ca720030c2bc12aed1 ] tpu_pwm_timer_start() used pm_runtime_get_sync() without checking its return value before touching the TPU clock. A failed runtime resume was therefore ignored, and the callback continued into register access. Use pm_runtime_resume_and_get() and propagate a failed resume. Keep the matching put when clock preparation fails after a successful resume. tpu_pwm_disable() also needs to propagate a failed start so that the PWM apply callback does not access registers while runtime PM is inactive. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 99b82abb0a35 ("pwm: Add Renesas TPU PWM driver") Signed-off-by: Ruoyu Wang Link: https://patch.msgid.link/20260814134143.1388120-1-ruoyuw560@gmail.com Signed-off-by: Uwe Kleine-König Signed-off-by: Sasha Levin --- drivers/pwm/pwm-renesas-tpu.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c index 140fd0bcb93f3..e35f2e14777dd 100644 --- a/drivers/pwm/pwm-renesas-tpu.c +++ b/drivers/pwm/pwm-renesas-tpu.c @@ -149,10 +149,14 @@ static int tpu_pwm_timer_start(struct tpu_pwm_device *tpd) if (!tpd->timer_on) { /* Wake up device and enable clock. */ - pm_runtime_get_sync(&tpd->tpu->pdev->dev); + ret = pm_runtime_resume_and_get(&tpd->tpu->pdev->dev); + if (ret < 0) + return ret; + ret = clk_prepare_enable(tpd->tpu->clk); if (ret) { dev_err(&tpd->tpu->pdev->dev, "cannot enable clock\n"); + pm_runtime_put(&tpd->tpu->pdev->dev); return ret; } tpd->timer_on = true; @@ -382,15 +386,21 @@ static int tpu_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) return 0; } -static void tpu_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm) +static int tpu_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm) { struct tpu_device *tpu = to_tpu_device(chip); struct tpu_pwm_device *tpd = &tpu->tpd[pwm->hwpwm]; + int ret; /* The timer must be running to modify the pin output configuration. */ - tpu_pwm_timer_start(tpd); + ret = tpu_pwm_timer_start(tpd); + if (ret < 0) + return ret; + tpu_pwm_set_pin(tpd, TPU_PIN_INACTIVE); tpu_pwm_timer_stop(tpd); + + return 0; } static int tpu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, @@ -401,7 +411,10 @@ static int tpu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, if (state->polarity != pwm->state.polarity) { if (enabled) { - tpu_pwm_disable(chip, pwm); + err = tpu_pwm_disable(chip, pwm); + if (err) + return err; + enabled = false; } @@ -412,7 +425,7 @@ static int tpu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, if (!state->enabled) { if (enabled) - tpu_pwm_disable(chip, pwm); + return tpu_pwm_disable(chip, pwm); return 0; } -- 2.53.0