From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795015648; b=U0g/Si2L6qo2tVI4ebWcMnUqWoiekXkY0p1paQVzHr6eVJS1f3wxHdr9bvjcuJeUTqyv xD6eHWAhTJW1BegZzQe3Co3IV+6tiItKHAs8M76+FqxPHfcJ/FhHgYQuuoM9+ij27EyRs MMlrG95DhPLE5FW23fXriWeyU4Nbo0FOWcKCj5Mii4zj00bSBd73waF7ihXkFmvbQkHS/ duluJtZuLdidcDTZbrfN6XaBk+6N7XjHpZ7NOEg4YYj09i64UpPfv/B82ayZZyJ7A+j03 3BAdLlZc1vF6ryApJ03TiLaISTutxn38eQGn3G2hkIdPksOPhlXDKWyorCSrgcsyixQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795015648; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=C/JrFAT9ckxxgg3aTu9G/6+8aPqh+9CY0I1qW1NSzzE=; b=wJL777RJFfN6hvzGoxNJJoWcbnLW7y8bPtkoVm5MTBLpEKvxyHssIWoJInXW3dKSlaLK mFrmvc7MBOW0yRMz8jl6Si3fK2Tp9ZIir7JUj+zmzJwbO5Y3ZLK5/hSjqtlj7cko+O3bL zbnWguAHPjrT6av+jJM3701BGsaypHYfgxkEKRnqSML9pp2IYeWabmvB/7O7l275k8pGF OGNREx1oflEdcqiUk9g8FIJZCxiKSQUusUpXVJsVChf+P8/3wnIqdjx1UZnLcB90x0Ues hp9Lm6KGXP1iLJbBKuGT6bSmVIMkaRJhQ8IA++b7RXgm3m4Fx7fm7XWCLNDjLi5AWLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=seA0KZAb; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FBE4606A31C; Wed, 18 Nov 2026 15:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=seA0KZAb Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E43E1F000C6; Wed, 18 Nov 2026 15:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795015648; bh=C/JrFAT9ckxxgg3aTu9G/6+8aPqh+9CY0I1qW1NSzzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=seA0KZAb7OkB79Q8TtqNglszVn2VWr6WsGSduQMowZjGl2ZA+pwO2dXVKbsZZry56 xhY9Ci5VbSo3gLqZ44873nw5RNmuY/Ds1XuWXZJD4O1ni664M+mNrMt/NIhZo0jDv3 Ry/jZHOfjj48FQaRzGHHv2UGWuZnEnlXwMxuuktk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ian Rogers , Mark Amirkan , Madhavan Srinivasan , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 7.3 0246/2651] perf evsel: Validate branch stack before byte swapping Date: Wed, 18 Nov 2026 15:24:46 +0100 Message-ID: <20261118150256.710729124@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mark Amirkan [ Upstream commit 2148e094671b0f6a44f033787b7da4ed14e96c27 ] When perf reads an opposite-endian branch stack, __evsel__parse_sample() swaps each entry before checking whether all entries fit in the event. A truncated sample can therefore make the swap loop read and write past the event boundary. A truncated perf.data file makes perf report crash with SIGSEGV. ASan reports an out-of-bounds read. A regression test puts an entry just past the declared end and shows that its flags are changed before the parser returns -EFAULT. Move the bounds check before the byte-swap loop. Valid samples are handled as before. Fixes: 63c12ae2f246dcdc ("perf evsel: Add bitfield_swap() to handle branch_stack endian issue") Reviewed-by: Ian Rogers Assisted-by: Symbolic Signed-off-by: Mark Amirkan Cc: Madhavan Srinivasan Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/tests/sample-parsing.c | 48 +++++++++++++++++++++++++++++++ tools/perf/util/evsel.c | 3 +- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c index 32dbc484487af..5839515349373 100644 --- a/tools/perf/tests/sample-parsing.c +++ b/tools/perf/tests/sample-parsing.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include #include #include @@ -417,6 +418,49 @@ static int do_test(u64 sample_type, u64 sample_regs, u64 read_format) return ret; } +static int test_truncated_branch_stack(void) +{ + struct perf_event_attr attr = { + .sample_type = PERF_SAMPLE_BRANCH_STACK, + }; + struct { + struct perf_event_header header; + u64 nr; + struct branch_entry entry; + } input = { + .header = { + .type = PERF_RECORD_SAMPLE, + .size = sizeof(input.header) + sizeof(input.nr), + }, + .nr = 1, + }; + struct perf_sample sample; + struct evsel *evsel; + u64 flags = 1; + int err; + + input.entry.flags.value = flags; + evsel = evsel__new(&attr); + if (!evsel) + return -1; + + evsel->sample_size = __evsel__sample_size(attr.sample_type); + err = __evsel__parse_sample(evsel, (union perf_event *)&input, + &sample, /*needs_swap=*/true); + perf_sample__exit(&sample); + evsel__put(evsel); + + if (err != -EFAULT) { + pr_debug("truncated branch stack returned %d, expected -EFAULT\n", err); + return -1; + } + if (input.entry.flags.value != flags) { + pr_debug("truncated branch stack modified data past the event\n"); + return -1; + } + return 0; +} + /** * test__sample_parsing - test sample parsing. * @@ -433,6 +477,10 @@ static int test__sample_parsing(struct test_suite *test __maybe_unused, int subt size_t i; int err; + err = test_truncated_branch_stack(); + if (err) + return err; + /* * Fail the test if it has not been updated when new sample format bits * were added. Please actually update the test rather than just change diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 5db43520f25e7..947835ff7426b 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -3651,6 +3651,8 @@ int __evsel__parse_sample(struct evsel *evsel, union perf_event *event, e = (struct branch_entry *)&data->branch_stack->hw_idx; } + OVERFLOW_CHECK(array, sz, max_size); + if (swapped) { /* * struct branch_flag does not have endian @@ -3666,7 +3668,6 @@ int __evsel__parse_sample(struct evsel *evsel, union perf_event *event, e->flags.value = evsel__bitfield_swap_branch_flags(e->flags.value); } - OVERFLOW_CHECK(array, sz, max_size); array = (void *)array + sz; if (evsel__has_branch_counters(evsel)) { -- 2.53.0