From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795015837; b=5Bd+cHjLiZ3n/L75p/Jzqrz5j2zXa7h1ncXeTXaMhs0kv38zyr+5JtBoEMdmfeAzXdIb e3HrP6QkDugifXvgGcUmVg7m1nWTj0Lyi2xHNFn0uXU+RGfDcur2ZFCGUbbc68quy1sMH wYow6jJTXI5RK+BcWI2H3SzDv/7ieZDwry77r7472ZM+L7TfwPt9brcJuPtRerx5nIej+ HF2+bcgAWp5xljp3GEgeHAgWJ3XmFUcs1hweGCdbLnqqIqtNLX+R8V9lBpRshlete4LRo po6ljEng9cddL//lCRX0ZwELw7pgtR8+opSsrvbwpKgBbQ+hb2UOOW5QZe0bkMyXwkA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795015837; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=4TaXxKweLsnbx+xHy/WoLb24+PDzdqST68n6n1hqe0Y=; b=HzAGOJl2lqsCwkOtA9miePbvrtCONfLhkzh+Pv+LfvAjM4M1hDtuI5kUga3CSNd+dKE8 rRy6pWNeVkqJIPnKI7WPuWjnaW7uO+pOsdxPqieIwk0XehdMZ1z/d9BUI70+t1RiAnfGQ phzz8uHbjPk7aGgts2WY7oQt+mxugeY5oDvFseVR8az9xaT9uFPJXd8kaexUMDGi5vfL8 oqj7XmOx4CarO6ACorsYpU7w/giZ9of9kzk9ocZ/LTj2LGioYixiGPS8iRFgImGnYrBNr tdv5cIOnMBaI52ml5LQSqswnZtM39TLt1e519VflWqd7Uye7Xdq6JY0ezeeHWFelfbA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=HPi09b34; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A94960A260A; Wed, 18 Nov 2026 15:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=HPi09b34 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B591F000C4; Wed, 18 Nov 2026 15:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795015836; bh=4TaXxKweLsnbx+xHy/WoLb24+PDzdqST68n6n1hqe0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HPi09b34mGY/pZlflYFyjy3uTCfZS6jBYroLTB+V0IV7AckRoAgGOtO/GrC3z3JZ3 l5PxPCk33osGe1Gdz7HKLLjgGq0N4sQzfZkrlD9JWbr8EfAJ+mKrPVD5/Tw7MlSFyj q64247uHExJpkROyyL8ylIXmKQJCUzJZ9RWuGHV4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baochen Qiang , Nicolas Escande , Rameshkumar Sundaram , Jeff Johnson , Sasha Levin Subject: [PATCH 7.3 0315/2651] wifi: ath11k: fix locking problem in ath11k_dp_rx_tid_del_func() Date: Wed, 18 Nov 2026 15:25:55 +0100 Message-ID: <20261118150259.222952454@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Escande [ Upstream commit c7555d47b1d051e0406474349deccf74b491ae01 ] In this function, we iterate over dp->reo_cmd_cache_flush_list using list_for_each_entry_safe(), under dp->reo_cmd_lock for concurrent access, and for each expired entries we : - drop the lock - call ath11k_dp_reo_cache_flush() - kfree() the entry - retake the lock to keep on iterating list_for_each_entry_safe() protects us from deleting the entry during iteration but doesn't protect for concurrent access. So another thread can take the lock and modify the list in between and crash like below. To fix the issue, move all entries that needs to be freed to a local list while under the lock and then iterate over the list to free the entries without holding the lock. BUG: Unable to handle kernel paging request at virtual address 00000010ddbeef8c Call trace: ath11k_dp_rx_tid_del_func+0x164/0x3c8 ath11k_dp_process_reo_status+0x1d4/0x2fc ath11k_dp_service_srng+0x334/0x338 ath11k_pcic_ext_grp_napi_poll+0x30/0xc0 __napi_poll+0x34/0x184 napi_threaded_poll+0xb4/0x1d8 kthread+0xdc/0xe0 ret_from_fork+0x10/0x20 Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.9.0.1-01977-QCAHKSWPL_SILICONZ-1 Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Suggested-by: Baochen Qiang Signed-off-by: Nicolas Escande Reviewed-by: Baochen Qiang Reviewed-by: Rameshkumar Sundaram Link: https://patch.msgid.link/20260813-ath11k-locking-v2-1-f4113a0bd0f4@gmail.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath11k/dp_rx.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 33425707c0842..5b717b731197a 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -762,6 +762,9 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx, struct ath11k_base *ab = dp->ab; struct dp_rx_tid *rx_tid = ctx; struct dp_reo_cache_flush_elem *elem, *tmp; + struct list_head flush_list; + + INIT_LIST_HEAD(&flush_list); if (status == HAL_REO_CMD_DRAIN) { goto free_desc; @@ -783,23 +786,25 @@ static void ath11k_dp_rx_tid_del_func(struct ath11k_dp *dp, void *ctx, list_add_tail(&elem->list, &dp->reo_cmd_cache_flush_list); dp->reo_cmd_cache_flush_count++; - /* Flush and invalidate aged REO desc from HW cache */ + /* identify aged REO desc that needs removal */ list_for_each_entry_safe(elem, tmp, &dp->reo_cmd_cache_flush_list, list) { if (dp->reo_cmd_cache_flush_count > DP_REO_DESC_FREE_THRESHOLD || time_after(jiffies, elem->ts + msecs_to_jiffies(DP_REO_DESC_FREE_TIMEOUT_MS))) { - list_del(&elem->list); + list_move_tail(&elem->list, &flush_list); dp->reo_cmd_cache_flush_count--; - spin_unlock_bh(&dp->reo_cmd_lock); - - ath11k_dp_reo_cache_flush(ab, &elem->data); - kfree(elem); - spin_lock_bh(&dp->reo_cmd_lock); } } spin_unlock_bh(&dp->reo_cmd_lock); + /* remove aged REO desc from HW */ + list_for_each_entry_safe(elem, tmp, &flush_list, list) { + ath11k_dp_reo_cache_flush(ab, &elem->data); + list_del(&elem->list); + kfree(elem); + } + return; free_desc: dma_free_noncoherent(ab->dev, rx_tid->unaligned_size, -- 2.53.0