From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016960; b=qAH9jFunXBFWYlFnhnFK1VF8I7iqb6SkEdr1xk2J9DfbIMeDFXCkzstJbnMcCnFiSNKJ s9tedogLfc48pL1WEvuxT+bHwa1vxRNjP3mbT6v5ZmBHjKBt+8EqVb0ormf0qAjb1mlbE aw3Xslsk9F7poJJsltwGOilN3J4ovZwjUBCbBUytNpJ4mcRrzg5Q/KjLPty1irbwLnh6q QvDxt++7q9qlVzsEr3ityFAZl65S077bUvqt9ZJcw8ZHpBC4QHHLzkCHy37VR/5rSN2Dk ad0fnwQNmt1JwOFPeXn+TxEaeIwa7qo9ljZ/8d6W6Xpcr/4k0QtRvSxIlddsyy6qkMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016960; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=MawoDKYPYRxV65BxaOKLM2JcDPgVp/noWBJyHdLci70=; b=PL0S2fpovKqQgM0aYtn1Ji47HAuPe3lVYgIp2L3FzN/XJIhzWFrHpJNVMFR0qTa768yp sPYb7gBOzOJtYdTSyS+xwXIqyL+X3u+koH0+ErT2VDfuXb/FB7LWA34t+JgHo5eEdI2QN ctCKarGnFHSZIBlcPQLCdnmr/YX0Bld46nIvkvuHZ/dbgmErLfR/L/Q14gWTFewIftUHc 4/G0tosDHaOCyblXr4HYucOP6hrn1mAfQiacmSkKe7exYHgIqpJGiQMUlir5HGxQ7URrI 5mR2eoGVsKK+eg0fDxySKjrdIP8+o0tzWR8MylO2Fua+ih9uQscbhV2k3td1YRfmCYw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hekVz1aX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C22A606A31C; Wed, 18 Nov 2026 15:49:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hekVz1aX Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1BB81F000C4; Wed, 18 Nov 2026 15:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016960; bh=MawoDKYPYRxV65BxaOKLM2JcDPgVp/noWBJyHdLci70=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hekVz1aXlWyJpJ6sRXZ4WnLpgsVjH8o07eYsadpSlndk1105wMdnZJQm+9MZ8JPfC D8aqIgJitXUgeiajsBuDJ31FUbqkzbhtuAMrmG2/tlwxKwiEDrUghk1FfY19E+wmiu WOixG2dLEIAbT2QQYWSEj+3z8ddZpW+CB0qC4aL0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laurent Vivier , Finn Thain , Stan Johnson , Jens Axboe , Sasha Levin Subject: [PATCH 7.3 0714/2651] swim: Check error register during sector read Date: Wed, 18 Nov 2026 15:32:34 +0100 Message-ID: <20261118150313.585958376@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Finn Thain [ Upstream commit d66bdef0a3083fed1a0fc4f0ee1c85b26476b21c ] Clear the error register only once before a sector read operation. Don't clear it afterwards -- the caller needs it. Check the error register in swim_read_sector() and return the appropriate error when necessary. Fully validate the sector header. Don't terminate the search loop early just because an erroneous sector header showed up. Fixes: 8852ecd97488 ("m68k: mac - Add SWIM floppy support") Reviewed-by: Laurent Vivier Signed-off-by: Finn Thain Tested-by: Stan Johnson Link: https://patch.msgid.link/efabd807f4ecf5cbc05b60e91ed69aa4c10691a8.1788513997.git.fthain@linux-m68k.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/swim.c | 13 +++++++------ drivers/block/swim_asm.S | 8 -------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index cf5470cfd775b..53a54a96feef1 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -483,20 +483,21 @@ static inline int swim_read_sector(struct floppy_state *fs, local_irq_save(flags); for (i = 0; i < 36; i++) { - ret = swim_read_sector_header(base, &header); - if (!ret && (header.sector == sector)) { + if (swim_read_sector_header(base, &header) || + swim_read(base, error) || header.track != track || + header.side != side || header.size != 2) + continue; + if (header.sector == sector) { /* found */ ret = swim_read_sector_data(base, buffer); + if (swim_read(base, error)) + ret = -EIO; break; } } local_irq_restore(flags); - if ((header.side != side) || (header.track != track) || - (header.sector != sector)) - return 0; - return ret; } diff --git a/drivers/block/swim_asm.S b/drivers/block/swim_asm.S index 81c824923336c..fcf574ced85ec 100644 --- a/drivers/block/swim_asm.S +++ b/drivers/block/swim_asm.S @@ -67,7 +67,6 @@ mfm_read_addrmark: movew #seek_time, %d2 wait_header_init: - tstb %a3@(read_error - read_mark) moveb #0x18, %a3@(write_mode0 - read_mark) moveb #0x01, %a3@(write_mode1 - read_mark) moveb #0x01, %a3@(write_mode0 - read_mark) @@ -140,8 +139,6 @@ crc1: tstb %a2@ andb #.Lhr_crc_error, %d5 bne signal_nonyb - tstb %a3@(read_error - read_mark) - moveq #0, %d0 signal_nonyb: moveb #0x18, %a3@(write_mode0 - read_mark) @@ -166,7 +163,6 @@ mfm_read_data: movew #seek_time, %d2 wait_data_init: - tstb %a3@(read_error - read_mark) moveb #0x18, %a3@(write_mode0 - read_mark) moveb #0x01, %a3@(write_mode1 - read_mark) moveb #0x01, %a3@(write_mode0 - read_mark) @@ -191,8 +187,6 @@ wait_data_mark_byte: /* read data */ - tstb %a3@(read_error - read_mark) - movel #sector_size-1, %d4 /* sector size */ read_new_data: movew #max_retry, %d2 @@ -234,8 +228,6 @@ data_crc1: andb #.Lhr_crc_error, %d5 bne data_exit - tstb %a3@(read_error - read_mark) - /* return number of bytes read */ movel #sector_size, %d0 -- 2.53.0