From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795033633; b=Ux79+T8h5sm2lJMC+cih8bDyAp1YrDi3HWho2vIQ3gEl6XwbeGRpfApaDs58/GXxkzAw zAdlvUmlT6gQEMsmfL5RLUviuQLl1ubpD5WYgW5hqTUweUGqb2Ued54ART16nf0TPQGvs HjvUc/oYDDHJf8Ahf6p1dSVaB2mi9vfhpYdsAdIb4/LHHEGI6z+A29rg+MaWKtaK5zRX0 tgiRzArG5Jy+ACj054QSDvbXPgkWDO2IE6S+pOGZeMrsygyY8YuvCVQRZ6vDqdW/GUakv q53geKaFQwlToCSconYiHiGRYi2KNJDNGCA5VyoEToJigxp+hVVz6zx56KoZgvaxf4w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795033633; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=NC2dtDZxOM/9Lk6nPJmeNuybIfaPqyvwXxm461IhZE0=; b=zyye4XMr1kAeDisYSYiIIPGcESuxQv4gBJYzcOdqGrP5K+ibFxUTO5pAKUQtBalgWMU3 ATUwzoKOo6StS/1YVpy8hDnzzlwPjRL2zf3Jza0tm3wHRgBB5kv44hRiiJ5P7aw6wTogW LQIEggmgYPwSlmL4aV2A/OVc/ibl2Gsl06SOyW1ApZ+FN3DUN6uLVAe8nZNh9M2V2rSER 1Qn5aQqwqFIw8BBzVAC55+mAxklKt9hkPxNspGXCkYgygLTAnt/DtFMg+NY5yumgHiOcw Au3pNV2P3/fUIXRoboM2wVH6tOSsLnQwni3eu6bzPRlTPuELb8BkKvg9Dv3mGwvSIBQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yC8PCE66; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15B73606A32A; Wed, 18 Nov 2026 20:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yC8PCE66 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 630EE1F000C4; Wed, 18 Nov 2026 20:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795033632; bh=NC2dtDZxOM/9Lk6nPJmeNuybIfaPqyvwXxm461IhZE0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yC8PCE662v6PqVmKU8vMcXRwHEvPKmekV+u63xYV48wCaD4VnIJZWsBtQ5YWVf03S KGJiy3DTYtyE0lumlMoG7/HhdwSk51C1R6OUOg7wQlsexOpd1wkywEKUHKRO5PhXlJ luJ0ZEEEscxx/FqG5zFCfbszjV12KrY4eCvLbWG8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Lew , Vishnu Santhosh , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.6 0085/3318] rpmsg: char: Check for ongoing chrdev destroy Date: Wed, 18 Nov 2026 15:11:47 +0100 Message-ID: <20261118150316.664250060@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Lew [ Upstream commit 1f9c2897afb0fe86c1fdf4f5e23c5fb8f7442f6d ] A null pointer panic is observed when stopping a remoteproc and closing a character device using the RPMSG_DESTROY_EPT_IOCTL. There is a race where each context calls rpmsg_chrdev_eptdev_destroy(). The thread that runs second will call cdev_device_del() for a second time, which fails because the first call already removed the device from sysfs. Add a check at the beginning of destroy and exit early if the destroy call has already been done. [ 26.654130] Call trace [ 26.656658] kernfs_find_and_get_ns+0x28/0x8 [ 26.661140] sysfs_unmerge_group+0x2c/0x7 [ 26.665357] dpm_sysfs_remove+0x38/0x8 [ 26.669305] device_del+0xa4/0x3e [ 26.672811] cdev_device_del+0x28/0x7 [ 26.676675] rpmsg_chrdev_eptdev_destroy+0x68/0x98 [ 26.682765] rpmsg_eptdev_ioctl+0x130/0x11c8 [ 26.688318] __arm64_sys_ioctl+0xb4/0x10 [ 26.692448] invoke_syscall+0x50/0x12 [ 26.696312] el0_svc_common.constprop.0+0xc8/0xf [ 26.701151] do_el0_svc+0x24/0x3 [ 26.704570] el0_svc+0x40/0x17 [ 26.707810] el0t_64_sync_handler+0x120/0x13 [ 26.712288] el0t_64_sync+0x1a0/0x1a Signed-off-by: Chris Lew Signed-off-by: Vishnu Santhosh Link: https://lore.kernel.org/r/20260406-rpmsg-char-fix-chrdev-destroy-race-v1-1-7317434fa246@oss.qualcomm.com Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/rpmsg/rpmsg_char.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 7aaf7d3529044..e607d542a65bf 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -79,6 +79,11 @@ int rpmsg_chrdev_eptdev_destroy(struct device *dev, void *data) struct rpmsg_eptdev *eptdev = dev_to_eptdev(dev); mutex_lock(&eptdev->ept_lock); + if (!eptdev->rpdev) { + mutex_unlock(&eptdev->ept_lock); + return 0; + } + eptdev->rpdev = NULL; if (eptdev->ept) { /* The default endpoint is released by the rpmsg core */ -- 2.53.0