From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795017488; b=z2zTYVllKP6H6DyoL4hbEV/pBH8vA5Q1vTzgaymJI/xoght35Ve1qczlZI9AV6PSQutN m7jQ6OZ/ZwALKcxBHjTa4mvLr7PhbyAQcFwAm/Zw27b7IjkAhFfFvQ28HbhXhR6JANU46 IUTb4WJE4tjBJcwzBlWGZJkkE/PzC7WnAbkJzXVVsTdydmDxpQbclwMAY0Rc3k0OQGNzj 2jBscr+wcrC9dYua7bIysWb+QHDgAW/QrR5RbsEq3QpuoKNbaqto3pUFw0GkPROCS61Q3 XBgzrYWIHfgRXZe+wAy1vYmNDILUkIC6LnvfaKDYJWzkkuUn33VIZrgToGbmvoqnPSg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795017488; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=rPDnCPPFuZXZ9b4KLyfi41jW8FBVtCgSRCKZkVmfF/k=; b=IeLhlWYhZvVxXkp6RcVKelws12YPTnWU2nB5jO3jekBcJsf2VBIjA0X1mN2Maqr+asmq DcP93AGwRrDA9tY/2K2ZJnJg9eRw5XbiYbnMg61zmUFGT5hgdk6tzvHthaMsbOBAJqgbK cD0CXRy6I1W9NNxHEiiqFUuREfsl+CHmEFxPQCK6kbAXxgFdI/3Xx6KtCnsB7hPXHvhI+ aQ7TUPXh+8xSvJXjA3RqCkb+E/GSsQgmMs8eXdohf+i9AH3Wr3TVkD5+R+gki7tPhY46x legwGsxfO/b+iyQVtdG3FdKNkUR33nGohGewgISgftU8zsTqk/1b94PGNH3dhEhdaVg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=idNYcng9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2C8606A320; Wed, 18 Nov 2026 15:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=idNYcng9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A67151F000C5; Wed, 18 Nov 2026 15:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795017488; bh=rPDnCPPFuZXZ9b4KLyfi41jW8FBVtCgSRCKZkVmfF/k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=idNYcng9bC+qsEy+jHPC+YzgbWUm5SHVunJ0kSvUSIDD2As0Nj3iwSeN0LhyJtEpP DibssT2beY8a4wZH62rcaCwuOT6QehqgukT/ULZiuJZZhuQkgF8dYtwRrre1tjzKsP lhQx4CoQBcFYa9glixF1hCjSJFntmFhc2RVI4WPE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shashank Mohan Jain , Yury Norov , Sasha Levin Subject: [PATCH 7.3 0901/2651] bitmap: bitmap_parse(): reject non-hex character before 8 digits Date: Wed, 18 Nov 2026 15:35:41 +0100 Message-ID: <20261118150320.301112256@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shashank Mohan Jain [ Upstream commit 7cee2fb210a198667d3d4200705215e6f315cab0 ] bitmap_parse() is documented to return -EINVAL for illegal characters, and it does so everywhere except when the illegal character directly precedes a chunk of exactly eight hex digits. bitmap_get_x32_reverse() parses a chunk from right to left. After it has consumed eight digits it looks at one more character: a hex digit means the chunk is wider than 32 bits and -EOVERFLOW is returned. Any other character is silently consumed as if it were a separator, and the remaining input is parsed as the next chunk. As a result: "x12345678" -> 0x12345678, returns 0 (expected -EINVAL) "1g12345678" -> 0x1_12345678, returns 0 (expected -EINVAL) "0x0000000f" -> 0xf, returns 0, while "0xf" returns -EINVAL bitmap_parse() backs cpumask_parse() and cpumask_parse_user(), so the same inconsistency is visible when writing masks such as /proc/irq/*/smp_affinity or the network queue rps_cpus/xps_cpus files. __bitmap_parse(), which this function replaced in commit 2d6261583be0 ("lib: rework bitmap_parse()"), rejected all three strings with -EINVAL, and a "0x" prefix is accepted today only when exactly eight digits follow it, so no reliably working input is lost. When the loop falls through, *end is known to be a non-separator character inside the buffer, so return -EOVERFLOW if it is a hex digit and -EINVAL otherwise. Fixes: 2d6261583be0 ("lib: rework bitmap_parse()") Assisted-by: LLM Signed-off-by: Shashank Mohan Jain Signed-off-by: Yury Norov Signed-off-by: Sasha Levin --- lib/bitmap-str.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/bitmap-str.c b/lib/bitmap-str.c index dd9aa0635fa56..e02c5bc80951c 100644 --- a/lib/bitmap-str.c +++ b/lib/bitmap-str.c @@ -414,8 +414,12 @@ static const char *bitmap_get_x32_reverse(const char *start, goto out; } - if (hex_to_bin(*end--) >= 0) - return ERR_PTR(-EOVERFLOW); + /* + * Eight digits have been consumed and the next character is not a + * separator: another hex digit means the chunk does not fit in 32 + * bits, anything else is an illegal character. + */ + return ERR_PTR(hex_to_bin(*end) >= 0 ? -EOVERFLOW : -EINVAL); out: *num = ret; return end; -- 2.53.0