From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795034014; b=lbWaJASfK0LbkO5YqbPVW6bGLaF60OcYT7ZcZlklanB04VEvopKo4/OFXzahwWeEryIh OFPWZHbG0HtuC4wQTFVhn6unUbb2VE9lksxF4+KkhAKhbIkb4UbJpMxGd7EDhD82rSnrS ORhr3/COq8BkqdDvu1PWFdiCToUaboN43RjbSd3zRIK8VTNV/zp8wnNfTRovZ+G68JiVJ 6cD6WCgCEkaN566CljI1hJkd3CvJWbcxYbwH9fn4R5ZBbNlV2bR0e+jHTyHsd5RQ4ym+/ IEF9pc6DngZXQ/KmXSGPJMxcy2ND0w9XcjAWvRL9AQ+KbBz5pSG3GbRpu+ZDTvvRL3g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795034014; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=4dkjBjvXDa3qmEEHBWEilqf6HwnbcSPfUTQakjqO/Bw=; b=gOozHnVXOOD8ayXnsZfCb+buhMcsRWM3w8A6PiNMxArNFSzf2PT6Ord3KgGDkg7GJt6R M8p/l3aZh8jSZTb1yrS7Qo3Vy974XRC0V70Z1O5eZyXiF7Zh809IS16dxkXeccPonsZV4 vWmnFQILxQhFIjkREzDAUW7VXIp+yDDM+DXmSmhZpnDmcI9msJbV8AbnTxl1SlyFfqW+H X1Y1dl2y31w1KaADVXLiF3FNiMzFsO4inT3Bn9fP/M9WUMgwBgQPTLw3vxYbVoLZrJY8C Kun5M1VlUTaXx5OYljpN+At8y3GvzyXiGIgKH8As9B31/MMt/Y7QnJbwv3brF2RbBtg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=E830Vsda; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4927606A320; Wed, 18 Nov 2026 20:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=E830Vsda Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35C6E1F000C4; Wed, 18 Nov 2026 20:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795034014; bh=4dkjBjvXDa3qmEEHBWEilqf6HwnbcSPfUTQakjqO/Bw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=E830VsdaW2vPZ0a8R4Mgym2crNV5r9QRullHy/BCgd0A4DBuUH0OzfcIeCzBL0u4e 1nDyB95d34up2yAmeTDxWVq0Y8avR8oX63YYJQZgVV/JfQE9zlXUpxSQVB3mzOTop5 AFPCIg05OFW/fvkcq5Qvw0G8NTp/ZRl1CyCYQQSs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wahid Khan , Srinivas Pandruvada , Zhang Lixu , Jiri Kosina , Sasha Levin Subject: [PATCH 6.6 0220/3318] HID: intel-ish-hid: ignore post-init ENUM_DEVICES from firmware Date: Wed, 18 Nov 2026 15:14:02 +0100 Message-ID: <20261118150321.585415211@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wahid Khan [ Upstream commit f3f3f6df05226dfa220c4e603310dae94595060a ] Some ISH firmware versions (observed on Tiger Lake LP, 8086:a0fc, GUID {33AECD58-B679-4E54-9BD9-A04D34F0C226}) periodically re-send an unsolicited HOSTIF_DM_ENUM_DEVICES response roughly every 79 seconds. The current guard collapses two distinct cases into one condition: if (!(response_flag) || init_done) -> bad packet + ish_hw_reset This incorrectly treats a valid post-init firmware announcement as a corrupted packet, triggering an ISH soft-reset and a full ISHTP re-initialisation cycle on each occurrence (~1100 times per day on affected hardware). Split the check: reject messages with no response flag as before, but simply discard valid ENUM_DEVICES messages that arrive after init is complete. Signed-off-by: Wahid Khan Acked-by: Srinivas Pandruvada Tested-by: Zhang Lixu Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index a0c1dc0941497..9b0790b81e9dc 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -113,8 +113,7 @@ static void process_recv(struct ishtp_cl *hid_ishtp_cl, void *recv_buf, switch (recv_msg->hdr.command & CMD_MASK) { case HOSTIF_DM_ENUM_DEVICES: - if ((!(recv_msg->hdr.command & ~CMD_MASK) || - client_data->init_done)) { + if (!(recv_msg->hdr.command & ~CMD_MASK)) { ++client_data->bad_recv_cnt; report_bad_packet(hid_ishtp_cl, recv_msg, cur_pos, @@ -122,6 +121,8 @@ static void process_recv(struct ishtp_cl *hid_ishtp_cl, void *recv_buf, ish_hw_reset(ishtp_get_ishtp_device(hid_ishtp_cl)); break; } + if (client_data->init_done) + break; client_data->hid_dev_count = (unsigned int)*payload; if (!client_data->hid_devices) client_data->hid_devices = devm_kcalloc( -- 2.53.0