From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795034576; b=hKOOvQExpaFQK65IxG4nS2EoGCRcadqzg199PG/5KTK6Zu2XzskQi4rWbtR63HLAuzf8 Vo5LYGqvzh4JugVR5tM9V/W6Eqk6LjR0vCDklIUC4WZFugJ4Kk/CPQAR5jNnP0cbezV/i SbZ/fxiqA5jDo3t7vxsLtGC+tPvE6dgsjpupK/+5kWPDEycj5FzWWd6RqE8CmCs3560+D QYFnmjhgm6vXVyS5VFUiuhKcHwV4B8LrpObKHTtCmQrc8koQkKHvUab4hl41cQ2lmcQPP btUsAxu+aSjHCyZQPsVxNeUjs0IMMe94saedsCP9nxJ9ASG4FtVruMakrq9PW94i0yQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795034576; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=3sTd2gyxANcj01ExN+ccoS8kHeF/MdtvcDDOSB5i9kY=; b=xAiBA5B9ae4g+x8O0afEPMfAGDlNvMNCsad/wd5PlCavlpWvKw8k+XBjar6wIu7tkyG8 3McW7hJROr203TPOfdXDBM67x55TLL7uJI6iKLnbzoT51NGzsGbLP7GToZFiMEDSLFtn8 MlEqPjn41oxyf8Ys9ky2CwQYHYr0dXDHmHV/N0902qHByvglj6wc5t7RZUMH8TdyeCaBP NAaoY1W88EkCewHy4T/VW+ZE5w6ETd8zoYJIe8LPb78kZrFz85oycQ7ctVpygYdB3b33f SGUPidvOkSc03IHShgF5JMXvjeFftJ5pXT2IaILuFYqoEXR2ltXhKdggOKm3T+4K9iQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="pwxZS/xb"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB185606A320; Wed, 18 Nov 2026 20:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=pwxZS/xb Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17B4B1F000C4; Wed, 18 Nov 2026 20:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795034576; bh=3sTd2gyxANcj01ExN+ccoS8kHeF/MdtvcDDOSB5i9kY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pwxZS/xby6yJySgR8YcZ09/0bl4GLgDT6PHIhnWE6BusIHlZDoApd0q21KSkY6jI8 r0lpexGwU5OADyq+gmPWkKiwTKr1dQVYZPX2mu8pWGcBCky7c2USqoeYaCfDb9CWO8 PQw7ZvDgQZcvw3z0su89n4bCLhM5WF6Ro5d50SMM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "David Hildenbrand (Arm)" , Pankaj Gupta , "Lorenzo Stoakes (ARM)" , Sean Christopherson , Sasha Levin Subject: [PATCH 6.6 0382/3318] KVM: SEV: Drop FOLL_WRITE for encrypted region registration Date: Wed, 18 Nov 2026 15:16:44 +0100 Message-ID: <20261118150327.729105426@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pankaj Gupta [ Upstream commit ee1a586dd1fa2f245b3b753a3e44d9263a49240b ] When pinning SEV guest memory, drop FOLL_WRITE and rely on FOLL_LONGTERM to break CoW, as *KVM* doesn't actually to the memory using the GUP'd pages. Omitting FOLL_WRITE fixes a regression when using file-backed guest memory that was introduced when KVM (correctly) added FOLL_LONG (e.g. to ensure anonymous memory is migrated out of MIGRATE_CMA/ZONE_MOVABLE before a long term pin). Unfortunately, as of commits: 8ac268436e6d ("mm/gup: disallow FOLL_LONGTERM GUP-nonfast writing to file-backed mappings") a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings") GUP uses FOLL_LONGTERM as a canary of sorts to detect pins that are likely to be problematic, and disallows WRITE+LONGTERM pins for file-backed memory. As a result, backing SEV+ guests with file-backed memory, e.g. virtio-pmem, fails due to the disallowed FOLL_LONGTERM+FOLL_WRITE combination. Note, in the past, FOLL_WRITE was required to trigger CoW unsharing, to prevent replacing the page in the (primary MMU's) page tables during a later write fault after already having pinned a (shared) page in MAP_PRIVATE mappings. FOLL_LONGTERM does that nowadays, even without FOLL_WRITE (see gup_must_unshare()). Fixes: 7e066cb9b71a ("KVM: SEV: Use long-term pin when registering encrypted memory regions") Cc: stable@vger.kernel.org Suggested-by: "David Hildenbrand (Arm)" Link: https://lore.kernel.org/all/ad784f05-b36c-4e91-9f17-4c5b826735d0@kernel.org/ Signed-off-by: Pankaj Gupta Acked-by: David Hildenbrand (Arm) Acked-by: Lorenzo Stoakes (ARM) Link: https://patch.msgid.link/20260715063626.65899-1-pankaj.gupta@amd.com [sean: massage changelog, add comment about CoW unsharing] Signed-off-by: Sean Christopherson Signed-off-by: Sasha Levin --- arch/x86/kvm/svm/sev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 75bd73f205ab6..a0f3309c28fa6 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -2000,8 +2000,12 @@ int sev_mem_enc_register_region(struct kvm *kvm, if (!region) return -ENOMEM; + /* + * Do NOT specify FOLL_WRITE, as KVM isn't using the pinned pages to + * write memory, and FOLL_LONGTERM itself triggers CoW unshare. + */ region->pages = sev_pin_memory(kvm, range->addr, range->size, ®ion->npages, - FOLL_WRITE | FOLL_LONGTERM); + FOLL_LONGTERM); if (IS_ERR(region->pages)) { ret = PTR_ERR(region->pages); goto e_free; -- 2.53.0