From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795034758; b=seQiT+zi9PP27uVy2RLUNWha2ohP4/CBmszOLwaYWE4CF+tCGbLWxuLlJ9G5MkFB0UnM zRj3AQ/0datQ9LuubBqkpb0LqOiEoSBhBiMToftEnlmRt/BOwyDTGHBjYJtWbqxY7mzda E+fqL73nXT1WEBtGGb/rj2f4L3+V/r3kmp6pqr4ROFGlD26DWGEmYwIqiOJMxTnwItPAk eqNHiwnTranPSK6K9SYanX6+Im3QxnQZ7e4PsG4kIAKFDJ4x4pmMXrZRG1PuQK/X4c6t+ 1G/5fzZK8/603uXORM2P7aaK5osYBzcXVBU4AXHEkWS20efT8NQy7rqVVHiMBR8Z3zA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795034758; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=oSssbNyvmf5Uplu7YK820sH8p7q+Mo7PI/LoeR+uZSE=; b=pdiDRTFAhN/DzD16iGAdG3O7yDK74QPxuLv8Ogbvt2PR4kbqCkHUdCq5USuYi7HNQjeN PU/366A9OIZpBUej7DnvxOK1yzcmmy28Z/gob4JYd85D97Lm8+mUUgR/r/xJaPu++dDa+ eV5e4BVODNQH01TW6ZZH4ckbN1+2DtCnlxOP1Voj4+TqbRFO2zwciNyvWdvpfHRU80isn VeSy9YWG1YbyTnbOLCxDwqGaLxJYfuo9rLE/AKYGHQ0jjgeTJboHCrKA8lkezGNbXFf4+ SP9r5ffrf9OwotpbwkUBnhYSpQ58/BTKXrcTKZQ8e0qYSeXJH9gp/BbUqWQYgj5JZVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="YJBiq/dR"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60408606A320; Wed, 18 Nov 2026 20:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=YJBiq/dR Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEF7D1F000C4; Wed, 18 Nov 2026 20:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795034758; bh=oSssbNyvmf5Uplu7YK820sH8p7q+Mo7PI/LoeR+uZSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YJBiq/dReTQpoWpNWG2impOLFx4CNyRr/Ujhd3EpGrBWV0+h0VgxDB4fPiT4AJmBo a0PDQ1WGdEuvms3VIzkupGcjTVFJchaxUTprJvV27Jo1rw/d1PJkxnbOAFho17iaZU wskVVcS5HdH+/sFLwBh1GbxQn/3unfWHuoMQuArk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Namjae Jeon , Paulo Alcantara , David Howells , Tom Talpey , Shyam Prasad N , Ronnie Sahlberg , Bharath SM , Sasha Levin Subject: [PATCH 6.6 0480/3318] smb: client: fix fattr leaking on wsl_to_fattr() failure Date: Wed, 18 Nov 2026 15:18:22 +0100 Message-ID: <20261118150331.352562853@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paulo Alcantara [ Upstream commit e1253a82bb4c0fed6706a5839fc8b6e01be1abe2 ] wsl_to_fattr() mutates fattr fields as it parses each WSL EA. If validation later fails, the function returns false with partially mutated fattr fields that callers do not reset. Fix this by parsing into local variables and only committing them to fattr on success. Closes: https://sashiko.dev/#/patchset/20260906200517.725015-1-pc%40manguebit.org Fixes: 78e26bec4d6d ("smb: client: parse uid, gid, mode and dev from WSL reparse points") Reviewed-by: Namjae Jeon Signed-off-by: Paulo Alcantara Cc: David Howells Cc: Tom Talpey Cc: Shyam Prasad N Cc: Ronnie Sahlberg Cc: Bharath SM Cc: Namjae Jeon Cc: stable@vger.kernel.org [ sashal: Kept cifs_sb->mnt_cifs_flags instead of cifs_sb_flags() for sbflags, and adjusted context because the old uid/gid/mode setup lines sit in a different order. ] Signed-off-by: Sasha Levin --- fs/smb/client/reparse.c | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c index ceddb4ec10ba1..bdc1322199026 100644 --- a/fs/smb/client/reparse.c +++ b/fs/smb/client/reparse.c @@ -680,29 +680,30 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data, u32 tag, struct cifs_fattr *fattr) { unsigned int sbflags = cifs_sb->mnt_cifs_flags; + kuid_t uid = cifs_sb->ctx->linux_uid; + kgid_t gid = cifs_sb->ctx->linux_gid; struct smb2_file_full_ea_info *ea; bool have_xattr_dev = false; + dev_t rdev = 0; + umode_t mode; u32 next = 0; - fattr->cf_mode &= ~S_IFMT; - fattr->cf_uid = cifs_sb->ctx->linux_uid; - fattr->cf_gid = cifs_sb->ctx->linux_gid; - + mode = fattr->cf_mode & ~S_IFMT; switch (tag) { case IO_REPARSE_TAG_LX_SYMLINK: - fattr->cf_mode |= S_IFLNK; + mode |= S_IFLNK; break; case IO_REPARSE_TAG_LX_FIFO: - fattr->cf_mode |= S_IFIFO; + mode |= S_IFIFO; break; case IO_REPARSE_TAG_AF_UNIX: - fattr->cf_mode |= S_IFSOCK; + mode |= S_IFSOCK; break; case IO_REPARSE_TAG_LX_CHR: - fattr->cf_mode |= S_IFCHR; + mode |= S_IFCHR; break; case IO_REPARSE_TAG_LX_BLK: - fattr->cf_mode |= S_IFBLK; + mode |= S_IFBLK; break; } @@ -726,26 +727,29 @@ static bool wsl_to_fattr(struct cifs_open_info_data *data, if (!strncmp(name, SMB2_WSL_XATTR_UID, nlen)) { if (!(sbflags & CIFS_MOUNT_OVERR_UID)) - fattr->cf_uid = wsl_make_kuid(cifs_sb, v); + uid = wsl_make_kuid(cifs_sb, v); } else if (!strncmp(name, SMB2_WSL_XATTR_GID, nlen)) { if (!(sbflags & CIFS_MOUNT_OVERR_GID)) - fattr->cf_gid = wsl_make_kgid(cifs_sb, v); + gid = wsl_make_kgid(cifs_sb, v); } else if (!strncmp(name, SMB2_WSL_XATTR_MODE, nlen)) { /* File type in reparse point tag and in xattr mode must match. */ - if (S_DT(fattr->cf_mode) != S_DT(get_unaligned_le32(v))) + if (S_DT(mode) != S_DT(get_unaligned_le32(v))) return false; - fattr->cf_mode = (umode_t)get_unaligned_le32(v); + mode = get_unaligned_le32(v); } else if (!strncmp(name, SMB2_WSL_XATTR_DEV, nlen)) { - fattr->cf_rdev = reparse_mkdev(v); + rdev = reparse_mkdev(v); have_xattr_dev = true; } } while (next); out: - /* Major and minor numbers for char and block devices are mandatory. */ if (!have_xattr_dev && (tag == IO_REPARSE_TAG_LX_CHR || tag == IO_REPARSE_TAG_LX_BLK)) return false; + fattr->cf_uid = uid; + fattr->cf_gid = gid; + fattr->cf_mode = mode; + fattr->cf_rdev = rdev; return true; } -- 2.53.0