From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795035567; b=csmc47Y6DPePucR1KGVzwWlUlkXOVZPi4P5cNhOGw5BnfbzQu8+GinbpX4SHkiXkVg6R TgOJGMTShpVZp0GCNfQhKGTImC6z0pKpPg2G8zf7syen98AedGI5nu7M7UunFHCorQzTz 0Xc2BUTuImFIPcx8iiUJK9/qT91WfrLYa1IUyOJxrGruxK9nRrW0pVgVRaUFn/7Lx/Irv I4vNECJbfMgCHLpDUN2t7qqrCrZaCyPtfJ7KUnCbQWeHjBRtB+CxutwX2648zp4gsVR8x p76o4jkVy0L5a65BJi+5bES2IRZ7f2kNgQMYmvTZbnjon1KiSjXmQd+vpooCVKOvdyQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795035567; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=FSzCmdrCB7/BkH2D/aON7+3Rj6TLCSgNOaWdejHs3ys=; b=NT/XFSkeacZRuJioB0oqw0bVcdg4fbBmdiSokXaIWYgQjNoNEE569TU2jc3YDuFaI6AP U1Q3BSNVYnSHRZ7qR2NnbtcXQ88xiwg6lsGNUUCRJzu98Ve9HJ+wOIk20uSoMfqWKD1mQ 5w/hn/CJPkceud19vee0qVWYHNpmwsWCd/YgMjwROJ6I8nZm9MXIhHacFhweFL44TBL5b gZCy50umRkcEt3pUQfp5//b/7JBIpkeRI9Sr+JIDzmFs46y6v8aMx3ie8p3edQuz9+o0g zgdsLLJRzf64EuBA2L2VB6MYQTTnyFDKLVNXl3d6L6M4ZehLrbNxt3F9i94tTG2Dg2Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=QMy2jfqZ; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CC9B606A325; Wed, 18 Nov 2026 20:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=QMy2jfqZ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 726571F000C4; Wed, 18 Nov 2026 20:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795035567; bh=FSzCmdrCB7/BkH2D/aON7+3Rj6TLCSgNOaWdejHs3ys=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QMy2jfqZucKdoq8bnl16lwUrOXyv2PcoG/XylJBwAU3EkIkGFOK4XqVkRIpKKb54v DECxH4rF3lfkMiUuhRFanrpN9jTTjL8wQMxkQecOeGS+2Sxx6Gxm6nfceYdLwvvbeX RR3z537274PARm4TDPBRouc01cXATfF1UkWPUoio= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?J=C3=A9r=C3=A9my=20Jean?= , "Mayank Jangid (OpenSec Intelligence)" , Chuck Lever Subject: [PATCH 6.6 0694/3318] nfsd: preflight SEQUENCE replies before accepting a slot Date: Wed, 18 Nov 2026 15:21:56 +0100 Message-ID: <20261118150339.119755564@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jérémy Jean commit 35ff1a7a7e3835c3e974bc5c45d335897564ceae upstream. nfsd4_sequence() narrows the reply buffer to the session's cached reply limit before it accepts the slot seqid. A client may negotiate ca_maxresponsesize_cached down to NFSD_MIN_HDR_SEQ_SZ, and nfsd4_alloc_slot() then gives every slot a zero-length sl_data[]. A COMPOUND tag can fill that narrowed buffer until it holds the SEQUENCE opcode but not the status word that follows. nfsd4_encode_operation() returns without running nfsd4_encode_sequence(), so cstate.data_offset stays zero. It leaves op->status at nfs_ok as well, so the COMPOUND is treated as having succeeded. nfsd4_store_cache_entry() declines to cache a lone SEQUENCE that returned an error. That test reads the status the operation reported, so it passes here. The copy starts at offset zero and takes the whole reply, RPC and COMPOUND headers included, into the zero-length sl_data[]. The COMPOUND tag is copied along with it, so the client picks most of the bytes written past the end of the slot: BUG: KASAN: slab-out-of-bounds in read_bytes_from_xdr_buf+0x1bc/0x390 Write of size 80 at addr ffff888003a549cd by task kunit_try_catch/24 __asan_memcpy+0x38/0x60 read_bytes_from_xdr_buf+0x1bc/0x390 nfsd4_sequence_done+0x5b0/0x810 nfs4svc_encode_compoundres+0x1bf/0x240 Check that the fixed-size SEQUENCE result, plus room for a following operation's error status, fits the negotiated limit before narrowing the buffer and consuming the slot seqid. The slot and its reply cache are left unchanged, as RFC 8881 Section 2.10.6.1.2 requires of an error returned from SEQUENCE. Fixes: 47ee52986472 ("nfsd4: adjust buflen to session channel limit") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5 Signed-off-by: Jérémy Jean Tested-by: Mayank Jangid (OpenSec Intelligence) Link: https://patch.msgid.link/20260817-jean-v1-1-9e356596ab85@kernel.org Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4state.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -4068,6 +4068,7 @@ __be32 nfsd4_sequence(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, union nfsd4_op_u *u) { + struct nfsd4_compoundargs *args = rqstp->rq_argp; struct nfsd4_sequence *seq = &u->sequence; struct nfsd4_compoundres *resp = rqstp->rq_resp; struct xdr_stream *xdr = resp->xdr; @@ -4077,6 +4078,7 @@ nfsd4_sequence(struct svc_rqst *rqstp, s struct nfsd4_conn *conn; __be32 status; int buflen; + u32 maxlen, respsize; struct net *net = SVC_NET(rqstp); struct nfsd_net *nn = net_generic(net, nfsd_net_id); @@ -4148,7 +4150,22 @@ nfsd4_sequence(struct svc_rqst *rqstp, s session->se_fchannel.maxresp_sz; status = (seq->cachethis) ? nfserr_rep_too_big_to_cache : nfserr_rep_too_big; - if (xdr_restrict_buflen(xdr, buflen - rqstp->rq_auth_slack)) + if (buflen < rqstp->rq_auth_slack) + goto out_put_session; + maxlen = buflen - rqstp->rq_auth_slack; + + /* + * A SEQUENCE result too large for maxlen never reaches + * nfsd4_encode_sequence(), so cstate.data_offset stays zero and + * the reply cache overruns the slot. + */ + respsize = nfsd4_max_reply(rqstp, &args->ops[0]); + if (!nfsd4_last_compound_op(rqstp)) + respsize += COMPOUND_ERR_SLACK_SPACE; + if (xdr->buf->len + respsize > maxlen) + goto out_put_session; + + if (xdr_restrict_buflen(xdr, maxlen)) goto out_put_session; svc_reserve(rqstp, buflen);