From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795035942; b=uW443Gpa+jIiyKv1opD+KLgg8FbsWJHY22Pvi/9NFNLX+v1zRs/6JMMC0YVZict3jjY8 YwXXZBAUUOfaG+/Mkll+wrk8jq/Mohe3Cht6KL2s0CME/iB4W4KAdE+wGIIGOO7/sx/Or SDzOwWbsPNksarUQRBuDXfBeqwu3CefEVddDGdlHDv7Ai9rcLaPh0fc2Xpl+Asvf0LTk+ EHaudfjgMQd1m4IEvQzE1rG0u4Le7+LU1RjbWvFuRG0EGrWJET0au5nP/U0Q+WmBoIOYE SJx+l52KEgIOn6ikJLrgPcTQqLq/WKIBqK5s0xQXiKyzA7KndbgxxqMsSAdBjPakRJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795035942; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=nJMfDkcjACYQuy6pz3KcKdipuSEPR5xUWJiQ5sDy9gE=; b=4+doiaSjEMOtVQ58o+qRBoghpOTXbXHNsmPwX/Fz2p5yxOX+PPThmwHsppjtVhkAUTsI xAJ0mmc+Jy/KdtGTysbtiPZ2OQfyh/tugzgluzVN45B5nhzNZlc79ssGntX/lbR/Kb3WO SHw8YJ6+OMrs/wjy+iJciVQ2zxqqzval0B3qgwarwKe07rOHQRj2A5t4+jmp/XKucfV+v XzKOxU6VjS3FSSk9GCe3mVzPz9fp8T91TVx9GYC6rt3Dd4RfuutEca3x3PRN83ZONt7zy dySzPQm1rJ6sswitajDdrB7TwvY1jVFquqD8Pj7jc0FHYeH03/GOR1asfe2lJDKksIQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lJLkpENH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75723606A334; Wed, 18 Nov 2026 21:05:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lJLkpENH Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3ED01F000C4; Wed, 18 Nov 2026 21:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795035942; bh=nJMfDkcjACYQuy6pz3KcKdipuSEPR5xUWJiQ5sDy9gE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lJLkpENHFjpxurXPocQnd4JUmoSEEturUeoDYuSaSPBXt0U4qNpgbomu8Yio/I064 GVnvA/129ss9bkKi65xrirxljUjthsCkTut24MT45zOuUw7BnOa9rlYk4dCbUNuchx 7WBcXiLHxIkA7UDgP6FJyfEb1PsfREKNeihcSuMM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Farhad Alemi , Andi Shyti , Hans Verkuil , Sasha Levin Subject: [PATCH 6.6 0831/3318] media: cx231xx: Fix cleanup path on failure Date: Wed, 18 Nov 2026 15:24:13 +0100 Message-ID: <20261118150344.048852713@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andi Shyti [ Upstream commit 6e30287eaf3e41b86dfb86df3b811526693d74b4 ] If cx231xx_init_v4l2() fails the probe currently jumps to err_init, which only unregisters the V4L2 device. The analog devices and I2C resources are left registered while the driver state can be released. A subsequent driver bind attempts to create the same I2C mux channel links and triggers a warning when the existing "channel-0" link is encountered. The remaining devices may also access released driver state. This produces the following warning can't create symlink to channel 0 WARNING: drivers/i2c/i2c-mux.c:403 at i2c_mux_add_adapter+0xcd8/0xeb0 Call Trace: i2c_mux_add_adapter+0xcdc/0xeb0 cx231xx_dev_init+0x2fb/0x1260 cx231xx_usb_probe+0xc48/0x2140 usb_probe_interface+0x657/0xc70 ... Jump to err_video_alt instead, which performs the full device cleanup before unregistering the V4L2 device. Reported-by: Farhad Alemi Closes: https://github.com/farhad-alemi/public_bug_reports/tree/main/185-warning-in-i2c-mux-add-adapter/ Fixes: 4d2a7d3509f5 ("[media] cx231xx: move analog init code to a separate function") Signed-off-by: Andi Shyti Cc: # v3.17+ Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index 64c3cb8fc2bf0..623c3106ef3ee 100644 --- a/drivers/media/usb/cx231xx/cx231xx-cards.c +++ b/drivers/media/usb/cx231xx/cx231xx-cards.c @@ -1830,7 +1830,7 @@ static int cx231xx_usb_probe(struct usb_interface *interface, retval = cx231xx_init_v4l2(dev, udev, interface, isoc_pipe); if (retval) - goto err_init; + goto err_video_alt; if (dev->current_pcb_config.ts1_source != 0xff) { /* compute alternate max packet sizes for TS1 */ -- 2.53.0