From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795035835; b=sT8xxAG5wrd48rX60zShg4pz3fRtFzGqDiLPD8E7/Ux8Okm3JrwPYAiDunakFMtYKGtF lwua44exTwyH8E3TaAc6OOoI6yP8GAhTQoY00k3xfK52wPjr+/oHvFqnBpQp0uCmzJqCH GJW3N2X37tnxvptH+AUCvxysOdwLyawNgYxNl+j4vsOnG2th8z6OTi+Pftu4HjZo9LFHx 08hQApnkPnICJVWVi3YomCpG82k2DNAe0EB5gdU4jXczO9tz4OR+TpBLL22lODSutZfFN mg610UGqyTaQGvYhHMYUQ57qYlL0lasrlOqdsYfwW2CHY97joXRoi4gvefpYfzQDaHg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795035835; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=TXzfBhtAyydVXOY8+Aq+8QCuascxHlAK8kY/hF36Qf0=; b=5kUJZa2KTWleTm8iEUirrVyY1ZODG/wSrb08Ln6pYFtMtTJ+29lI9tlp2yV/4U5xSQAT 5v9wPzq4amm1TwUD4OGDoRP4RUzGTE1IjhY/fxFoaPUAco40tiU/ocos2cpjHktcMR21M 4jZqQrHk3WoYVuTj1TXkSexRAsD4ASyftm5QE5/+cc5VvOHSApXOjzDH1DWdMwLmigI3K TpZduYdPue98KB/Q8yywxDCcD+CC5K7YfzG4CCNPZL2wsW8Lyok5Cu/hWfktTCJNVWS5b hHKE5qC+0rwN59x1UMfaIiPzOPyXSODWQsWmB4xT8iLS8DnEVfAnr7Mh8VkiAfNnX4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=aYo0dYlm; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B41A606A31C; Wed, 18 Nov 2026 21:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=aYo0dYlm Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83CDF1F01573; Wed, 18 Nov 2026 21:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795035835; bh=TXzfBhtAyydVXOY8+Aq+8QCuascxHlAK8kY/hF36Qf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aYo0dYlm4aF7eYYtruoFxy8LItpcNu/kgvsaA9eTrFFe4Mvx3ciQPVeZdxZ/Hh4yD 5nY4wle9eOv2vx23lNCuuJZrKXDCh6RTkUu4x0voEgZxjkYAfcoeYL1JlP82GzNHJO SGjDLmHTZrwsIkJiT+wekGaSOtoM12vWb6fm3vqM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Balakrishnan Sambath , Eugen Hristev , Hans Verkuil , Sasha Levin Subject: [PATCH 6.6 0845/3318] media: microchip-isc: synchronize the IRQ before disabling clocks on stop Date: Wed, 18 Nov 2026 15:24:27 +0100 Message-ID: <20261118150344.535346095@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Balakrishnan Sambath [ Upstream commit 19fa5407da5ef3e605cacfcd90f70d8b2c121cd7 ] isc_stop_streaming() masks the DMA interrupt and then drops the runtime PM reference, which disables the ISC clocks. microchip_isc_interrupt() may still be executing on another CPU at that point; it reads ISC_INTSR over regmap, and touching the unclocked registers triggers an external abort. Store the IRQ number at probe and call synchronize_irq() after masking the interrupt, before dropping the PM reference. Fixes: 106267444f12 ("[media] atmel-isc: add the Image Sensor Controller code") Cc: stable@vger.kernel.org Signed-off-by: Balakrishnan Sambath Reviewed-by: Eugen Hristev Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/microchip/microchip-isc-base.c | 3 +++ drivers/media/platform/microchip/microchip-isc.h | 1 + drivers/media/platform/microchip/microchip-sama5d2-isc.c | 2 ++ drivers/media/platform/microchip/microchip-sama7g5-isc.c | 2 ++ 4 files changed, 8 insertions(+) diff --git a/drivers/media/platform/microchip/microchip-isc-base.c b/drivers/media/platform/microchip/microchip-isc-base.c index df3b36e9f7f25..608985499826e 100644 --- a/drivers/media/platform/microchip/microchip-isc-base.c +++ b/drivers/media/platform/microchip/microchip-isc-base.c @@ -425,6 +425,9 @@ static void isc_stop_streaming(struct vb2_queue *vq) /* Disable DMA interrupt */ regmap_write(isc->regmap, ISC_INTDIS, ISC_INT_DDONE); + /* let a running IRQ handler finish before the clock is disabled */ + synchronize_irq(isc->irq); + pm_runtime_put_sync(isc->dev); /* Disable stream on the sub device */ diff --git a/drivers/media/platform/microchip/microchip-isc.h b/drivers/media/platform/microchip/microchip-isc.h index ad4e98a1dd8fc..f5e322c2e36bc 100644 --- a/drivers/media/platform/microchip/microchip-isc.h +++ b/drivers/media/platform/microchip/microchip-isc.h @@ -287,6 +287,7 @@ struct isc_device { u32 dcfg; struct device *dev; + int irq; struct v4l2_device v4l2_dev; struct video_device video_dev; diff --git a/drivers/media/platform/microchip/microchip-sama5d2-isc.c b/drivers/media/platform/microchip/microchip-sama5d2-isc.c index 7cedfd29ac130..583d3c4dca54f 100644 --- a/drivers/media/platform/microchip/microchip-sama5d2-isc.c +++ b/drivers/media/platform/microchip/microchip-sama5d2-isc.c @@ -448,6 +448,8 @@ static int microchip_isc_probe(struct platform_device *pdev) if (irq < 0) return irq; + isc->irq = irq; + ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0, "microchip-sama5d2-isc", isc); if (ret < 0) { diff --git a/drivers/media/platform/microchip/microchip-sama7g5-isc.c b/drivers/media/platform/microchip/microchip-sama7g5-isc.c index 36f52ea38d55b..d2e1899869c43 100644 --- a/drivers/media/platform/microchip/microchip-sama7g5-isc.c +++ b/drivers/media/platform/microchip/microchip-sama7g5-isc.c @@ -437,6 +437,8 @@ static int microchip_xisc_probe(struct platform_device *pdev) if (irq < 0) return irq; + isc->irq = irq; + ret = devm_request_irq(dev, irq, microchip_isc_interrupt, 0, "microchip-sama7g5-xisc", isc); if (ret < 0) { -- 2.53.0