From: SJ Park <sj@kernel.org>
To: Yifan Feng <evanfengff@gmail.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval
Date: Wed, 18 Nov 2026 17:42:46 -0800 [thread overview]
Message-ID: <20261119014247.119946-1-sj@kernel.org> (raw)
In-Reply-To: <20261118235012.14859-1-evanfengff@gmail.com>
Hello Yifan,
On Wed, 18 Nov 2026 15:50:12 -0800 Yifan Feng <evanfengff@gmail.com> wrote:
> kdamond_wait_activation() cancels damos_walk() requests while all
> schemes are deactivated by their watermarks. But it returns without
> waiting when the watermarks check interval of a deactivated scheme is
> zero, which is the default of the DAMON sysfs interface. The kdamond
> main loop then runs with all schemes deactivated.
>
> In that state, kdamond_apply_schemes() finds no scheme to apply and
> returns before it calls damos_walk_complete(). The walk request is
> neither completed nor cancelled, so damos_walk() waits until the
> watermarks activate a scheme again, possibly forever.
>
> For example, with a scheme that has the free_mem_rate metric, zero
> interval_us and a high watermark below the current free memory rate,
> writing update_schemes_tried_regions to the kdamond state file never
> returns and cannot be killed. The writer holds damon_sysfs_lock, so all
> other DAMON sysfs writes including "off" fail with -EBUSY meanwhile.
Thank you for finding and sharing the issue.
>
> Do not skip the deactivated schemes when deciding whether
> kdamond_apply_schemes() has something to do. damon_do_apply_schemes()
> still skips them, so no action is applied, and the walk is completed
> with no region for them, as it already is when another scheme is
> activated.
>
> Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")
> Cc: <stable@vger.kernel.org> # 6.14.x
> Signed-off-by: Yifan Feng <evanfengff@gmail.com>
> ---
> QEMU: the write hangs before, returns after; kunit and 13 selftests pass on both (2 need drgn, not run).
> Found and written with the help of an AI coding assistant.
>
> mm/damon/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index b8678a53b0a9..12578fc3280c 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -3498,11 +3498,11 @@ static noinline_for_stack void kdamond_apply_schemes(struct damon_ctx *c)
> if (time_before(c->passed_sample_intervals, s->next_apply_sis))
> continue;
>
> + has_schemes_to_apply = true;
> +
> if (!s->wmarks.activated)
> continue;
>
> - has_schemes_to_apply = true;
> -
> damos_adjust_quota(c, s);
> }
But, this could make has_schemes_to_apply has false positive. How about
calling damos_Walk_cancel() when has_schemes_to_apply is false, like below?
'''
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -3849,8 +3849,10 @@ static noinline_for_stack void kdamond_apply_schemes(struct damon_ctx *c)
damos_adjust_quota(c, s);
}
- if (!has_schemes_to_apply)
+ if (!has_schemes_to_apply) {
+ damos_walk_cancel(c);
return;
+ }
max_region_sz = damon_region_sz_limit(c);
mutex_lock(&c->walk_control_lock);
'''
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-11-19 1:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 23:50 [PATCH] mm/damon/core: fix damos_walk() hang with zero watermarks interval Yifan Feng
2026-11-19 1:42 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119014247.119946-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=evanfengff@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox