Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: silverducks@altlinux.org
To: linux-gpio@vger.kernel.org
Cc: Mika Westerberg <westeri@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-acpi@vger.kernel.org, stable@vger.kernel.org,
	Pavel Petrykin <silverducks@altlinux.org>
Subject: [PATCH v2] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX
Date: Thu, 19 Nov 2026 15:28:45 +0300	[thread overview]
Message-ID: <20261119122844.445945-2-silverducks@altlinux.org> (raw)
In-Reply-To: <20261119083813.390337-1-silverducks@altlinux.org>

From: Pavel Petrykin <silverducks@altlinux.org>

The firmware's _AEI table on the Gigabyte B650 GAMING X AX declares AMD
GPIO pin 3 as GpioInt(Edge, ActiveLow, ExclusiveAndWake). gpiolib-acpi
requests it as "ACPI:Event" and amd_gpio_irq_set_wake() arms the hardware
S3 wake bit for that pin. The firmware then sends the signal a few seconds
after entering S3, so the machine resumes on it's own six to ten seconds
after suspend.

Pin 3 is the only wake signal the OS can see for the whole GPP7 PCIe
domain, and GPP7 has no _PRW, so ignoring this wake flag is the only way to
keep S3 reliable on this board. Wake from USB keyboards/mouse and
Wake-on-LAN through that domain is lost as a consequence, but I figure S3
not working at all is worse. The power button still wakes the machine as
normal.

Signed-off-by: Pavel Petrykin <silverducks@altlinux.org>
---
v2 - Put real name in signoff; Moved testing information to comment.

Quirk tested on upstream kernel v7.4-rc2.  Also tested on stable kernel
v6.12, which is the version where the issue was originally diagnosed.

 drivers/gpio/gpiolib-acpi-quirks.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi-quirks.c b/drivers/gpio/gpiolib-acpi-quirks.c
index 3f89a87601c1..5455784e67c2 100644
--- a/drivers/gpio/gpiolib-acpi-quirks.c
+++ b/drivers/gpio/gpiolib-acpi-quirks.c
@@ -465,6 +465,23 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "GTCH7503:00@10",
 		},
 	},
+	{
+		/*
+		 * Spurious wake from S3: the firmware _AEI table declares AMD GPIO
+		 * pin 3 (GPP7 group) as Edge/ActiveLow ExclusiveAndWake, so gpiolib-acpi
+		 * requests it as ACPI:Event and amd_gpio_irq_set_wake() arms the
+		 * hardware S0i3/S3 wake bit. The firmware asserts this signal during
+		 * S3 entry regardless of the PCI wake sources configured by the OS,
+		 * waking the machine a few seconds after suspend.
+		 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Gigabyte Technology Co., Ltd."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "B650 GAMING X AX"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "AMDI0030:00@3",
+		},
+	},
 	{} /* Terminating entry */
 };
 
-- 
2.50.1


      parent reply	other threads:[~2026-11-19 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:38 [PATCH] gpiolib: acpi: Add ignore_wake quirk for Gigabyte B650 GAMING X AX silverducks
2026-11-19 11:45 ` Andy Shevchenko
2026-11-19 12:28 ` silverducks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119122844.445945-2-silverducks@altlinux.org \
    --to=silverducks@altlinux.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox