Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Nico Pache (Red Hat)" <nico.pache@linux.dev>
To: linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	 "Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	 Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	 Tianyi Chen <hi@tychen.cc>,
	stable@vger.kernel.org,
	 "Nico Pache (Red Hat)" <nico.pache@linux.dev>
Subject: [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment
Date: Sun, 22 Nov 2026 11:50:36 -0700	[thread overview]
Message-ID: <20261122-vm_selftests_items_fix-v1-1-9edef5e7975d@linux.dev> (raw)

The unconditional default assignment overwrites VM_SELFTEST_ITEMS from
the environment. This regresses environments that use the variable to
select test groups: without -t, all default test categories run instead
of the requested groups. The -t option continues to override it.

Fixes: 4844f5b84a8e ("selftests/mm: reject invalid test selections before running tests")
Cc: stable@vger.kernel.org
Signed-off-by: Nico Pache (Red Hat) <nico.pache@linux.dev>
---
 tools/testing/selftests/mm/run_vmtests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index a1b45a3dedae..aa63f840cf60 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -102,7 +102,7 @@ RUN_ALL=false
 RUN_DESTRUCTIVE=false
 TAP_PREFIX="# "
 
-VM_SELFTEST_ITEMS="default"
+: "${VM_SELFTEST_ITEMS:=default}"
 
 while getopts "aht:nd" OPT; do
 	case ${OPT} in

---
base-commit: 2dc60bd9975fc8666a13d58410499e06e6799ba9
change-id: 20261122-vm_selftests_items_fix-f118ab78426e

Best regards,
--  
Nico Pache (Red Hat) <nico.pache@linux.dev>


             reply	other threads:[~2026-11-22 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22 18:50 Nico Pache (Red Hat) [this message]
2026-11-22 19:02 ` [PATCH] selftests/mm: honor VM_SELFTEST_ITEMS from the environment Andrew Morton
2026-11-22 19:15   ` Nico Pache

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122-vm_selftests_items_fix-v1-1-9edef5e7975d@linux.dev \
    --to=nico.pache@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=hi@tychen.cc \
    --cc=liam@infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox