Re: [PATCH] accel/ivpu: Reorder doorbell unregister and command queue destruction

["Falkowski, Maciej" <maciej.falkowski@linux.intel.com>]

On 6/4/2025 6:18 PM, Jeff Hugo wrote:

> On 6/4/2025 9:44 AM, Maciej Falkowski wrote:
>> From: Karol Wachowski <karol.wachowski@intel.com>
>>
>> Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered
>> before destroying the command queue. The NPU firmware requires doorbells
>> to be unregistered prior to command queue destruction.
>>
>> If doorbell remains registered when command queue destroy command is 
>> sent
>> firmware will automatically unregister the doorbell, making subsequent
>> unregister attempts no-operations (NOPs).
>>
>> Ensure compliance with firmware expectations by moving the doorbell
>> unregister call ahead of the command queue destruction logic,
>> thus preventing unnecessary NOP operation.
>>
>> Fixes: 2a18ceff9482 ("accel/ivpu: Implement support for hardware 
>> scheduler")
>> Cc: <stable@vger.kernel.org> # v6.11+
>> Signed-off-by: Karol Wachowski <karol.wachowski@intel.com>
>> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> Huh?  This was posted to the list on May 15th, and Jacek applied it to 
> drm-misc-fixes on May 28th.
My apologies, you are right. I accidentally included it while checking 
latest changes.

Best regards,
Maciej
>
> -Jeff