* [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx
@ 2025-07-25 14:49 edip
2025-07-25 14:57 ` Edip Hazuri
0 siblings, 1 reply; 5+ messages in thread
From: edip @ 2025-07-25 14:49 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-sound, linux-kernel, Edip Hazuri, stable
From: Edip Hazuri <edip@medip.dev>
The mute led on this laptop is using ALC245 but requires a quirk to work
This patch enables the existing quirk for the device.
Tested on Victus 16-r1xxx Laptop. The LED behaviour works
as intended.
v2:
- adapt the HD-audio code changes and rebase on for-next branch of tiwai/sound.git
- link to v1: https://lore.kernel.org/linux-sound/20250724210756.61453-2-edip@medip.dev/
Cc: <stable@vger.kernel.org>
Signed-off-by: Edip Hazuri <edip@medip.dev>
---
sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 05019fa73..33ef08d25 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6580,6 +6580,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8c91, "HP EliteBook 660", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8c97, "HP ZBook", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8c99, "HP Victus 16-r1xxx (MB 8C99)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
SND_PCI_QUIRK(0x103c, 0x8c9c, "HP Victus 16-s1xxx (MB 8C9C)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
SND_PCI_QUIRK(0x103c, 0x8ca1, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ca2, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx
2025-07-25 14:49 [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx edip
@ 2025-07-25 14:57 ` Edip Hazuri
0 siblings, 0 replies; 5+ messages in thread
From: Edip Hazuri @ 2025-07-25 14:57 UTC (permalink / raw)
To: perex, tiwai, edip; +Cc: linux-sound, linux-kernel, Edip Hazuri, stable
On Friday, July 25, 2025 5:49:12 PM GMT+03:00 edip@medip.dev wrote:
> From: Edip Hazuri <edip@medip.dev>
>
> The mute led on this laptop is using ALC245 but requires a quirk to work
> This patch enables the existing quirk for the device.
>
> Tested on Victus 16-r1xxx Laptop. The LED behaviour works
> as intended.
>
> v2:
> - adapt the HD-audio code changes and rebase on for-next branch of
> tiwai/sound.git - link to v1:
> https://lore.kernel.org/linux-sound/20250724210756.61453-2-edip@medip.dev/
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Edip Hazuri <edip@medip.dev>
> ---
> sound/hda/codecs/realtek/alc269.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c
> b/sound/hda/codecs/realtek/alc269.c index 05019fa73..33ef08d25 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6580,6 +6580,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8c91, "HP EliteBook 660",
> ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c96, "HP",
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), SND_PCI_QUIRK(0x103c, 0x8c97, "HP
> ZBook", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), + SND_PCI_QUIRK(0x103c,
> 0x8c99, "HP Victus 16-r1xxx (MB 8C99)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
> SND_PCI_QUIRK(0x103c, 0x8c9c, "HP Victus 16-s1xxx (MB 8C9C)",
> ALC245_FIXUP_HP_MUTE_LED_COEFBIT), SND_PCI_QUIRK(0x103c, 0x8ca1, "HP ZBook
> Power", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8ca2, "HP ZBook
> Power", ALC236_FIXUP_HP_GPIO_LED),
I'm so sorry, I forgot to fix the subject.
I'll fix it now
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx
@ 2025-07-24 21:07 edip
2025-07-25 7:13 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: edip @ 2025-07-24 21:07 UTC (permalink / raw)
To: perex, tiwai; +Cc: linux-sound, linux-kernel, Edip Hazuri, stable
From: Edip Hazuri <edip@medip.dev>
The mute led on this laptop is using ALC245 but requires a quirk to work
This patch enables the existing quirk for the device.
Tested on Victus 16-r1xxx Laptop. The LED behaviour works
as intended.
Cc: <stable@vger.kernel.org>
Signed-off-by: Edip Hazuri <edip@medip.dev>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 2627e2f49..9656e6ebb 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10874,6 +10874,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8c91, "HP EliteBook 660", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8c96, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8c97, "HP ZBook", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8c99, "HP Victus 16-r1xxx (MB 8C99)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
SND_PCI_QUIRK(0x103c, 0x8c9c, "HP Victus 16-s1xxx (MB 8C9C)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
SND_PCI_QUIRK(0x103c, 0x8ca1, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ca2, "HP ZBook Power", ALC236_FIXUP_HP_GPIO_LED),
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx
2025-07-24 21:07 edip
@ 2025-07-25 7:13 ` Takashi Iwai
2025-07-25 14:38 ` Edip Hazuri
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2025-07-25 7:13 UTC (permalink / raw)
To: edip; +Cc: perex, tiwai, linux-sound, linux-kernel, stable
On Thu, 24 Jul 2025 23:07:56 +0200,
edip@medip.dev wrote:
>
> From: Edip Hazuri <edip@medip.dev>
>
> The mute led on this laptop is using ALC245 but requires a quirk to work
> This patch enables the existing quirk for the device.
>
> Tested on Victus 16-r1xxx Laptop. The LED behaviour works
> as intended.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Edip Hazuri <edip@medip.dev>
The HD-audio code was relocated and split to different files recently
(for 6.17 kernel), e.g. this Realtek codec is now located in
sound/hda/codecs/realtek/alc269.c.
As I already closed the changes for 6.16 and it'll be put for
6.17-rc1, could you rebase on for-next branch of sound.git tree and
resubmit?
thanks,
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx
2025-07-25 7:13 ` Takashi Iwai
@ 2025-07-25 14:38 ` Edip Hazuri
0 siblings, 0 replies; 5+ messages in thread
From: Edip Hazuri @ 2025-07-25 14:38 UTC (permalink / raw)
To: tiwai; +Cc: edip, linux-kernel, linux-sound, perex, stable, tiwai
On Friday, July 25, 2025 10:13:38 AM GMT+03:00 Takashi Iwai wrote:
> On Thu, 24 Jul 2025 23:07:56 +0200,
>
> edip@medip.dev wrote:
> > From: Edip Hazuri <edip@medip.dev>
> >
> > The mute led on this laptop is using ALC245 but requires a quirk to work
> > This patch enables the existing quirk for the device.
> >
> > Tested on Victus 16-r1xxx Laptop. The LED behaviour works
> > as intended.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Edip Hazuri <edip@medip.dev>
>
> The HD-audio code was relocated and split to different files recently
> (for 6.17 kernel), e.g. this Realtek codec is now located in
> sound/hda/codecs/realtek/alc269.c.
>
> As I already closed the changes for 6.16 and it'll be put for
> 6.17-rc1, could you rebase on for-next branch of sound.git tree and
> resubmit?
>
>
> thanks,
>
> Takashi
Hi
I'll rebase and resubmit it as soon as possible
Thank you
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-25 14:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25 14:49 [PATCH] ALSA: hda/realtek - Fix mute LED for HP Victus 16-r1xxx edip
2025-07-25 14:57 ` Edip Hazuri
-- strict thread matches above, loose matches on Subject: below --
2025-07-24 21:07 edip
2025-07-25 7:13 ` Takashi Iwai
2025-07-25 14:38 ` Edip Hazuri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox