From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 085F7375F8B for ; Mon, 4 May 2026 10:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889313; cv=none; b=uCopJ81pEV6/fzwfkU0pSXwC8ctJZRL7vmv3hnCSQqGSeJLLkm1rb6wgTfsXuwbT4MBpoDBOYYHnk6JY+sw2nc0GL/0v+clyeNUiigwDf57hWbjlRB0hC+l4Vr0bDOA6EyoXOVK0zH0VCL8L1Vm/gbJBFeIhWE12NCn8N7wpIqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889313; c=relaxed/simple; bh=pcbrlB3qHsPLc/y90rnx1LrG5b7iFx58tWFuf97lMZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fa3Gngj4nyyGuqF9yhn5YQouoNqiTTdc6FvX8JSo2vcVRHcf0RLatEAN5/uBq7apRUNBrykAnlD1HilV7OCCLob/q4qDk5CxPRDx+m0MHe9ZkDlK6w4tm0hgfcr5zSuyznleuQVAb70uxW1NAY5P90UebILbealo5rdoyzHNzv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XFfYAGX0; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XFfYAGX0" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-59dcdf60427so3416395e87.3 for ; Mon, 04 May 2026 03:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889308; x=1778494108; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=XFfYAGX0vIXPtCpbsD4kyc5I2cT9bBLjwffoBl7nKkEYnuDfT+/UjNRGrfv89lms2K 7eyrxDHX8Gcxs5dx51ho+nsrojwAKrkJfO/KhpdaRtbkeCXxZv+CmSsAXvdIW9+LdRxn s4v6VrLECqUGSil46WyoJr3kGErya9ef/uKcEKkDnvm1dUQoGmMg+j3cH87L9iu1Hfjx 18PXCmttSPiSHPAekzGw9oLN784QFfvh2mRPeSTvkHKHuw8qy/NEHzb61aCdovwovbh8 AdevJy/CpEDkvwW58p1WPz5i6+yoOvnB4dcsRUf8NuUvYLQHyyMAm60PWONEPFInPmCd Xf8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889308; x=1778494108; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=rK4gunszNev7wLXqSVfNxd0SWBMV8QA6ZVq5IcghgKGMk06RZBPyAs8F49hKYRITyH fp95iYrgbdnLpBIrcU0zS4V5A6qZ4kPOHCh1TJH+7dvTDpDloJqUen5pJiQre4S8qFlf WmTQSYFgfJmmUnsMeSDFkn+7tSoPm6cATdtHeSZdS2XJphhsNIYRf+njOA7Fmua/0or6 /KZpl47HFg/F6lJOxin9swtXsRQqrgMP+oPEU84isPNoXanIdowOG5Yf0DEgbrkL3KD6 NoswVSlE7DR7o8NyEH8WomBhTboPQtXGdnBUzPACXBicqTQwotmGIok59nXUvqCt4qoi 6efQ== X-Gm-Message-State: AOJu0YyOmG/RjYwd31vUCSpPzIeFbrG0dBCbca5yh13fAYyhEQkTwG90 U1HrYAMBkuZ4SAjSmf2Lkr4KRf8Z0LeAhHkfGXWnUTXiiwsZo9ktxpt2 X-Gm-Gg: AeBDieujLkjfO8EzV0J4Jf4VFiu96OXm2QF7yJ8LO1oqpLwSWqcmBXAtNcfmrYOD6HO S30oEfjo2cgnB01ZgzM2MLeXyiPbBwb2Sjn1OZuIyGReRFZH1hf0l9hJM7hMd7lJtuRyNSikVVL HddQU1b2mZGGZXCf+dvm96k1D5cCZ1asM+wLLDEWqs65YHJYDa8JbEoaBrwMD6Z/wG7Q9nllpXC OIoDkcdqjN570x8jojGNlrjqS197j4XealdJGtoWgwrx2mVcqpe+gNddzZgJ9zJTlQY3zBTjfpI 50op1zp5pAipA13gd6+HFjAwFC1cvpZbDDdEYjT/Ra3viRx8YYTZ3BGsOnu5QwI0sgvkMBkNUAR kgJ0X923zPlFh7aOKm4j/9vQyzC+m4Pqrbtc5c4uwZwpsanoSjUC5HETeOdLvzs1wUgc9W1aljC /ZNyvaJBxyptrgUOtJFd2B+ILObomkJiorNg9B4FFs2xxbK3E/3H2Hr0EzNDvTrMwOq84/q18= X-Received: by 2002:a05:6512:3f08:b0:5a3:f305:a50f with SMTP id 2adb3069b0e04-5a8631bdfafmr2578178e87.30.1777889307519; Mon, 04 May 2026 03:08:27 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c33c2ecsm2856217e87.42.2026.05.04.03.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:08:27 -0700 (PDT) From: Vastargazing To: vebohr@gmail.com Cc: stable@vger.kernel.org Subject: [PATCH 4/5] perf: arm: pmu: fix reference leak on failed device registration Date: Mon, 4 May 2026 13:08:19 +0300 Message-ID: <243cb3737b41fae32a09117c17809a210395e69f.1777889235.git.vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in arm_acpi_register_pmu_device(), the embedded struct device has already been initialized by device_initialize() inside platform_device_register(). The error path unregisters the GSI interrupt but returns without dropping the device reference: arm_acpi_register_pmu_device() -> platform_device_register(pdev) -> device_initialize(&pdev->dev) /* kref = 1 */ -> platform_device_add(pdev) /* fails */ <- acpi_unregister_gsi() called, but kref still 1 Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() in the error branch before unregistering the GSI. Fixes: d24a0c7099b3 ("arm_pmu: acpi: spe: Add initial MADT/SPE probing") Cc: stable@vger.kernel.org Assisted-by: GitHub Copilot (Claude Sonnet 4.5) Signed-off-by: Vastargazing --- drivers/perf/arm_pmu_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c index e80f76d95e68..c2defbc32ad9 100644 --- a/drivers/perf/arm_pmu_acpi.c +++ b/drivers/perf/arm_pmu_acpi.c @@ -119,8 +119,10 @@ arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, pdev->resource[0].start = irq; ret = platform_device_register(pdev); - if (ret) + if (ret) { + platform_device_put(pdev); acpi_unregister_gsi(gsi); + } return ret; } -- 2.51.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C118390995 for ; Mon, 4 May 2026 10:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889343; cv=none; b=Hcey5sYcm6jnAUE6IeL6BUPKNGFuHgOgNhD/cIfAqACmT2/RIdUzKGCbxRMj6TMb6pnc9ol+Z7mKLTohH1OQ/bUWNNMsXA40FRKRveUBTcEG8P83F5frEpgl3Dqc0qZOD8hSEb9cta8UbhhHg0iqqQGis1R5C1B7QC/pUW1lw4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889343; c=relaxed/simple; bh=pcbrlB3qHsPLc/y90rnx1LrG5b7iFx58tWFuf97lMZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iAh9ABs0/qo+SucsvU6B597sdkGMtC4iNFFIPbDK1Udv3LC1lfsTNu6wHG1OEldYfOjYEzWAVIH8TYSqLx7//Ok66Hq6o6Gd+NftQvwhT1A7irWyrTrJhCqppzLx95eGhbqZKqZPlGLyKt5m5Zjri2LJUjSbUQ9y51sOkqUJaLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cKW7JyjX; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cKW7JyjX" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5a748d5ece4so4262510e87.2 for ; Mon, 04 May 2026 03:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889335; x=1778494135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=cKW7JyjXHGgh6mBa2l2a8jd40EAX5sw0SGAXxqQFYZFMqJLhudJJTojaBfnSJUqbOj w5BjRfybVM9L6dC7Jn/+Fkr4jsvL2/n2vqEB2P7MnRuuvnPtdWQzhptnWBVXuNYPbuap QOJY22o9bjxeYQ/k7Ftl21S5SQ1yv2kvkR9XDaWmQ+OhGLe/1p1jd9Cvc76vGcZa4TVq ZXdrTu0iXq7rlQK6IXjslucJviAi+WgrTlB31XjBOeAUXeJmsfXDuilGkZhliM4+ZHmW a/LNpYwKlfvwxDEX4MWlQRzxFzDLQPJ6R5LzP0Vjdc6prrrAnhzAaLdwOo1bmt5U1+0P STxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889335; x=1778494135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=sGLCoB6rh4xWpmI9c58GVOjlkTo7yYl4YWUgiy6y5jH398umUn4IRPlb7to2jeB/Of +ZCWm2YXoA2MEzOMuPQQAeAg68XqSjrXiVPOjJO+xA0zQAGEvl9GOrEWPcvRdCKGHJXA DUthcSAEx6UIkyDpujpqjCwNmA+t2O469GvgUjWF/3H0ni3VhfMcE9G9r0ltGod0pKkz 2Ry2sa9O22GG6mF3ilU5lnyGXZHYGlUKH35trHUglaGITaF6jEVrJfeX+W9E8+kUUNc3 yXFuxigtUk4HmafCQIdnpUJcNEyBLsEgQuEHrL8oINc/enMnxPqg3ioxqGEN/TE1O3ec lptg== X-Forwarded-Encrypted: i=1; AFNElJ+q8h2HE+B/6sHv+QmFubPDmwmQHuvgLHv9QCt1P+ssz5XharyTl5X4KSl8YasYvN8/o9vVqTI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2lMjDB3/087ZjZ2GbPDnArJRyDkrlhjrqeKlnPXhmWXKEQdLd xxqmLSWudhskb9miVb8gkTpzzG34JvizO1IMwgeBFjPv/n7tIEd7crtC X-Gm-Gg: AeBDietqL8TYOlBfJ/wRoCGuZ+TqYCFtU8Kqw42JAUn73ImpS/SunuB8UJIuUnj0LqA puKFq8Kby2qaSIMkLtGuv3OTYO65k/p5y75jKnfVYUPZ2sAL10VpWI/4ZxtWF3QkCrXjFM2Bxs3 mKjAzCkxa+IbDuJ79RecJQ5aDSHuU3eaEVB+nAgoF/CB9hQRgz9ktYGET8Sh+moJz2Kwj+dSF6h tod0b1y+2RPpQs4r/vUXOuqHRMlwRpIUmlG8aFjelA5veTf5za7ZvksjIC78eMhptN1X988KBbR dLHKmTWMDkrBWjc45Y7WQOv1IOFA/MfNgf3UQk9CWTSUlG49SiXgWbIRwibB/pxXlWzpObd51Tl eIQS79B7uNJgBYZRM0luJPl/Env2kIO0wQAKOd6i2wo5LxY0qVU8ucpa0KdLLXflOEiysUAsDH5 bh3PHPzCLe6lxXy9h3TVx5g9L+4lA5ZP0R496CN/8cdd8lQVUYL7OjkjjGrXkoVpo2GNogUdA= X-Received: by 2002:a05:6512:3c8a:b0:5a8:6ba2:225a with SMTP id 2adb3069b0e04-5a86ba22265mr1869874e87.39.1777889335210; Mon, 04 May 2026 03:08:55 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a86645ae7csm1979099e87.79.2026.05.04.03.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:08:54 -0700 (PDT) From: Vastargazing To: linux-kernel@vger.kernel.org Cc: Vastargazing , stable@vger.kernel.org, Will Deacon , Mark Rutland , Jeremy Linton , Sudeep Holla , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: [PATCH 4/5] perf: arm: pmu: fix reference leak on failed device registration Date: Mon, 4 May 2026 13:08:46 +0300 Message-ID: <243cb3737b41fae32a09117c17809a210395e69f.1777889235.git.vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID: <20260504100846.y1iibQnZqcSsj6oRIP9vHscTKwVgqyv9X6kNoKe4PiQ@z> When platform_device_register() fails in arm_acpi_register_pmu_device(), the embedded struct device has already been initialized by device_initialize() inside platform_device_register(). The error path unregisters the GSI interrupt but returns without dropping the device reference: arm_acpi_register_pmu_device() -> platform_device_register(pdev) -> device_initialize(&pdev->dev) /* kref = 1 */ -> platform_device_add(pdev) /* fails */ <- acpi_unregister_gsi() called, but kref still 1 Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() in the error branch before unregistering the GSI. Fixes: d24a0c7099b3 ("arm_pmu: acpi: spe: Add initial MADT/SPE probing") Cc: stable@vger.kernel.org Assisted-by: GitHub Copilot (Claude Sonnet 4.5) Signed-off-by: Vastargazing --- drivers/perf/arm_pmu_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c index e80f76d95e68..c2defbc32ad9 100644 --- a/drivers/perf/arm_pmu_acpi.c +++ b/drivers/perf/arm_pmu_acpi.c @@ -119,8 +119,10 @@ arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, pdev->resource[0].start = irq; ret = platform_device_register(pdev); - if (ret) + if (ret) { + platform_device_put(pdev); acpi_unregister_gsi(gsi); + } return ret; } -- 2.51.0