* [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le
[not found] <cover.1466612260.git.naveen.n.rao@linux.vnet.ibm.com>
@ 2016-06-22 16:25 ` Naveen N. Rao
2016-06-22 16:50 ` Thadeu Lima de Souza Cascardo
2016-06-23 9:26 ` [PATCHv2,1/7] " Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Naveen N. Rao @ 2016-06-22 16:25 UTC (permalink / raw)
To: linux-kernel, linuxppc-dev, netdev, Michael Ellerman
Cc: stable, Matt Evans, Denis Kirjanov, Paul Mackerras,
Alexei Starovoitov, Daniel Borkmann, David S. Miller,
Ananth N Mavinakayanahalli, Thadeu Lima de Souza Cascardo
Classic BPF JIT was never ported completely to work on little endian
powerpc. However, it can be enabled and will crash the system when used.
As such, disable use of BPF JIT on ppc64le.
Cc: stable@vger.kernel.org
Cc: Matt Evans <matt@ozlabs.org>
Cc: Denis Kirjanov <kda@linux-powerpc.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Reported-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
---
arch/powerpc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 01f7464..0a9d439 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -128,7 +128,7 @@ config PPC
select IRQ_FORCED_THREADING
select HAVE_RCU_TABLE_FREE if SMP
select HAVE_SYSCALL_TRACEPOINTS
- select HAVE_CBPF_JIT
+ select HAVE_CBPF_JIT if CPU_BIG_ENDIAN
select HAVE_ARCH_JUMP_LABEL
select ARCH_HAVE_NMI_SAFE_CMPXCHG
select ARCH_HAS_GCOV_PROFILE_ALL
--
2.8.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le
2016-06-22 16:25 ` [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Naveen N. Rao
@ 2016-06-22 16:50 ` Thadeu Lima de Souza Cascardo
2016-06-23 9:26 ` [PATCHv2,1/7] " Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2016-06-22 16:50 UTC (permalink / raw)
To: Naveen N. Rao
Cc: linux-kernel, linuxppc-dev, netdev, Michael Ellerman, stable,
Matt Evans, Denis Kirjanov, Paul Mackerras, Alexei Starovoitov,
Daniel Borkmann, David S. Miller, Ananth N Mavinakayanahalli
On Wed, Jun 22, 2016 at 09:55:01PM +0530, Naveen N. Rao wrote:
> Classic BPF JIT was never ported completely to work on little endian
> powerpc. However, it can be enabled and will crash the system when used.
> As such, disable use of BPF JIT on ppc64le.
Thanks, Naveen.
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
>
> Cc: stable@vger.kernel.org
> Cc: Matt Evans <matt@ozlabs.org>
> Cc: Denis Kirjanov <kda@linux-powerpc.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Alexei Starovoitov <ast@fb.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Reported-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
> arch/powerpc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 01f7464..0a9d439 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -128,7 +128,7 @@ config PPC
> select IRQ_FORCED_THREADING
> select HAVE_RCU_TABLE_FREE if SMP
> select HAVE_SYSCALL_TRACEPOINTS
> - select HAVE_CBPF_JIT
> + select HAVE_CBPF_JIT if CPU_BIG_ENDIAN
> select HAVE_ARCH_JUMP_LABEL
> select ARCH_HAVE_NMI_SAFE_CMPXCHG
> select ARCH_HAS_GCOV_PROFILE_ALL
> --
> 2.8.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2,1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le
2016-06-22 16:25 ` [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Naveen N. Rao
2016-06-22 16:50 ` Thadeu Lima de Souza Cascardo
@ 2016-06-23 9:26 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2016-06-23 9:26 UTC (permalink / raw)
To: Naveen N. Rao, linux-kernel, linuxppc-dev, netdev
Cc: Matt Evans, Daniel Borkmann, Alexei Starovoitov, Denis Kirjanov,
Thadeu Lima de Souza Cascardo, stable, Paul Mackerras,
David S. Miller, Ananth N Mavinakayanahalli
On Wed, 2016-22-06 at 16:25:01 UTC, "Naveen N. Rao" wrote:
> Classic BPF JIT was never ported completely to work on little endian
> powerpc. However, it can be enabled and will crash the system when used.
> As such, disable use of BPF JIT on ppc64le.
>
> Reported-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Acked-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/844e3be47693f92a108cb1fb3b
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-23 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1466612260.git.naveen.n.rao@linux.vnet.ibm.com>
2016-06-22 16:25 ` [PATCHv2 1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le Naveen N. Rao
2016-06-22 16:50 ` Thadeu Lima de Souza Cascardo
2016-06-23 9:26 ` [PATCHv2,1/7] " Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).