From: Paul Cercueil <paul@crapouillou.net>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Simon Ser <contact@emersion.fr>,
od@zcrc.me, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane
Date: Mon, 29 Mar 2021 16:39:02 +0100 [thread overview]
Message-ID: <25MQQQ.YYKN0GE2YPZN1@crapouillou.net> (raw)
In-Reply-To: <20210329153541.a3yil2aqsrtf2nlj@gilmour>
Le lun. 29 mars 2021 à 17:35, Maxime Ripard <maxime@cerno.tech> a
écrit :
> On Mon, Mar 29, 2021 at 04:15:28PM +0100, Paul Cercueil wrote:
>> Hi Maxime,
>>
>> Le lun. 29 mars 2021 à 16:07, Maxime Ripard <maxime@cerno.tech> a
>> écrit :
>> > On Sat, Mar 27, 2021 at 11:22:14AM +0000, Paul Cercueil wrote:
>> > > The ingenic-drm driver has two mutually exclusive primary
>> planes
>> > > already; so the fact that a CRTC must have one and only one
>> primary
>> > > plane is an invalid assumption.
>> >
>> > I mean, no? It's been documented for a while that a CRTC should
>> only
>> > have a single primary, so I'd say that the invalid assumption was
>> that
>> > it was possible to have multiple primary planes for a CRTC.
>>
>> Documented where?
>>
>> I did read the doc of "enum drm_plane_type" in <drm/drm_plane.h>,
>> and the
>> DRM_PLANE_TYPE_PRIMARY describes my two planes, so I went with that.
>
> At least since 4.9, this was in the documentation generated for DRM:
> https://elixir.bootlin.com/linux/v4.9.263/source/drivers/gpu/drm/drm_plane.c#L43
Ok, I read that as "all drivers should provide AT LEAST one primary
plane per CRTC", and not as "all drivers should provide ONE AND ONLY
ONE primary plane per CRTC". My bad.
-Paul
next prev parent reply other threads:[~2021-03-29 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 11:22 [PATCH] drm: DON'T require each CRTC to have a unique primary plane Paul Cercueil
2021-03-27 11:24 ` Simon Ser
2021-03-27 11:26 ` Paul Cercueil
2021-03-29 8:15 ` Pekka Paalanen
2021-03-29 11:41 ` Paul Cercueil
2021-03-29 14:35 ` Pekka Paalanen
2021-03-29 15:21 ` Paul Cercueil
2021-03-29 14:07 ` Maxime Ripard
2021-03-29 14:11 ` Simon Ser
2021-03-29 15:32 ` Paul Cercueil
2021-03-29 15:36 ` Simon Ser
2021-03-30 6:55 ` Pekka Paalanen
2021-03-29 15:15 ` Paul Cercueil
2021-03-29 15:35 ` Maxime Ripard
2021-03-29 15:39 ` Paul Cercueil [this message]
2021-03-29 15:42 ` Simon Ser
2021-03-29 16:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25MQQQ.YYKN0GE2YPZN1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=od@zcrc.me \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox