From: Danilo Krummrich <dakr@kernel.org>
To: Philipp Stanner <phasta@kernel.org>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau: Fix race in nouveau_sched_fini()
Date: Fri, 24 Oct 2025 18:17:40 +0200 [thread overview]
Message-ID: <25c97722-e05d-467c-908e-baa31e636a44@kernel.org> (raw)
In-Reply-To: <20251024161221.196155-2-phasta@kernel.org>
On 10/24/25 6:12 PM, Philipp Stanner wrote:
> nouveau_sched_fini() uses a memory barrier before wait_event().
> wait_event(), however, is a macro which expands to a loop which might
> check the passed condition several times. The barrier would only take
> effect for the first check.
>
> Replace the barrier with a function which takes the spinlock.
>
> Cc: stable@vger.kernel.org # v6.8+
> Fixes: 5f03a507b29e ("drm/nouveau: implement 1:1 scheduler - entity relationship")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Acked-by: Danilo Krummrich <dakr@kernel.org>
next prev parent reply other threads:[~2025-10-24 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 16:12 [PATCH] drm/nouveau: Fix race in nouveau_sched_fini() Philipp Stanner
2025-10-24 16:17 ` Danilo Krummrich [this message]
2025-10-27 13:00 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c97722-e05d-467c-908e-baa31e636a44@kernel.org \
--to=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox