Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "secu100@gmx.net" <secu100@gmx.net>
To: stable@vger.kernel.org
Cc: kernel@vger.kernel.org, ",patches"@lists.linux.dev
Subject: [PATCH 6.1.23] ALSA: hda/realtek: Add quirk for HP ENVY Laptop 17-cr0xxx
Date: Thu, 13 Apr 2023 10:28:54 +0200	[thread overview]
Message-ID: <25ce0797-1d40-6e2b-0895-c4ca85aad2e6@gmx.net> (raw)

The patch of the file patch_realtek.c fixes the speaker output on the HP
ENVY Laptop 17-cr0xxx. The LEDs for muting the microphone and speakers
still do not work. Likewise, the hotkey for microphone muting is without
function.

This laptop model uses actually the Realtek ALC245 codec alongside with
Cirrus Logic amplifiers. In the bios there seems to be no _DSD property
specified in the ACPI tables of the CSC3551 section. Therefore, the file
cs35l41_hda.c must also be patched.

Even if a patch of the file cs35l41_hda.c is excluded, it would make
sense to make the adjustment in the file patch_realtek.c. then the sound
output would work in case of a bios update on the part of the manufacturer.


--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9426,6 +9426,7 @@ static const struct snd_pci_quirk alc269
      SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9",
ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
      SND_PCI_QUIRK(0x103c, 0x89ca, "HP",
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
      SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)",
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+    SND_PCI_QUIRK(0x103c, 0x8a2e, "HP ENVY Laptop 17-cr0xxx",
ALC287_FIXUP_CS35L41_I2C_2),
      SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One",
ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
      SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)",
ALC236_FIXUP_HP_GPIO_LED),
      SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
ALC236_FIXUP_HP_GPIO_LED),



--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -1244,6 +1244,10 @@ static int cs35l41_no_acpi_dsd(struct cs
          hw_cfg->bst_type = CS35L41_EXT_BOOST;
          hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
          hw_cfg->gpio1.valid = true;
+    } else if (strncmp(hid, "CSC3551", 7) == 0) {
+        hw_cfg->bst_type = CS35L41_EXT_BOOST;
+        hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
+        hw_cfg->gpio1.valid = true;
      } else {
          /*
           * Note: CLSA010(0/1) are special cases which use a slightly
different design.


             reply	other threads:[~2023-04-13  8:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  8:28 secu100 [this message]
2023-04-13  8:32 ` [PATCH 6.1.23] ALSA: hda/realtek: Add quirk for HP ENVY Laptop 17-cr0xxx secu100
2023-04-13  9:14   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ce0797-1d40-6e2b-0895-c4ca85aad2e6@gmx.net \
    --to=secu100@gmx.net \
    --cc=",patches"@lists.linux.dev \
    --cc=kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox