From: David Howells <dhowells@redhat.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, Ilya Dryomov <idryomov@gmail.com>,
Xiubo Li <xiubli@redhat.com>,
ceph-devel@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: krb5 - filter out async aead implementations at alloc
Date: Fri, 15 May 2026 12:47:05 +0100 [thread overview]
Message-ID: <2632015.1778845625@warthog.procyon.org.uk> (raw)
In-Reply-To: <20260510232455.2245650-1-michael.bommarito@gmail.com>
Michael Bommarito <michael.bommarito@gmail.com> wrote:
> - ci = crypto_alloc_aead(krb5->encrypt_name, 0, 0);
> + ci = crypto_alloc_aead(krb5->encrypt_name, 0, CRYPTO_ALG_ASYNC);
Apologies, but doesn't that do the opposite of what we want?
Documentation/crypto/architecture.rst says:
The mask flag restricts the type of cipher. The only allowed flag is
CRYPTO_ALG_ASYNC to restrict the cipher lookup function to
asynchronous ciphers. Usually, a caller provides a 0 for the mask
flag.
Don't we want only synchronous ciphers?
David
next prev parent reply other threads:[~2026-05-15 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 13:25 [PATCH] crypto: krb5 - wait for async aead completion before freeing buffer Michael Bommarito
2026-05-05 5:54 ` Herbert Xu
2026-05-10 23:24 ` [PATCH v2] crypto: krb5 - filter out async aead implementations at alloc Michael Bommarito
2026-05-15 10:27 ` Herbert Xu
2026-05-15 11:47 ` David Howells [this message]
2026-05-15 12:05 ` Michael Bommarito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2632015.1778845625@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=idryomov@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=michael.bommarito@gmail.com \
--cc=stable@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox