From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95FBAC43381 for ; Sun, 17 Mar 2019 14:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67E9F20896 for ; Sun, 17 Mar 2019 14:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbfCQOUK convert rfc822-to-8bit (ORCPT ); Sun, 17 Mar 2019 10:20:10 -0400 Received: from mondschein.lichtvoll.de ([194.150.191.11]:47371 "EHLO mail.lichtvoll.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726204AbfCQOUK (ORCPT ); Sun, 17 Mar 2019 10:20:10 -0400 Authentication-Results: auth=pass smtp.auth=martin smtp.mailfrom=martin@lichtvoll.de Received: from 127.0.0.1 (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lichtvoll.de (Postfix) with ESMTPSA id 343DC4835C1; Sun, 17 Mar 2019 15:20:08 +0100 (CET) From: Martin Steigerwald To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Jens Axboe , Christoph Hellwig , Hannes Reinecke , Ming Lei , Johannes Thumshirn , Oleksandr Natalenko , stable@vger.kernel.org, Jisheng Zhang Subject: Re: [PATCH] Avoid that a kernel warning appears during system resume Date: Sun, 17 Mar 2019 15:20:06 +0100 Message-ID: <2683612.6HTjCspbsH@merkaba> In-Reply-To: <7436af16-0e46-418f-cfec-1ae530b2a82a@acm.org> References: <20190315232758.221199-1-bvanassche@acm.org> <4337330.mz4Gj9yf0O@merkaba> <7436af16-0e46-418f-cfec-1ae530b2a82a@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Bart. Bart Van Assche - 16.03.19, 22:28: > On 3/16/19 3:43 AM, Martin Steigerwald wrote: > > Bart Van Assche - 16.03.19, 00:27: > >> Since scsi_device_quiesce() skips SCSI devices that have another > >> state than RUNNING, OFFLINE or TRANSPORT_OFFLINE, > >> scsi_device_resume() should not complain about SCSI devices that > >> have been skipped. Hence this patch. This patch avoids that the > >> following warning appears> > >> during resume: > > Am I on CC cause one of those warnings appeared in bug reports from > > me from quite some time ago? […] > That's correct. I hope that you don't mind that I cc'ed you? No, I don't mind. Would you like me to apply the patch in order to test it? As it is just about suppressing a kernel warning and not changing any major functionality, I wondered whether you like me to do with this or whether the CC is more JFYI. > >> WARNING: CPU: 3 PID: 1039 at blk_clear_pm_only+0x2a/0x30 > >> CPU: 3 PID: 1039 Comm: kworker/u8:49 Not tainted 5.0.0+ #1 > >> Hardware name: LENOVO 4180F42/4180F42, BIOS 83ET75WW (1.45 ) > > > > This at least does not appear to be this ThinkPad T520, as I have > > BIOS version 1.49 already. > > The call trace in the patch description is only an example. I think > the problem description and the patch applies to all systems that > have one or more SCSI disks. Best, -- Martin