Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "chenjun (AM)" <chenjun102@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"deller@gmx.de" <deller@gmx.de>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
	"xuqiang (M)" <xuqiang36@huawei.com>
Subject: Re: [PATCH stable 4.14 v2 2/3] fbcon: Prevent that screen size is smaller than font size
Date: Thu, 4 Aug 2022 12:01:57 +0000	[thread overview]
Message-ID: <26cfcda29c38417e83ecd4e0e35297c3@huawei.com> (raw)
In-Reply-To: YuuyebRA0slDJVwx@kroah.com

在 2022/8/4 19:50, Greg KH 写道:
> On Thu, Aug 04, 2022 at 11:15:38AM +0000, Chen Jun wrote:
>> From: Helge Deller <deller@gmx.de>
>>
>> commit e64242caef18b4a5840b0e7a9bff37abd4f4f933 upstream
>>
>> We need to prevent that users configure a screen size which is smaller than the
>> currently selected font size. Otherwise rendering chars on the screen will
>> access memory outside the graphics memory region.
>>
>> This patch adds a new function fbcon_modechange_possible() which
>> implements this check and which later may be extended with other checks
>> if necessary.  The new function is called from the FBIOPUT_VSCREENINFO
>> ioctl handler in fbmem.c, which will return -EINVAL if userspace asked
>> for a too small screen size.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Link: https://lore.kernel.org/all/20220706150253.2186-1-deller@gmx.de/
>> [sudip: adjust context]
> 
> Who is "sudip" here?

Em..I misunderstood the meaning "sudip". I just mean I made some 
contextual adjustments.

> And the Link: line wasn't in the original commit, where did that come
> from?
> 

The mainline commit appears to be from this link. Should I remove the link?

> thanks,
> 
> greg k-h
> 

-- 
Regards
Chen Jun

  reply	other threads:[~2022-08-04 12:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 11:15 [PATCH stable 4.14 v2 0/3] add fix patches for CVE-2021-33655 Chen Jun
2022-08-04 11:15 ` [PATCH stable 4.14 v2 1/3] printk: Export is_console_locked Chen Jun
2022-08-04 11:15 ` [PATCH stable 4.14 v2 2/3] fbcon: Prevent that screen size is smaller than font size Chen Jun
2022-08-04 11:50   ` Greg KH
2022-08-04 12:01     ` chenjun (AM) [this message]
2022-08-04 12:09       ` Greg KH
2022-08-04 12:21         ` chenjun (AM)
2022-08-04 11:15 ` [PATCH stable 4.14 v2 3/3] fbmem: Check virtual screen sizes in fb_set_var() Chen Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26cfcda29c38417e83ecd4e0e35297c3@huawei.com \
    --to=chenjun102@huawei.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=deller@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=xuqiang36@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox