From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="VEmjG4Wi" Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4F6B1D0 for ; Tue, 28 Nov 2023 01:23:55 -0800 (PST) Received: from pwmachine.localnet (85-170-33-133.rev.numericable.fr [85.170.33.133]) by linux.microsoft.com (Postfix) with ESMTPSA id 0F30720B74C0; Tue, 28 Nov 2023 01:23:53 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0F30720B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1701163434; bh=XHlgjDQfi7sEqRucjGgnmeG94JlW0ZRegtJQnZlsMc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VEmjG4WiF6D3aSDeCEjvPUZJdF1fmvNpjamql/yFK93hNeo42K2h9tVhHI+V67+7T hf/NehR51VLC1jD7LYXB/XdIqBXjWJu7rTtKgwzh7RLZMHHKmQk3d9gWUjh/PAOMOP 7F0+9vOf3KwT6iO8rGlyxy/lHTobB5pLJGQmKy84= From: Francis Laniel To: Greg KH Cc: stable@vger.kernel.org, Masami Hiramatsu Subject: Re: [PATCH 4.19.y] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols Date: Tue, 28 Nov 2023 10:23:51 +0100 Message-ID: <2708527.mvXUDI8C0e@pwmachine> In-Reply-To: <2023112749-dismay-blemish-3eac@gregkh> References: <2023102138-riverbed-senator-e356@gregkh> <2305896.ElGaqSPkdT@pwmachine> <2023112749-dismay-blemish-3eac@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi! Le lundi 27 novembre 2023, 18:58:10 CET Greg KH a =C3=A9crit : > On Mon, Nov 27, 2023 at 06:36:32PM +0100, Francis Laniel wrote: > > Hi! > >=20 > > Le lundi 27 novembre 2023, 16:44:22 CET Greg KH a =C3=A9crit : > > > On Mon, Nov 27, 2023 at 03:41:31PM +0100, Francis Laniel wrote: > > > > Hi! > > > >=20 > > > > Le vendredi 24 novembre 2023, 17:17:04 CET Greg KH a =C3=A9crit : > > > > > On Fri, Nov 24, 2023 at 01:24:13PM +0100, Francis Laniel wrote: > > > > > > When a kprobe is attached to a function that's name is not uniq= ue > > > > > > (is > > > > > > static and shares the name with other functions in the kernel), > > > > > > the > > > > > > kprobe is attached to the first function it finds. This is a bug > > > > > > as > > > > > > the > > > > > > function that it is attaching to is not necessarily the one that > > > > > > the > > > > > > user wants to attach to. > > > > > >=20 > > > > > > Instead of blindly picking a function to attach to what is > > > > > > ambiguous, > > > > > > error with EADDRNOTAVAIL to let the user know that this function > > > > > > is > > > > > > not > > > > > > unique, and that the user must use another unique function with= an > > > > > > address offset to get to the function they want to attach to. > > > > > >=20 > > > > > > Link: > > > > > > https://lore.kernel.org/all/20231020104250.9537-2-flaniel@linux= =2Emi > > > > > > cros > > > > > > oft > > > > > > .com/ > > > > > >=20 > > > > > > Cc: stable@vger.kernel.org > > > > > > Fixes: 413d37d1eb69 ("tracing: Add kprobe-based event tracer") > > > > > > Suggested-by: Masami Hiramatsu > > > > > > Signed-off-by: Francis Laniel > > > > > > Link: > > > > > > https://lore.kernel.org/lkml/20230819101105.b0c104ae4494a7d1f2e= ea7 > > > > > > 42@k > > > > > > ern > > > > > > el.org/ Acked-by: Masami Hiramatsu (Google) > > > > > > Signed-off-by: Masami Hiramatsu (Google) > > > > > > (cherry picked from commit > > > > > > b022f0c7e404887a7c5229788fc99eff9f9a80d5) > > > > > > --- > > > > > >=20 > > > > > > kernel/trace/trace_kprobe.c | 48 > > > > > > +++++++++++++++++++++++++++++++++++++ > > > > > > 1 file changed, 48 insertions(+) > > > > >=20 > > > > > Again, we need a version for 5.4.y as well before we can take this > > > > > version. > > > >=20 > > > > I sent the 5.4.y patch some times ago, you can find it here: > > > > https://lore.kernel.org/stable/20231023113623.36423-2-flaniel@linux= =2Emi > > > > cros > > > > oft.com/ > > > >=20 > > > > With the recent batch I sent, I should have cover all the stable > > > > kernels. > > > > In case I miss one, please indicate it to me so I can fix this prob= lem > > > > and > > > > ensure all stable kernels have a corresponding patch. > > >=20 > > > I only see the following in my stable mbox right now: > > > 1 C Nov 27 Francis Laniel (4.4K) =E2=94=AC=E2=94=80>[PATCH 5.10= =2Ey] tracing/ kprobes: > > > Return EADDRNOTAVAIL when func matches several symbols 2 r C Nov 24 > > > Francis > > > Laniel (4.4K) =E2=94=94=E2=94=80>[PATCH 5.10.y] tracing/kprobes: Ret= urn EADDRNOTAVAIL > > > when > > > func matches several symbols 3 F Nov 24 To Francis Lani (1.5K) = =E2=94=94=E2=94=80> > > >=20 > > > 4 r T Nov 27 Francis Laniel (1.9K) =E2=94=94=E2=94=80> > > > 5 F Nov 27 To Francis Lani (2.0K) =E2=94=94=E2=94=80> > > > =20 > > > 23 r C Nov 24 Francis Laniel (2.7K) [PATCH 4.19.y] tracing/kprobes: > > > Return EADDRNOTAVAIL when func matches several symbols 24 r + Nov 27 > > > Francis Laniel (2.0K) =E2=94=94=E2=94=80> > > >=20 > > > So could you resend them all just to be sure I have all of the latest > > > versions that you wish to have applied? > >=20 > > I normally sent again the patch for version 4.14 to 5.15 (it was already > > present in 6.1 and 6.6). > > I tested all of them by building the corresponding kernel with the patch > > applied before sending, so they should not break compilation or testing. > >=20 > > Can you please confirm me you received them? >=20 > Got them now, thanks, I'll dig through them after this latest round of > stable kernels gets released. You are welcome! Take your time, this is indeed a bug fix but not a major one (I am doubtful= =20 plenty of people met this). If you find anything wrong with one of the patch, send a message and I will= for=20 sure polish it. > thanks, >=20 > greg k-h Best regards.